1. 04 4月, 2013 1 次提交
    • L
      qemu.tests: Use params[] for required params · a9f0d2c5
      Lukáš Doktor 提交于
      This patch benefits from the better error message when key is missing
      in config params. Instead of custom handling of missing param it
      uses params[] directly.
      
      I modified those params, where I was 100% certain that they are
      required and doesn't have default value:
       * val = params.get(..) followed by if not val: raise...
       * int(params.get(...))
       * params.get(...).split()
       * commands which require string (eg. session.cmd(params.get(...)))
      
      I didn't test all the tests before and after in order to verify
      possible typos but I used pylint before and after, watching for
      new errors (code rate before and after).
      Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>
      a9f0d2c5
  2. 25 12月, 2012 1 次提交
  3. 30 11月, 2012 1 次提交
  4. 30 10月, 2012 1 次提交
  5. 23 10月, 2012 1 次提交
    • M
      kvm.tests.qemu_img:use the same qemu_img_binary to backup and commit · b5d16e4f
      Mike Qiu 提交于
      Currently, the commit test just use qemu_img, which
      install in the system as default, to make the backup
      file, and use the qemu_img_binary which get the path
      from env file. Thus may bring some bugs.
      
      For example, if just use the qemu source code and
      don't make install to the system(that means the
      system haven't installed a qemu to /usr/local/bin
      or other system bin path, and autotest just test
      the qemu using the git tree), the test will not
      find the qemu_img_binary to create the backing_file.
      
      and another problem is the binary used to backup and
      commit may be different version, this may cause a bug.
      
      To solve the problem, make the same binary to backup
      and commit.
      Signed-off-by: NMike Qiu <qiudayu@linux.vnet.ibm.com>
      b5d16e4f
  6. 07 9月, 2012 2 次提交