Fix some extra problems with docstrings in the code tree.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This file is also borrowed from autotest, and already
reflects the updates to the coding style of the projects
under the autotest umbrella.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This way we can keep those scripts in sync among
virt-test and autotest.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Make virt-test to have a docstring style mostly compliant with
the sphinx's [1] format, reStructured text. This means that
we have to trade all '@' tags to be ':', mostly.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Options of run_pep8 tool is changed, then the description
should be updated at the same time.
Signed-off-by: NDongsheng Yang <yangds.fnst@cn.fujitsu.com>

It's possible to install libvirt bits w/o installing kvm or xen.  This
will be reflected in 'virsh capabilities' output, but the VM class just
reports a key error.  Added two specific error logging messages to make
the problem clearer, but continue to raise the original exception.
Signed-off-by: NChris Evich <cevich@redhat.com>

virttest.libvirt_storage_unittest: remove ModuleLoadCheckVirsh class.

Since we initialize a bogus_virsh in setup to provide a fake virsh for unittest,
then there is no need to skip if virsh command is not available.
Signed-off-by: NDongsheng Yang <yangds.fnst@cn.fujitsu.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With the help of the PEP8 script, a semi-automated clean
of the code base was made, and effectively changing some
of the coding style rules of our code base:

 * No more 2 lines spacing among functions
 * No more combined module imports

In the end, it was going to be too difficult to take
into consideration E501 (line length > 80) errors and
W601 (.has_key() is deprecated), so these were ignored,
at least for now.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Using the program codespell

https://github.com/lucasdemarchi/codespell

We found a number of spelling mistakes, that could be
found and fixed. The result of the automated script
was double checked, of course.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Integrate codespell to our own check_patch.py script.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Integrate the PEP8 linter into the virt-test full
tree and patch verification process. It works by
verifying whether the PEP8 linter modified the file in
place, if it did, it means there are non compliances
in the code.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>
Signed-off-by: Nyangdongsheng <yangds.fnst@cn.fujitsu.com>

This calls the PEP8 linter called autopep8:

https://github.com/hhatto/autopep8

So we can make autotest to fully adhere to PEP8,
since there's a tool that can enforce the standard.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>
Signed-off-by: Nyangdongsheng <yangds.fnst@cn.fujitsu.com>

This unittest was calling vm_xml.VMXML.new_from_dumpxml
with wrong positional arguments, making the function
ignore the dummy virsh instance passed, causing errors.
Let's fix this bug.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NChris Evich <cevich@redhat.com>

The pool_autostart function was not being overriden in virsh instance,
but dummy function already written.  I just added it into setUp() now
unittest is working perfectly when run as non-root.
Signed-off-by: NChris Evich <cevich@redhat.com>

* Replace real virsh module with a bogus virsh module
* Rewrite relative virsh pool functions for unittest.
  With setting output to static strings.
Signed-off-by: NYu Mingfei <yumingfei@cn.fujitsu.com>

fix not all disk listed issue, get cdrom drive letter with
utils_misc.get_winutils_vol();
Signed-off-by: NXu Tian <xutian@redhat.com>

Our check_patch and run_unittests scripts both run all unittest files IN
PARALLEL, not one at a time. This leads to some really interesting and
difficult to debug problems, like one test deleting/modifying temp files
or state for another test.  Problems here are:

1) The VIRSH_EXEC logic isn't working right, and because the virsh
module is sharing memory, changing virsh.virsh_exec in your test is
interfering with other tests.

2) Many tests are calling self.sp.method() which execute real virsh
commands. This is fine, except that they don't all work w/o root access
and therefore are dependant on external state.
Signed-off-by: NChris Evich <cevich@redhat.com>

Mainly minor items that should have no effect on tests.  Some
more risky changes were made to set_agent_channel() and
get_iface_dev() methods.  Those changes were made because
it made line-wrapping easier (lines were too long) and to
make parameter passing more clear (redundant ** magic).
Signed-off-by: NChris Evich <cevich@redhat.com>

Migrate multiple vms with these features:
1.Orderly or simultaneous migration.
2.Simple live migration or combination options.
3.Different migration method.
Signed-off-by: NYu Mingfei <yumingfei@cn.fujitsu.com>

Signed-off-by: NYu Mingfei <yumingfei@cn.fujitsu.com>

nic_extra_params were using an incorrect regexp to match additional
params. Use split instead similarily to blk_extra_params.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

blk_extra_params were accidentally left out while rewriting
images creation. Split them and assign them as normal params.

NOTE: This version would work only for params in the standard way
      %s=%s,... Currently I haven't found any other use so I hope
      this will last for ever.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

As an active NetworkManager may give us problems during
testing, stop the daemon before bonding. add a random wait
time before and after set_link.
Signed-off-by: NYunping Zheng <yunzheng@redhat.com>

Currently our script set bridge forward to 0, it cann't work
in some os. checking bridge doc 802.1D-1998 and latest
802.1D-2004, in these docs Bridege Forward Delay range time
is 4.0-30.0 seconds. so modify the value to 4
Signed-off-by: NYunping Zheng <yunzheng@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

Add missed test scenario '1 0', AKA "indirect_desc on, event_idx off" test;
Signed-off-by: NXu Tian <xutian@redhat.com>

Update virsh vcpuinfo test.

Signed-off-by: NYu Mingfei <yumingfei@cn.fujitsu.com>

* Specify string format arguments for logging functions.
* Remove unused variables.
* Replace invalid name "e" to "detail".
Signed-off-by: NYu Mingfei <yumingfei@cn.fujitsu.com>

Path /var/run/libvirt/lxc means there is a running lxc guest, but not the lxc
driver is available.
Signed-off-by: Nyangdongsheng <yangds.fnst@cn.fujitsu.com>

B/c the errors in __del__() will be ignored, then we want
user call conn_recover() manually our of __del__().

* rename conn_finish to conn_recover.
* add auto_recover into __init__.
Signed-off-by: Nyangdongsheng <yangds.fnst@cn.fujitsu.com>

* Add a unittest for tmp_dir to make sure it is unique for
  each instance.
* Add three unittests for functions in utils_conn which build
  CA key.
Signed-off-by: Nyangdongsheng <yangds.fnst@cn.fujitsu.com>

* Remove tmp_dir from param of __init__, and build tmp_dir
  using tempfile to assure it unique for each instance.
* Add more comment for the varaibles of connection class to
  make it more clear.
* Pick the CA key build method out from TLSConnection as a
  function in utils_conn.
Signed-off-by: Nyangdongsheng <yangds.fnst@cn.fujitsu.com>

Signed-off-by: Nyangdongsheng <yangds.fnst@cn.fujitsu.com>