Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NCong Li <coli@redhat.com>

s/Unknow/Unknown
Signed-off-by: NWei Jiangang <weijg.fnst@cn.fujitsu.com>

'virttest.aexpect' was refactored and turned to its own project.
Let's update all the references to simply 'aexpect'
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The return of utils_misc.find_substring() should be checked,
not the output of monitor.info() or monitor.human_monitor_cmd().

this patch only replaces 'ppc64' checks for 'ppc64' and 'ppc64le' checks.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The new pep8 adds W503 line break before %s check. This is mass style
update of autotest framework without any actual changes.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

changes from v1:
    add windows guest support;

changes from v2:
    remove extra image params in cfg and generate it by script
    fix issue that failed to check device id at rhel7 host
    limited test on Host_RHEL
changes form v3:
    fix typo error
    fix pep8 isssue
Signed-off-by: NXu Tian <xutian@redhat.com>

The value in a dictionary could not be matched directly,
convert to the string when matching.
Signed-off-by: NCong Li <coli@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

new device not always should in last line of lspci output, update
pci_find_cmd to reading new device from diff of lscpi output;
Signed-off-by: NXu Tian <xutian@redhat.com>

There's no need to have the name of the "run_<name>" method (main
test entry point) depend on the test name. So, for simplicity sake,
let's just name the test entry point "run".

I have decided to not fallback gracefully to the previous naming
convention as I believe this can lead to confusion in the future.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Add a useless parameter in device_add_block().

These two function called by following code:
        try:
            # get function for adding device.
            add_fuction = local_functions["%s_%s" % (cmd_type, pci_type)]
        except Exception:
            raise error.TestError("No function for adding '%s' dev with '%s'" %
                                  (pci_type, cmd_type))
        after_add = None
        if add_fuction:
            # Do add pci device.
            after_add = add_fuction(pci_num, queues)

So they must have same parameters.
Now we meet error:
TypeError: device_add_block() takes exactly 1 argument (2 given)
Signed-off-by: NFeng Yang <fyang@redhat.com>

This patch have us fix "TypeError: int() argument must be a string or a number,
not 'NoneType'" error when queues parameter not set in config.
Signed-off-by: NFeng Yang <fyang@redhat.com>

Since this function is not a high level function.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The default scsi hba is lsi53c895a, but in ppc64, it is spapr-vscsi.

This patch to enable spapr-vscsi in ppc64 platform.
Signed-off-by: NMike Qiu <qiudayu@linux.vnet.ibm.com>

We need step reboot guest after hotplug/unplug pci device to verify guest
not crash or hang when reboot;
Signed-off-by: NXu Tian <xutian@redhat.com>

Make virt-test to have a docstring style mostly compliant with
the sphinx's [1] format, reStructured text. This means that
we have to trade all '@' tags to be ':', mostly.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With the help of the PEP8 script, a semi-automated clean
of the code base was made, and effectively changing some
of the coding style rules of our code base:

 * No more 2 lines spacing among functions
 * No more combined module imports

In the end, it was going to be too difficult to take
into consideration E501 (line length > 80) errors and
W601 (.has_key() is deprecated), so these were ignored,
at least for now.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

MQ was disabled in qemu by default, this patch enables it
if user assigns multiple queues, hotplug cases will hotadd
MQ nics.

| commit 32ab06bcf1352848eec42629a85e20efa4e105dc
| Author: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
| Date:   Tue Feb 5 17:47:17 2013 -0600
|
|     hw/virtio-net: disable multiqueue by default
|
|     The new multiqueue feature adds fields to the virtio device config, which
|     breaks Windows guests. Disable the feature by default until the Windows
|     drivers are fixed.
Signed-off-by: NAmos Kong <akong@redhat.com>

If we set the global test timeout as the timeout for
the hotplug operation, if it is reached due to a QEMU
bug the test will never end properly while executing
under autotest. So enforce a specific timeout,
a lot smaller than the typical global test timeout.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This test may run with qmp monitor, so the supported device
querying function should use human_monitor_cmd API explicitly.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

Turns out commit e9953f8a doesn't include the definition
of the function vm.is_supported_device, making this test
to fail. As a fix, instead of adding yet another vm method,
add a function local to the test, at least for now. This
function could be turned to an API in case it looks and
works OK to the other reviewers, although I'd like to
avoid API proliferation.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This patch adds sub test support for pci_hotplug test.
So that we can use following parameters to run some
sub test scripts during hotplug test.
 * sub_type_before_plug
 * sub_type_after_plug
 * sub_type_before_unplug
 * sub_type_after_unplug
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>
Acked-by: NFeng Yang <fyang@redhat.com>

This patch creates a series of sub functions for device add
action in different version of qemu.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

This patch benefits from the better error message when key is missing
in config params. Instead of custom handling of missing param it
uses params[] directly.

I modified those params, where I was 100% certain that they are
required and doesn't have default value:
 * val = params.get(..) followed by if not val: raise...
 * int(params.get(...))
 * params.get(...).split()
 * commands which require string (eg. session.cmd(params.get(...)))

I didn't test all the tests before and after in order to verify
possible typos but I used pylint before and after, watching for
new errors (code rate before and after).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

In order to be consistent with previous changes.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

A frequent request we've got from users is that the name
'kvm' makes assumptions that are not true for a lot of
the use cases of the test suite. Then let's rename
the subtest 'kvm' to 'qemu', making it more accurate.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

All disk images, kernels and any file that will be
stored in the data dir should use the new data dir
reference.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>