Signed-off-by: NHaotong Chen <hachen@redhat.com>

Signed-off-by: NHaotong Chen <hachen@redhat.com>

Signed-off-by: NHaotong Chen <hachen@redhat.com>

Clean up imports across the board in tp-qemu. The criteria
followed was:

1) Remove unnecessary imports
2) Turn multi imports from a single entry point to one
   import per line. This increases both patch and
   source code readability.
3) Separate blocks of imports with a line:
   * Python standard library imports
   * Autotest imports
   * virttest imports
   * Internal tp-qemu imports
4) Remove try/except blocks refering autotest libs and
   stick with the virttest.staging copy

This paves the way for the future removal of autotest
references, replacing those references with avocado ones.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

'virttest.aexpect' was refactored and turned to its own project.
Let's update all the references to simply 'aexpect'
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

There's no need to have the name of the "run_<name>" method (main
test entry point) depend on the test name. So, for simplicity sake,
let's just name the test entry point "run".

I have decided to not fallback gracefully to the previous naming
convention as I believe this can lead to confusion in the future.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NJiří Župka <jzupka@redhat.com>

makes load_module test working again
Signed-off-by: NJiří Župka <jzupka@redhat.com>

Signed-off-by: NJiří Župka <jzupka@redhat.com>

Signed-off-by: NJiří Župka <jzupka@redhat.com>

Fix some extra problems with docstrings in the code tree.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With the help of the PEP8 script, a semi-automated clean
of the code base was made, and effectively changing some
of the coding style rules of our code base:

 * No more 2 lines spacing among functions
 * No more combined module imports

In the end, it was going to be too difficult to take
into consideration E501 (line length > 80) errors and
W601 (.has_key() is deprecated), so these were ignored,
at least for now.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NJiří Župka <jzupka@redhat.com>

Signed-off-by: NJiří Župka <jzupka@redhat.com>

Those files were added there mainly to mirror qemu,
since that is used as a module, since for that
case we do use things like

from qemu.tests import block_copy

That's not needed for libvirt, and we'd like to
dump it from qemu as well, although it needs
more care.

This solves a problem where it's not possible
to import the python library bindings on virt-test,
since the libvirt module present in virt-test would
take precedence over the library installed system
wide.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

When relying on the environment variable $AUTOTEST_PATH to locate
the autotest libraries, we only check if the variable is set. This
adds another sanity check, if the client library directory actually
exists.

This prevents an ImportError exception to be thrown with no clear
error message.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Useful to see details of the config update process.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NSatheesh Rajendran <sathnaga@linux.vnet.ibm.com>

Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>

Also select the machine type in guest-hw.  This is also useful to specify
versioned machine types in a cartesian config file.  Something like this:

    i440fx:
         variants:
         - i440fx-1.0:
              machine_type=pc-1.0
         - i440fx-1.1:
              machine_type=pc-1.1
         - i440fx-1.2:
              machine_type=pc-1.2

lets you run the test multiple times on all versioned types.
Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>

The option is not necessary anymore, as we have code specific for
-no-shutdown in the graceful-shutdown code path.

Other code that needs to wait until VM is paused outside
graceful_shutdown() may simply call wait_for_shutdown() or
wait_until_paused() directly.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

In order to simplify adding new guest os files, split
it and arrange it in a directory structure, very much
like it was done with subtests.cfg. This way it is
possible to define a new guest os dropping a snippet
as simple as:

- guest.name:
    image_name = images/guest-name
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

So that the config is fully functional.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

So that we can upgrade forcefully all config files for
a given test, useful for automated regression testing
of virt-tests.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Point out in the main test cfg file used by the test
runner (tests.cfg) that we're not supposed to modify
its contents, since we apply extra cartesian line
parsing on top of it.

CC: Qingtang Zhou <qzhou@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

A frequent request we've got from users is that the name
'kvm' makes assumptions that are not true for a lot of
the use cases of the test suite. Then let's rename
the subtest 'kvm' to 'qemu', making it more accurate.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Updating the openvswitch config files to keep up with the
current schema.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This is frequently a source of confusion among users,
so let's drop the .sample prefixes and use only .cfg
for all the config files. We can always exclude the
copied/auto generated ones using .gitignore.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

If the autotest libs can't be found, point the other
possible solution: Installing the autotest-framework
package (currently available only for Fedora).
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

That concentrates networking related code, such as the
VirtNet classes and Bridge manipulation.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

In order to organize our shared libraries better, we
have to slowly take functions from utils_misc and move
to other smaller, more specialized libraries. Let's
start by doing this with the bootstrap code [1], and
move it to a library called 'bootstrap'.

[1] Code that copies the correct config sample files
to the right places, as well as verifies whether the
JeOS image is available.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Add the following new options to the kvm get started
script, as well as the other scripts:

1) Add a verbose option, to show more debugging output
2) Add a --restore-image option, to restore JeOS from pristine
3) Add a --data-dir option, to choose a different data dir

Made some of the wording of the scripts slightly shorter.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

When the autotest-framework rpm libraries are used,
it was not possible for the bootstrap scripts to
find it. Fix this in all bootstrap scripts and
auxiliary module loading files (common.py).
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>