That concentrates networking related code, such as the
VirtNet classes and Bridge manipulation.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Make the sequence of import simpler and clearer.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

c is not defined. Let's use good ol' iteration to accomplish
the original idea of the method.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Create a specialized library to hold the PropCan class,
with a separate unittest file.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

with an appropriate getter method, and replace this in
the autotest wrapper module and stand alone test module.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Rather than repeating the code to locate the root dir
in the standalone_test module.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Containing the Env and Params classes.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Move all build helpers (used in the build test) to their
own library, 'build_helper', and modify users in the code
accordingly.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

In our quest to clean up utils_misc, move all koji related
code to utils_koji, and change all the users accordingly.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NChris Evich <cevich@redhat.com>

 new_from_dumpxml() in libvirt_xml.VMXML will not update
 its instance automatically.
 vmxml.new_from_dumpxml(vm.name, virsh)
                =>
 vmxml = vmxml.new_from_dumpxml(vm.name, virsh)
Signed-off-by: NYu Mingfei <yumingfei@cn.fujitsu.com>

Signed-off-by: NFeng Yang <fyang@redhat.com>

This script cover the test that hot unplug the original pci device
which is added in qemu command.

Changes from v1:
Delete useless code.
Now this case could not work for rhel5 host.
So delete pci_del part code which only works in rhel5 host.
Signed-off-by: NFeng Yang <fyang@redhat.com>

This script cover sr-iov hotplug test cases.

Changes from v1:
Delete useless line and module.
Signed-off-by: NFeng Yang <fyang@redhat.com>

Restart the guest if exception raised
Signed-off-by: NFeng Yang <fyang@redhat.com>

Set default value to /usr/bin/qemu-kvm
Signed-off-by: NFeng Yang <fyang@redhat.com>

Set mac_changeable to yes in sr-iov testing,
then update_mac_ip_address called to get guest's ip and mac.
Signed-off-by: NFeng Yang <fyang@redhat.com>

Current guest ip finding mechanism could not work for
sr-iov device.
This  function could login guest with serial, then get
guest ip.
Sometime sr-iov device in guest could not get ip, we have to
restart network in guest.
Also add find_substring function.

TODO:
this function only works when guest support serial,
we need a smarter way to get guest ip when sr-iov device used.
Signed-off-by: NFeng Yang <fyang@redhat.com>

After this patch, we can configure sr-iov device in the
same way as nic device. So older test case could run
with sr-iov device.

Changes from v1:
Recreate the patch accroding latest next tree.
Signed-off-by: NFeng Yang <fyang@redhat.com>

To set more sr-iov device, please use nics += "nic2 nic3"
Add some new parameters pf_filter_re, vf_filter_re, mac_ip_filter,
mac_changeable
Delete devices_requested.
Signed-off-by: NFeng Yang <fyang@redhat.com>

Fix some bugs in this class.
Add new function get_vf_status add_device
Use error.context in this class.
Make it works with multi vms.
Now it also support assign pf vf together.
Signed-off-by: NFeng Yang <fyang@redhat.com>

* Make virsh.dumpxml raise exception instead of returning ''
* Make XML parsing errors clearer by printing XML filename/string
Signed-off-by: NChris Evich <cevich@redhat.com>

* Fix check for type of virsh_instance parameter
* Default virsh_instance parameter to virsh module
  (needed for backward compatibility)
* Fix os_arch_machine_map bug
Signed-off-by: NChris Evich <cevich@redhat.com>

Signed-off-by: NChris Evich <cevich@redhat.com>

Pass the test suite's tmp dir to the build process of the
passfd c module, so the temporary object files does not
go to the virttest dir.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

In order to organize our shared libraries better, we
have to slowly take functions from utils_misc and move
to other smaller, more specialized libraries. Let's
start by doing this with the bootstrap code [1], and
move it to a library called 'bootstrap'.

[1] Code that copies the correct config sample files
to the right places, as well as verifies whether the
JeOS image is available.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

* Fixed a bunch of pylint complaints
* Fixed bug in virsh_restore
* Updated virsh_define to change in libvirt_xml constructors
Signed-off-by: NChris Evich <cevich@redhat.com>

* Cleaned up module docstring
* Fixed LibvirtXMLError bug
* Simplified initialization and virsh use (internal and external)
* Made __readonly__ method easier to use in subclasses
* LibvirtXMLBase.copy() bugfixes
* Made VMXML.new_from_dumpxml() into static method to wrap __new__
* Cleaned up some overly short variable names
Signed-off-by: NChris Evich <cevich@redhat.com>

* Virsh:
    * Fixed imports
    * Fixed VirshSession error-detection bug
    * Fixed VirshPersistent double-new_session bug
    * Fixed automatic __del__ / out-of-scope bug
    * Fixed double close_session exception bug
    * Cleaned up all logging calls for pylint's sake
    * Fixed up some API docstrings
    * Fixed parameter name clash (rename domname -> vm_name)

* Virsh unittest:
    * Fixed utils.process_is_alive logging annoyance
    * Added session-recycle test
    * Enhanced lingering virsh-process checks
    * Stopped printing of DEBUG messages during testing
Signed-off-by: NChris Evich <cevich@redhat.com>

    * Fixed missing __super__ calls in subclasses
    * Fixed XMLTreeFile __str__ bug
    * Fixed TempXMLFile unlink bug
    * Fixed corrupt-XML exception handling
    * Added unittest for __str__ method
Signed-off-by: NChris Evich <cevich@redhat.com>

In order to capture any qemu crashes, introduce a method
that scans qemu output and throws an error if a core dump
condition is found.

Improve verify_alive() by calling this function, among
others, and add a check on two of the most called functions
of the framework: vm.wait_for_login() and
vm.wait_for_serial_login().
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With this patch, if the screen got inactive during unattended
install for more than 30 minutes, an error will be thrown. For
any other tests, we'll just log a debug message, since in other
tests we do not expect to see much action going on the screen.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

In a very specific test (unattended_install), all OEM installer
mechanism will present intense guest screen activity, so screen
inactivity for a relatively long time almost always mean something
went very wrong and the installer is stuck.

So create a mechanism to detect screen inactivity for any vm that
takes place in the test - have a timer for each vm that is reset
only if the next screenshot is different than the previous. So,
if the vm got stuck somewhere at the install process, for example:

* Wrong Windows CD Key
* Guest OS does not see a disk controller due to lack of drivers
* BIOS got stuck

And other similar cases, we'll have a test failure before the full
test timeout (that for Windows may be up to 3 hours). So we save
time and know about such situations earlier.

Next patch introduces the parameters on base.cfg, subtests.cfg, and
also introduces a sensible default for inactivity treshold (30 min).
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Introduce a background error queue to store exceptions
happened during virt background tasks (such as aexpect
instances and screendump thread). With this queue,
it is possible to store exception information useful
to fail tests at certain points. Examples:

* We can detect qemu suffered a crash from inside the
  aexpect thread
* We can detect screen inactivity on the screendump
  thread and fail the unattended install test without
  having to wait the entire timeout of the test

The next patches will introduce that functionality.

Implementation consists in a virt test attribute,
background_error test, that is a Queue.Queue()
(thread safe), background threads that want to
make use of it need to catch the exception they
want to propagate and store it in the queue
using put(sys.exc_info).

Then in every convenient situation to do so, subtests
can call the test.verify_bg_errors() method
(in the beginning or end of each test loop, where
operations such as migrations are executed).
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This is a complement solution for issue #122.

Before running the tests, clean up all objects lying around
in the env file. This is safer and avoids errors that happen
here and there, and are hard to understand for people not
familiar with the virt tests structure.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>