Failed to insert the SCSI device into the specified HBA controller
because that setting the params "drive_bus" is to specify the HBA
the controller then call method list_missing_named_buses of
DevContainer to search HBA is used by iterating DevContainer.__buses
list. But the __buses list didn't change after hotplugging since calling
images_define_by_params and calling simple_hotplug are not used by
matching way, so the __buses list is still using the same.
Signed-off-by: NYongxue Hong <yhong@redhat.com>

Related tests:
1. block_hotplug
2. block_hotplug_negative
3. block_hotplug_in_pause
4. block_resize
5. disk_extension
Signed-off-by: Nlolyu <lolyu@redhat.com>

Cancel the testing when resizing to 2T on the windows bios guest and
16T on the windows ovmf guest since they don't support to do it.
Signed-off-by: NMenghuan Li <menli@redhat.com>

Update the order of importing modules by PEP8.

Wrap the codes to function:
  1. Update function find_disk and rename it.
  2. Update function run_sub_test.
  3. Wrap the part of waiting plugging disks completely to
     function wait_plug_disks.
  4. Wrap the part of creating block devices to function
     create_block_devices.
  5. Wrap the part of getting block devices to function
     get_block_devices.
  6. Wrap the part of hotplug or unplug block devices to
     function plug_block_devices.
  7. Wrap the part of format windows disk to function format_disk_win.
  8. Wrap the part of doing io testing on disk to function
     run_io_test.
  9. Update function get_disk_size.
Signed-off-by: NYongxue Hong <yhong@redhat.com>

Due to new block_resize file no need disk_update_cmd params,
so delete them, and update a few new block_resize.py needed params.
Signed-off-by: NPeixiu Hou <phou@redhat.com>

Add a case that hotplug a max image size disk with qcow2 and raw.
Signed-off-by: NYongxue Hong <yhong@redhat.com>

Need provide sufficient extra root port when there are more than 1
 devices to be hotplugged, since the default pcie_extra_root_port
is 1
Signed-off-by: NQianqian Zhu <qizhu@redhat.com>

paramter name 'check_img' is not correct, it should be 'check_image'
Signed-off-by: NYanan Fu <yfu@redhat.com>

Signed-off-by: NXueqiang Wei <xuwei@redhat.com>

The 'blk_extra_params' uses ',' as separator and not ' '. Using ' '
leads to ' serial' instead of 'serial' being passed as an argument.

Theoretically I could just use '=' without any separator, but in order
to keep '+=' I decided to simply add the separator here. Empty inputs
are automatically skipped on parsing.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

block_hotplug:
1.replace hotplug device definations by qcontainer.images_define_
by_params()
2.remove useless options in block_hotplug.cfg
3.replace hotplug/verify_hot|unplug by simple_hot|unplug()
4.extract sub_tests to run_sub_test()
Signed-off-by: NAihua Liang <aliang@redhat.com>

1. Modify the repeat time from 300 to 100 about with_repetition test.
   Repeat 300 times takes too long time.
2. Modify the repeat time from 3 to 1 about not repetition test.
   Repeat hotplug and unplug can be covered by with_repetition test.
3. Limited the with_shutdown.after_plug only with_plug,
   When test without_plug, this case is no needed.
Signed-off-by: NPeixiu Hou <phou@redhat.com>

block_resize.py only support extend/shrink on one data disk.
To keep consistency, set "only one_pci" in block_hotplug.cfg
for with_block_resize.
Signed-off-by: NAihua Liang <aliang@redhat.com>

Add subtest "block_resize" after hotplug.
Signed-off-by: NAihua Liang <aliang@redhat.com>

Signed-off-by: NZhengtong Liu <zhengtli@redhat.com>

data plane support for case "with_plug.with_system_reset.one_pci"
Signed-off-by: NAihua Liang <aliang@redhat.com>

Run iozone test on hotpluged data disk on windows guests.
Add test case reboot and shutdown guest after hotplug a data disk.
Signed-off-by: Npeixiu <phou@redhat.com>

In some enterprises, the default bootindex is -1 for system disk,
which means cancel the boot index.
If hotplug a data disk then reboot guest, qemu may set the data
disk with higher bootindex, which depends on different enterprises'
policies.
As above, need set bootindex=0 for system disk.
Signed-off-by: NCong Li <coli@redhat.com>

1. block_hotplug.cfg: add separate scenario for repeated plug/unplug, no need repeat 300 times for each scenario when one pci.
2. block_hotplug.py: get and close a separate session when using it to fix file descriptor out of range problem.
3. stop_continue.py: close session when test finished.
Signed-off-by: NCong Li <coli@redhat.com>

Signed-off-by: NCong Li <coli@redhat.com>

Add new case for block_hotplug, support block_virtio and
block_scsi with hotplug/unplug.
Signed-off-by: NShuping Cui <scui@redhat.com>

Signed-off-by: NCong Li <coli@redhat.com>

During the review of the repository split, it was pointed
out that 'agnostic' was a rather strange word, so we'll go
with 'generic'. I opted for not rebasing the PR, since I
had many problems when trying to do so.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This will make it easier when we're splitting these
tests into their own repositories.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

new device not always should in last line of lspci output, update
pci_find_cmd to reading new device from diff of lscpi output;
Signed-off-by: NXu Tian <xutian@redhat.com>

Some case will try to create images in shared/data/,
but it should be in shared/data/images/, update the
cfg file of these cases, so that it can create the
images in correct directory.
Signed-off-by: NMike Qiu <qiudayu@linux.vnet.ibm.com>

These tests will create some other format of image, so the
options for qcow3 would affect them.
To make these cases still work with qcow3 format, reset the
'image_extra_params' parameter in them.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

This patch creates a series of sub functions for device add
action in different version of qemu.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

We've only spot this mistake now :(
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

In order to have self describing tests, split the original
subtests.cfg in several per test files, and create subtests.cfg
out from this information.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>