Signed-off-by: Nqizhu <qizhu@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Add qdisks.errors into error infos and add
steps in error.context.
Signed-off-by: NShuping Cui <scui@redhat.com>

Clean up imports across the board in tp-qemu. The criteria
followed was:

1) Remove unnecessary imports
2) Turn multi imports from a single entry point to one
   import per line. This increases both patch and
   source code readability.
3) Separate blocks of imports with a line:
   * Python standard library imports
   * Autotest imports
   * virttest imports
   * Internal tp-qemu imports
4) Remove try/except blocks refering autotest libs and
   stick with the virttest.staging copy

This paves the way for the future removal of autotest
references, replacing those references with avocado ones.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The new pep8 adds W503 line break before %s check. This is mass style
update of autotest framework without any actual changes.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Add new function get_cpu_number() to get cpu sockets/cores/threads number.
Signed-off-by: NShuping Cui <scui@redhat.com>

There's no need to have the name of the "run_<name>" method (main
test entry point) depend on the test name. So, for simplicity sake,
let's just name the test entry point "run".

I have decided to not fallback gracefully to the previous naming
convention as I believe this can lead to confusion in the future.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The old method to get expect machine type can not fit machine type check for
q35 and pc. So update it by get the machine type string from the output
of qemu-kvm -M ?.
Signed-off-by: NYiqiao Pu <ypu@redhat.com>

There might be an occasion where we get the following
error:

TypeError: unsupported operand type(s) for +: 'MonitorProtocolError' and 'str'

So let's try to convert the exception class to a string
first.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Turns out RHEL5 qemu does not support the 'info qtree'
command, therefore an attempt to parse the output of
this command will fail. So skip that particular check
when running on this particular qemu version.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Make virt-test to have a docstring style mostly compliant with
the sphinx's [1] format, reStructured text. This means that
we have to trade all '@' tags to be ':', mostly.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With the help of the PEP8 script, a semi-automated clean
of the code base was made, and effectively changing some
of the coding style rules of our code base:

 * No more 2 lines spacing among functions
 * No more combined module imports

In the end, it was going to be too difficult to take
into consideration E501 (line length > 80) errors and
W601 (.has_key() is deprecated), so these were ignored,
at least for now.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Use Monitor.info_block() which covers all versions of "info block"
command to get the information.

Also update the cases which use this function to provide info_block
output instead the Monitor.info('block') one.

Last but not least add unittest.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Replace the method which used only disk names to match autotest
image format with virttest.qemu_qtree one. It additionally verifies
all kind of other params of "info qtree" and "info block".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Current code only works with human monitor info command,
so always use human monitor info command for qmp/human monitor.
Signed-off-by: NFeng Yang <fyang@redhat.com>

Improve physical_resources_check in serial name part.
  - Add a random serial name to guest less than 20 characters
  - Add strict check for serial name

changes from v1:
  - format modify
changes from v2:
  - move randome generate string to virt_utils
changes from v3:
  - move this test only for virtio_blk and only for RHEL 6 guest
    as test plan
changes from v4:
  - clean up and make this test will not run in Windows guests
Signed-off-by: NYiqiao Pu <ypu@redhat.com>
Acked-by: NFeng Yang <fyang@redhat.com>
Acked-by: NQingtang Zhou <qzhou@redhat.com>

Add machine_type check function to check the guest's machine type

change from v1:
1. change 'extra_params' to 'machine type'
2. add try except block when compare the result
Signed-off-by: NGolita Yue <gyue@redhat.com>

This patch benefits from the better error message when key is missing
in config params. Instead of custom handling of missing param it
uses params[] directly.

I modified those params, where I was 100% certain that they are
required and doesn't have default value:
 * val = params.get(..) followed by if not val: raise...
 * int(params.get(...))
 * params.get(...).split()
 * commands which require string (eg. session.cmd(params.get(...)))

I didn't test all the tests before and after in order to verify
possible typos but I used pylint before and after, watching for
new errors (code rate before and after).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

In order to be consistent with previous changes.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

As part of our changes from kvm -> qemu.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

A frequent request we've got from users is that the name
'kvm' makes assumptions that are not true for a lot of
the use cases of the test suite. Then let's rename
the subtest 'kvm' to 'qemu', making it more accurate.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

All disk images, kernels and any file that will be
stored in the data dir should use the new data dir
reference.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>