run: Introduce new options, change virt-test default behavior

In order to save time in virt-test:

1) The JeOS image is uncompressed once and reused
   every test, unless it is explicitly asked with
   --restore-image

2) After a test is done, the VMs won't be shut down
   unless it is explicitly asked with --restart-vm

3) After a test is done, the pristine image won't
   be restored, unless it is explicitly asked with
   --restore-image-between-tests

All of those behaviors, while might bring speed ups
to the test process, they are not safe. As users
frequently don't have the visibility of that when
using the test suite, we found out that it's in the
best interest of users and developers that the
defaults are changed to safer options.

With this, the options mentioned above changed to

--keep-guest-running
--keep-image
--keep-image-between-tests

The wording 'guest' was chose over 'vm' due to the
fact we already have --guest-os. So, mostly an attempt
to keep consistency.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

run: Add --console-level option, fix issue #179

With this we implement (admittedly very very late)
the functionality asked in issue #179. This introduces
a new --console-level option, that will allow people
using --verbose to adjust the level of the messages
printed to the console.

CC: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Spice tests updates/extensions (v3) (was #1076)

libvirt-tests: Fix some emulatorpin errors

libvirt: Add virsh net-info command test

run: Add --no-cleanup option

For debugging purposes, not cleaning up env files,
test tmp files and aexpect tmp files might be desirable.
So add this option to our test runner.

CC: Lukas Doktor <ldoktor@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

JeOS 19 ks: Fill up disk image so empty space can be removed

Add a last step post install that will make the JeOS
image to fill all 10GB of disk, so that we can easily
create an image with no empty space by using qemu-img

qemu-img convert -O qcow2 jeos-19-x86_64.qcow2 jeos-19-x86_64-output.qcow2
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

JeOS 19: Add qemu-guest-agent

It was argued that the agent is closely related to
virtualization testing, and it is small enough to
justify inclusion.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

virsh_snapshot_edit: Resolve test errors

virsh_snapshot_create_as: Adjustments from review

virsh.schedinfo_qemu_posix: update the way we get the cgroup path

Make the test runner more stable with 'safe' options

staging.utils_cgroup: change the regexp for finding correct cgroup path

Add test for virsh find-storage-pool-sources-as and bug fix

Mq change qnum

On an attempt to eliminate sources of disk corruption
and errors, delete the dst file if the src file is
avaliable.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Use SIGKILL instead of SIGTERM (the default for pkill)
when terminating the background process. This way we're
less likely to run into a situation where killing the
tcpdump command times out.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Sometimes, post migration run, we can run into a condition
where tcpdump or the VM hangs at migration cleanup stage.
After analyzing test logs, including VM logs, there's nothing
that points out to any guest OS crash or similar condition.

With that in mind, it is admissible to be more lenient
when trying to kill the migration background command, and
if a timeout happens when trying to kill it, be safe and
try to shut down the vm gracefully.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

As the pre processing code already takes care of that
anyway.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This class was logging a debug event every time it successfully
reused an aexpect session.  Since aexpect always loggs the command
being run anyway, this extra detail is mostly redundant.  If there's
a problem, an exception will be thrown anyway.
Signed-off-by: NChris Evich <cevich@redhat.com>

When using original sync of NetworkXML class to restore a backup
network, it is redefined and started, leaving autostart disabled.
This is not the default setting (all true for active/persistent/
autostart) for the network.

In this modification, we set the default behavior of sync to
set all state to true. With the help of an optional "state" dict
parameter, we can restore the network to any state you like, or
in practical, to the state we backed up.

To facilitate this backup & restore process, I also added a helper
function state_dict() to retrieve a active/persistent/autostart
dict for backing up current vm state.

The unittest for these network manipulators is given in a new file
instead of libvirt_xml_unittest.py to separate manipulator tests
from XML base test.

Furthermore, The net_state_dict function use an outdated way to get
the persistent property for the network, which is already changed
by a patch (commit 895913d) in libvirt-0.10.2. The persistent status
can be retrieved from net_list directly. So I add a condition to
ensure it can be backported for older libvirt while avoiding
redundant call of net_autostart when testing on new libvirt.

This backport can be removed if old libvirt no longer maintained.
Signed-off-by: NHao Liu <hliu@redhat.com>

virttest.env_process: Remove restart_vm option

The restart_vm option, that will restart a vm at the beginning
of postprocessing, is unnecessary, given that you could
simply shut down all the VMs at the end of each test,
forcing new vms to be started.

So get rid of this option, and replace --restart-vm
in ./run to use kill_vm = yes instead.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

When run after virsh.shutdown, the first virsh.start was failing with
because the domain was already started.  Adjusted the .cfg file to
ensure setting of the 'kill_vm_before_test' in the status_error_no
variant.

Also, changed the error returned from using 'stdout' to 'stderr' so that
"Domain is already active" would be displayed.

Signed-off-by: NMarian Krcmarik <mkrcmari@redhat.com>

This patch changes how remote-viewer is executed, so that we can get
it to work on windows machines, with proxy and connecting using
a provided file.
Delete useless keys send for r-v menu test.
Signed-off-by: NTomas Jamrisko <tjamrisk@redhat.com>
Signed-off-by: NMarian Krcmarik <mkrcmari@redhat.com>

Adding functions to install remote-viewer on windows client,
to generate a file with information required for connection
and also restarting of user interface on any VM (so far
linux only) and function for installing epel repo.
Signed-off-by: NTomas Jamrisko <tjamrisk@redhat.com>
Signed-off-by: NMarian Krcmarik <mkrcmari@redhat.com>

- Change path to deploy epel repository function which was moved
  to utils_spice under virttest.
- rv_clearx test does not exist anymore, use function from
  utils_spice as well.
- small refactor to fix warnings from pylint.
Signed-off-by: NMarian Krcmarik <mkrcmari@redhat.com>

Signed-off-by: NMarian Krcmarik <mkrcmari@redhat.com>

Signed-off-by: NYanbing Du <ydu@redhat.com>

  * Wrong using 'elif' instead of 'if', then it will never judge if this target using
    the emulated image name.
  * Delete the duplicated judgment when cleanup.
Signed-off-by: NYanbing Du <ydu@redhat.com>

PEP8 mass auto fix

Catching up with some problems found w.r.t. coding style
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

qemu.tests.virtio_console: Update test_hotplug_virtio_pci

If the shutdown is not successful, destroy the VM
gracefully, so It does not stay alive.
Signed-off-by: NMarian Krcmarik <mkrcmari@redhat.com>