1.Add umount and wipefs steps before formatting in case the hard drive
contains a mounted filesystem.
2.Remove 'format_disk' I/O sub-testing for serial/removable/io_size
options testing.
Signed-off-by: Nybduan <yduan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NHaotong Chen <hachen@redhat.com>

Found by inspektor 0.4.5.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Found and fixed by inspektor 0.4.5.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

The guest will auto mount usb disk after reboot when the usb disk
was made file system. Since removable usb disk will not available,
unmount the usb disk before running subsequent tests.
Signed-off-by: NHaotong Chen <hachen@redhat.com>

The usb_storage tests report couple of errors, says:
* missing blk_extra_params_stg
* Expected: '520fa169-32f8-431f-9f1e-70992671d2e5', Actual: 'TARGET_DISK0'
('520fa169-..' is generated dynamically, 'TARGET_..' is my blk_extra_params_stg)
* Can not get drive path by id 'NO_EQUAL_STRING
* Can not get drive path by id 'EMPTY_STRING'

This patch fixes above issues.
Signed-off-by: NLin Ma <lma@suse.com>

'virttest.aexpect' was refactored and turned to its own project.
Let's update all the references to simply 'aexpect'
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

In different version of qemu, the output of removable
in qtree are not same, so update check method to
make a transfer for on/off, yes/no, true/false.
Signed-off-by: NShuping Cui <scui@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Use '\s' to match any whitespace character, like: [ \n\r].
Signed-off-by: NShuping Cui <scui@redhat.com>

There's no need to have the name of the "run_<name>" method (main
test entry point) depend on the test name. So, for simplicity sake,
let's just name the test entry point "run".

I have decided to not fallback gracefully to the previous naming
convention as I believe this can lead to confusion in the future.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Make virt-test to have a docstring style mostly compliant with
the sphinx's [1] format, reStructured text. This means that
we have to trade all '@' tags to be ':', mostly.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With the help of the PEP8 script, a semi-automated clean
of the code base was made, and effectively changing some
of the coding style rules of our code base:

 * No more 2 lines spacing among functions
 * No more combined module imports

In the end, it was going to be too difficult to take
into consideration E501 (line length > 80) errors and
W601 (.has_key() is deprecated), so these were ignored,
at least for now.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This `usb_storage` script would fail when getting
usb disk name in guest, since the guest doesn't
fully boot up.
Thus it needs some more time to wait for guest
initiate usb disk after boot.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

Some guests (eg, RHEL4.9) can't mount the usb storage device which
path contains quotation mark, thus this patch make test script
try to get the real path before using it.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>
Acked-by: NSuqin Huang <shuang@redhat.com>

This patch benefits from the better error message when key is missing
in config params. Instead of custom handling of missing param it
uses params[] directly.

I modified those params, where I was 100% certain that they are
required and doesn't have default value:
 * val = params.get(..) followed by if not val: raise...
 * int(params.get(...))
 * params.get(...).split()
 * commands which require string (eg. session.cmd(params.get(...)))

I didn't test all the tests before and after in order to verify
possible typos but I used pylint before and after, watching for
new errors (code rate before and after).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Since this usb.py script is used to test
usb-storage device, rename it to usb_storage.py.
Also, as usb_storage.cfg is already consolidated
in usb.cfg, delete it.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

A frequent request we've got from users is that the name
'kvm' makes assumptions that are not true for a lot of
the use cases of the test suite. Then let's rename
the subtest 'kvm' to 'qemu', making it more accurate.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>