Use a more generic method, that will work in older
python implementations.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Enable AHCI booting and sync Win2008-32 unattended file format

Pylint fixes

Here, the author called out to exit(), which is not
the intended effect. The actual exit condition is
`return`.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

For now, try/except/finally blocks shouldn't be used.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Rather than using '0b1', a representation not valid in
python 2.4, use 1, which should go for the same effect.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

 guest-os: add RHEL5.10 config

Periodically I was getting a failure when the first of the sequence
of virsh_edit's are run in one my long runs using the "--tests virsh"
option. The failing test is/was 'virsh.edit.normal_test.id_option'.
When run alone using "--tests virsh.edit" - the error didn't occur.
After looking at the test for a while I noticed that part of the
processing is to shutdown the guest prior to the last modify_vcpu()
call. Doing that means the 'id' is no longer valid - thus a failure
could occur that wasn't expected. Even after changing that I got a few
more failures and after an attempt to change the sleep() time from 1 to 2
I was directed to the remote.handle_prompts() call which should work.

Signed-off-by: NShuping Cui <scui@redhat.com>

virsh_migrate_stress: SKIP test if src and dest URI not defined

As we moved the check down the stack (given that we might
want to simply run run_pylint.py instead of the full blown
check_patch.py script).
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

tools/run_pylint.py: Handle unforseen exceptions running pylint

In some testing scenarios, such as daily pylint checking
on py 2.4, we noticed the attempt to inspect some pygtk
code generated problems such as:

RuntimeError: could not open display

Making the rest of the checks to be aborted. Let's handle
the exceptions and print the messages as we should.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Issue #1014.  Skip this test if we haven't redefined the source and
destination URI's.

qemu.tests.cpuinfo_query: Fix #1198

The test is wired up to check RHEL machine types, that
will not be present on anything that is not strictly
RHEL 6.4, so restrict the test to those hosts.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

run: Introduce new options, change virt-test default behavior

In order to save time in virt-test:

1) The JeOS image is uncompressed once and reused
   every test, unless it is explicitly asked with
   --restore-image

2) After a test is done, the VMs won't be shut down
   unless it is explicitly asked with --restart-vm

3) After a test is done, the pristine image won't
   be restored, unless it is explicitly asked with
   --restore-image-between-tests

All of those behaviors, while might bring speed ups
to the test process, they are not safe. As users
frequently don't have the visibility of that when
using the test suite, we found out that it's in the
best interest of users and developers that the
defaults are changed to safer options.

With this, the options mentioned above changed to

--keep-guest-running
--keep-image
--keep-image-between-tests

The wording 'guest' was chose over 'vm' due to the
fact we already have --guest-os. So, mostly an attempt
to keep consistency.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

run: Add --console-level option, fix issue #179

With this we implement (admittedly very very late)
the functionality asked in issue #179. This introduces
a new --console-level option, that will allow people
using --verbose to adjust the level of the messages
printed to the console.

CC: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Spice tests updates/extensions (v3) (was #1076)

libvirt-tests: Fix some emulatorpin errors

libvirt: Add virsh net-info command test

run: Add --no-cleanup option

For debugging purposes, not cleaning up env files,
test tmp files and aexpect tmp files might be desirable.
So add this option to our test runner.

CC: Lukas Doktor <ldoktor@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

JeOS 19 ks: Fill up disk image so empty space can be removed

Add a last step post install that will make the JeOS
image to fill all 10GB of disk, so that we can easily
create an image with no empty space by using qemu-img

qemu-img convert -O qcow2 jeos-19-x86_64.qcow2 jeos-19-x86_64-output.qcow2
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

JeOS 19: Add qemu-guest-agent

It was argued that the agent is closely related to
virtualization testing, and it is small enough to
justify inclusion.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

virsh_snapshot_edit: Resolve test errors

virsh_snapshot_create_as: Adjustments from review

virsh.schedinfo_qemu_posix: update the way we get the cgroup path

Make the test runner more stable with 'safe' options

staging.utils_cgroup: change the regexp for finding correct cgroup path

Add test for virsh find-storage-pool-sources-as and bug fix

Mq change qnum

On an attempt to eliminate sources of disk corruption
and errors, delete the dst file if the src file is
avaliable.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Use SIGKILL instead of SIGTERM (the default for pkill)
when terminating the background process. This way we're
less likely to run into a situation where killing the
tcpdump command times out.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Sometimes, post migration run, we can run into a condition
where tcpdump or the VM hangs at migration cleanup stage.
After analyzing test logs, including VM logs, there's nothing
that points out to any guest OS crash or similar condition.

With that in mind, it is admissible to be more lenient
when trying to kill the migration background command, and
if a timeout happens when trying to kill it, be safe and
try to shut down the vm gracefully.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>