1.Add umount and wipefs steps before formatting in case the hard drive
contains a mounted filesystem.
2.Remove 'format_disk' I/O sub-testing for serial/removable/io_size
options testing.
Signed-off-by: Nybduan <yduan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

The usb_storage tests report couple of errors, says:
* missing blk_extra_params_stg
* Expected: '520fa169-32f8-431f-9f1e-70992671d2e5', Actual: 'TARGET_DISK0'
('520fa169-..' is generated dynamically, 'TARGET_..' is my blk_extra_params_stg)
* Can not get drive path by id 'NO_EQUAL_STRING
* Can not get drive path by id 'EMPTY_STRING'

This patch fixes above issues.
Signed-off-by: NLin Ma <lma@suse.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

qemu.test: format_disk, block_resize
generic.test: lvm, dd_test

These above cases assumed the target drive path is "/dev/*db". However,
it would not be true in rhel ppc guest with using virtio-blk interface.
The fix will make these cases to get the target drive by serial or wwn.
Signed-off-by: NXu Han <xuhan@redhat.com>

'virttest.aexpect' was refactored and turned to its own project.
Let's update all the references to simply 'aexpect'
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

1. Improve the debug log.
2. Update the single character.
Signed-off-by: NCong Li <coli@redhat.com>

Sometimes the output include some specific control character, like: ^H,
so update check content method.
Signed-off-by: NShuping Cui <scui@redhat.com>

There's no need to have the name of the "run_<name>" method (main
test entry point) depend on the test name. So, for simplicity sake,
let's just name the test entry point "run".

I have decided to not fallback gracefully to the previous naming
convention as I believe this can lead to confusion in the future.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Make virt-test to have a docstring style mostly compliant with
the sphinx's [1] format, reStructured text. This means that
we have to trade all '@' tags to be ':', mostly.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With the help of the PEP8 script, a semi-automated clean
of the code base was made, and effectively changing some
of the coding style rules of our code base:

 * No more 2 lines spacing among functions
 * No more combined module imports

In the end, it was going to be too difficult to take
into consideration E501 (line length > 80) errors and
W601 (.has_key() is deprecated), so these were ignored,
at least for now.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Using the program codespell

https://github.com/lucasdemarchi/codespell

We found a number of spelling mistakes, that could be
found and fixed. The result of the automated script
was double checked, of course.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This patch makes the read/write cmd fully configurable.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

This test script just leaves the disk(s) in mounted
status after read operation, this patch adds 2 more
steps after read: umount the disk and check dmesg
output.

CC: Xu Tian <xutian@redhat.com>
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

Make file content configurable, after this changes this case can be used
as subtest for other tests(eg, iometer_windows, iozone_windows) and no
impact original format_disk tests steps;
Signed-off-by: NXu Tian <xutian@redhat.com>

This test will simply create a file system on disk, mount it and write
a file with some content to the disk. Check whether the write could be
succeeded.
Signed-off-by: Nsshang <sshang@redhat.com>

Checking guest os type with 'guest_name' parameter may not
always work for all guests, and not supported by upstream.
Thus update all these places to using 'os_type'.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

In the format disk test, the status of the harddisk is different in different
env in Windows guest. Should check if the disk plused is offline and writeable.
Signed-off-by: NYiqiao Pu <ypu@redhat.com>

This patch try to fix all the tab and trailing space problems.
Signed-off-by: NJason Wang <jasowang@redhat.com>

Make command timeout of format_disk.py scirpt longer and configurable
Signed-off-by: NFeng Yang <fyang@redhat.com>