specify parameter name img_fmt when calling function _get_image_filename
Signed-off-by: NXueqiang Wei <xuwei@redhat.com>

Signed-off-by: NYongxue Hong <yhong@redhat.com>

Move the sleep function after getting pid,
or 'qemu-img rebase' can not recieve the signal before exit.
Signed-off-by: NTingting Mao <timao@redhat.com>

Converting the size of the image to the unit byte then check
whether it matches with the output of 'qemu-img info'.
Signed-off-by: NTingting Mao <timao@redhat.com>

In Python 2, the str type was used for two different kinds of values:
text and bytes, whereas in Python 3, these are separate and incompatible
types.
e.g.

TypeError: a bytes-like object is required, not 'str'
>>> 'abc' in b'abcd'
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
>>> type(b'abcd')
<class 'bytes'>

More background on this can be seen in
  https://www.redhat.com/archives/avocado-devel/2018-April/msg00002.html

This patch helps to decode the binary data into a text string.
Signed-off-by: NPing Li <pingl@redhat.com>

Data type of exit_status is int, which should not be decoded.
Only decode text output.
Signed-off-by: NHaotong Chen <hachen@redhat.com>

using os.kill to send `SIGUSR1` to qemu-img process
Signed-off-by: NHaotong Chen <hachen@redhat.com>

Signed-off-by: NHaotong Chen <hachen@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

  | get_command_output          -> cmd_output
  | get_command_status          -> cmd_status
  | get_command_status_output   -> cmd_status_output
Signed-off-by: NXu Han <xuhan@redhat.com>

Adding `shell=True` to the required places.
Signed-off-by: NXu Han <xuhan@redhat.com>

Signed-off-by: NXu Han <xuhan@redhat.com>

Add cases for cache mode and show progress

Signed-off-by: Ping Li pingl@redhat.com

1. Add cases for cluster size/sparse size/cache mode/show progress
2. Add function verify_info() to check result of convert operation

Signed-off-by: Ping Li pingl@redhat.com

Add cases for upgrading and downgrading qcow2 version of image

Signed-off-by: Ping Li pingl@redhat.com

For example,
'session.sendline(params.get("shutdown_command"))' was discarded,
"Shutdown command is sent, ..." is inapproprivate.
Signed-off-by: NWei Jiangang <weijg.fnst@cn.fujitsu.com>

vm paused after send shutdown command, so it will
caused check vm shutdown error in below.
Signed-off-by: NXu Tian <xutian@redhat.com>

Clean up imports across the board in tp-qemu. The criteria
followed was:

1) Remove unnecessary imports
2) Turn multi imports from a single entry point to one
   import per line. This increases both patch and
   source code readability.
3) Separate blocks of imports with a line:
   * Python standard library imports
   * Autotest imports
   * virttest imports
   * Internal tp-qemu imports
4) Remove try/except blocks refering autotest libs and
   stick with the virttest.staging copy

This paves the way for the future removal of autotest
references, replacing those references with avocado ones.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NChengyou Liu <cheliu@redhat.com>

Signed-off-by: NFeng Yang <fyang@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

1. Correct the file name.
   The original image is what is generally called the backing file,
   whereas the new image you created is an overlay.

2. Remove the step which boot up the backing file before commit.
   It is not allowed to boot up the backing file before commit.
   If you have boot up, you have written to the backing file,
   which is likely to destory data on the overlays.
Signed-off-by: NCong Li <coli@redhat.com>

A bunch of PEP8 non compliances and small errors that
were caught by inspekt.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

if preallocated == metadata and cluster_size is not None, will get command like:
qemu-img create -f qcow2 -o prellaction=metadata -o cluster_size=xxx,
correct command should be: qemu-img create -f qcow2 -o prellaction=metadata,cluster_size=xxx
Signed-off-by: NShuping Cui <scui@redhat.com>

Preallocation mode (allowed values: off, metadata),
is not "no" or "yes".
Signed-off-by: NShuping Cui <scui@redhat.com>

There's no need to have the name of the "run_<name>" method (main
test entry point) depend on the test name. So, for simplicity sake,
let's just name the test entry point "run".

I have decided to not fallback gracefully to the previous naming
convention as I believe this can lead to confusion in the future.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Make virt-test to have a docstring style mostly compliant with
the sphinx's [1] format, reStructured text. This means that
we have to trade all '@' tags to be ':', mostly.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With the help of the PEP8 script, a semi-automated clean
of the code base was made, and effectively changing some
of the coding style rules of our code base:

 * No more 2 lines spacing among functions
 * No more combined module imports

In the end, it was going to be too difficult to take
into consideration E501 (line length > 80) errors and
W601 (.has_key() is deprecated), so these were ignored,
at least for now.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Using the program codespell

https://github.com/lucasdemarchi/codespell

We found a number of spelling mistakes, that could be
found and fixed. The result of the automated script
was double checked, of course.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

This reverts commit c080994ddf01914b0bb0162cbe97df9fef75adf3.

In some places of our code, we're calling utils.system_output
with a parameter verbose, introduced in autotest 0.15. Therefore,
for people using the Fedora/RHEL shipped RPMs, a bug will
happen since the API on their RPMs doesn't know about the verbose
param.

Therefore, remove such calls and get the equivalent construction
using the utils.run API, that does support the parameter.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

qemu-img rebase function used to changes backing_file and backing_file
format for an image file;
In this case, we create snapshots "base->sn1->sn2", then rebase sn2's backing_file
to base, then bootup with sn2 and check sn2's backing_file is base;
Signed-off-by: NXu Tian <xutian@redhat.com>

Signed-off-by: NFeng Yang <fyang@redhat.com>
KVM-Test: Boot/shutdown rebased image
Signed-off-by: NSuqin Huang <shuang@redhat.com>
KVM Test: check the image after image creation.
KVM test: qemu_img: Pre-allocated metadata qcow2 format support
KVM Test: Raw device support for qemu_img test
KVM test: qemu_img add the qcow2 over LVM checking
Signed-off-by: NJason Wang <jasowang@redhat.com>
KVM Test: Add cluster_size_2048 test case.
Bug fix and add error.context in qemu_img.py script
Fix bug that guest start twice.
Signed-off-by: NFeng Yang <fyang@redhat.com>
KVM-Test: qemu_img.py: update case with new autotest api
virt: Update 'guest_name' to 'os_type' in all scripts
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>
KVM-test: Update qemu_img commit test command to support Windows
Signed-off-by: NYiqiao Pu <ypu@redhat.com>

This patch benefits from the better error message when key is missing
in config params. Instead of custom handling of missing param it
uses params[] directly.

I modified those params, where I was 100% certain that they are
required and doesn't have default value:
 * val = params.get(..) followed by if not val: raise...
 * int(params.get(...))
 * params.get(...).split()
 * commands which require string (eg. session.cmd(params.get(...)))

I didn't test all the tests before and after in order to verify
possible typos but I used pylint before and after, watching for
new errors (code rate before and after).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

A frequent request we've got from users is that the name
'kvm' makes assumptions that are not true for a lot of
the use cases of the test suite. Then let's rename
the subtest 'kvm' to 'qemu', making it more accurate.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>