1. 08 12月, 2007 9 次提交
  2. 07 12月, 2007 3 次提交
  3. 06 12月, 2007 24 次提交
  4. 05 12月, 2007 4 次提交
    • A
      [LRO]: fix lro_gen_skb() alignment · 621544eb
      Andrew Gallatin 提交于
      Add a field to the lro_mgr struct so that drivers can specify how much
      padding is required to align layer 3 headers when a packet is copied
      into a freshly allocated skb by inet_lro.c:lro_gen_skb().  Without
      padding, skbs generated by LRO will cause alignment warnings on
      architectures which require strict alignment (seen on sparc64).
      
      Myri10GE is updated to use this field.
      Signed-off-by: NAndrew Gallatin <gallatin@myri.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      621544eb
    • A
      PHY: Add the phy_device_release device method. · 6f4a7f41
      Anton Vorontsov 提交于
      Lately I've got this nice badness on mdio bus removal:
      
      Device 'e0103120:06' does not have a release() function, it is broken and must be fixed.
      ------------[ cut here ]------------
      Badness at drivers/base/core.c:107
      NIP: c015c1a8 LR: c015c1a8 CTR: c0157488
      REGS: c34bdcf0 TRAP: 0700   Not tainted  (2.6.23-rc5-g9ebadfbb-dirty)
      MSR: 00029032 <EE,ME,IR,DR>  CR: 24088422  XER: 00000000
      ...
      [c34bdda0] [c015c1a8] device_release+0x78/0x80 (unreliable)
      [c34bddb0] [c01354cc] kobject_cleanup+0x80/0xbc
      [c34bddd0] [c01365f0] kref_put+0x54/0x6c
      [c34bdde0] [c013543c] kobject_put+0x24/0x34
      [c34bddf0] [c015c384] put_device+0x1c/0x2c
      [c34bde00] [c0180e84] mdiobus_unregister+0x2c/0x58
      ...
      
      Though actually there is nothing broken, it just device
      subsystem core expects another "pattern" of resource managment.
      
      This patch implement phy device's release function, thus
      we're getting rid of this badness.
      
      Also small hidden bug fixed, hope none other introduced. ;-)
      Signed-off-by: NAnton Vorontsov <avorontsov@ru.mvista.com>
      Acked-by: NAndy Fleming <afleming@freescale.com>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      6f4a7f41
    • G
      gianfar: fix compile warning · f9663aea
      Grant Likely 提交于
      Eliminate an uninitialized variable warning.  The code is correct, but
      a pointer to the automatic variable 'addr' is passed to dma_alloc_coherent.
      Since addr has never been initialized, and the compiler doesn't know
      what dma_alloc_coherent will do with it, it complains.
      Signed-off-by: NGrant Likely <grant.likely@secretlab.ca>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      f9663aea
    • O
      pasemi_mac: Fix reuse of free'd skb · 4352d826
      Olof Johansson 提交于
      Turns out we're freeing the skb when we detect CRC error, but we're
      not clearing out info->skb. We could either clear it and have the stack
      reallocate it, or just leave it and the rx ring refill code will reuse
      the one that was allocated.
      
      Reusing a freed skb obviously caused some nasty crashes of various kind,
      as reported by Brent Baude and David Woodhouse.
      Signed-off-by: NOlof Johansson <olof@lixom.net>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      4352d826