1. 02 4月, 2013 2 次提交
  2. 01 4月, 2013 14 次提交
  3. 30 3月, 2013 3 次提交
  4. 29 3月, 2013 2 次提交
    • N
      target: Fix RESERVATION_CONFLICT status regression for iscsi-target special case · f85eda8d
      Nicholas Bellinger 提交于
      This patch fixes a regression introduced in v3.8-rc1 code where a failed
      target_check_reservation() check in target_setup_cmd_from_cdb() was causing
      an incorrect SAM_STAT_GOOD status to be returned during a WRITE operation
      performed by an unregistered / unreserved iscsi initiator port.
      
      This regression is only effecting iscsi-target due to a special case check
      for TCM_RESERVATION_CONFLICT within iscsi_target_erl1.c:iscsit_execute_cmd(),
      and was still correctly disallowing WRITE commands from backend submission
      for unregistered / unreserved initiator ports, while returning the incorrect
      SAM_STAT_GOOD status due to the missing SAM_STAT_RESERVATION_CONFLICT
      assignment.
      
      This regression was first introduced with:
      
      commit de103c93
      Author: Christoph Hellwig <hch@lst.de>
      Date:   Tue Nov 6 12:24:09 2012 -0800
      
          target: pass sense_reason as a return value
      
      Go ahead and re-add the missing SAM_STAT_RESERVATION_CONFLICT assignment
      during a target_check_reservation() failure, so that iscsi-target code
      sends the correct SCSI status.
      
      All other fabrics using target_submit_cmd_*() with a RESERVATION_CONFLICT
      call to transport_generic_request_failure() are not effected by this bug.
      Reported-by: NJeff Leung <jleung@curriegrad2004.ca>
      Cc: Christoph Hellwig <hch@lst.de>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: NNicholas Bellinger <nab@linux-iscsi.org>
      f85eda8d
    • N
      tcm_vhost: Avoid VIRTIO_RING_F_EVENT_IDX feature bit · 5dade710
      Nicholas Bellinger 提交于
      This patch adds a VHOST_SCSI_FEATURES mask minus VIRTIO_RING_F_EVENT_IDX
      so that vhost-scsi-pci userspace will strip this feature bit once
      GET_FEATURES reports it as being unsupported on the host.
      
      This is to avoid a bug where ->handle_kicks() are missed when EVENT_IDX
      is enabled by default in userspace code.
      
      (mst: Rename to VHOST_SCSI_FEATURES + add comment)
      Acked-by: NMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: NAsias He <asias@redhat.com>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: NNicholas Bellinger <nab@linux-iscsi.org>
      5dade710
  5. 28 3月, 2013 4 次提交
  6. 27 3月, 2013 12 次提交
  7. 26 3月, 2013 3 次提交
    • W
      x86, io_apic: remove duplicated include from irq_remapping.c · 4fdc7824
      Wei Yongjun 提交于
      Remove duplicated include.
      Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
      Signed-off-by: NJoerg Roedel <joro@8bytes.org>
      4fdc7824
    • H
      [media] [REGRESSION] bt8xx: Fix too large height in cropcap · 35ccecef
      Hans de Goede 提交于
      Since commit a1fd2877:
      "[media] bttv-driver: fix two warnings"
      cropcap.defrect.height and cropcap.bounds.height for the PAL entry are 32
      resp 30 pixels too large, if a userspace app (ie xawtv) actually tries to use
      the full advertised height, the resulting image is broken in ways only a
      screenshot can describe.
      The cause of this is the fix for this warning:
      drivers/media/pci/bt8xx/bttv-driver.c:308:3: warning: initialized field overwritten [-Woverride-init]
      In this chunk of the commit:
      @@ -301,11 +301,10 @@ const struct bttv_tvnorm bttv_tvnorms[] = {
                              /* totalwidth */ 1135,
                              /* sqwidth */ 944,
                              /* vdelay */ 0x20,
      -                       /* sheight */ 576,
      -                       /* videostart0 */ 23)
                      /* bt878 (and bt848?) can capture another
                         line below active video. */
      -               .cropcap.bounds.height = (576 + 2) + 0x20 - 2,
      +                       /* sheight */ (576 + 2) + 0x20 - 2,
      +                       /* videostart0 */ 23)
              },{
                      .v4l2_id        = V4L2_STD_NTSC_M | V4L2_STD_NTSC_M_KR,
                      .name           = "NTSC",
      Which replaces the overriding of cropcap.bounds.height initialization outside
      of the CROPCAP macro (which also initializes it), with passing a
      different sheight value to the CROPCAP macro.
      There are 2 problems with this warning fix:
      1) The sheight value is used twice in the CROPCAP macro, and the old code
         only changed one resulting value.
      2) The old code increased the .cropcap.bounds.height value (and did not
         touch the .cropcap.defrect.height value at all) by 2, where as the fixed
         code increases it by 32, as the fixed code passes (576 + 2) + 0x20 - 2
         to the CROPCAP macro, but the + 0x20 - 2 is already done by the macro so
         now is done twice for .cropcap.bounds.height, and also is applied to
         .cropcap.defrect.height where it should not be applied at all.
      This patch fixes this by adding an extraheight parameter to the CROPCAP entry
      and using it for the PAL entry.
      
      Cc: stable@kernel.org	# For Kernel 3.8
      Signed-off-by: NHans de Goede <hdegoede@redhat.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      35ccecef
    • J
      igb: fix PHC stopping on max freq · 75517d92
      Jiri Benc 提交于
      For 82576 MAC type, max_adj is reported as 1000000000 ppb. However, if
      this value is passed to igb_ptp_adjfreq_82576, incvalue overflows out of
      INCVALUE_82576_MASK, resulting in setting of zero TIMINCA.incvalue, stopping
      the PHC (instead of going at twice the nominal speed).
      
      Fix the advertised max_adj value to the largest value hardware can handle.
      As there is no min_adj value available (-max_adj is used instead), this will
      also prevent stopping the clock intentionally. It's probably not a big deal,
      other igb MAC types don't support stopping the clock, either.
      Signed-off-by: NJiri Benc <jbenc@redhat.com>
      Acked-by: NMatthew Vick <matthew.vick@intel.com>
      Tested-by: NAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      75517d92