1. 07 1月, 2014 11 次提交
    • S
      bridge: use DEVICE_ATTR_xx macros · fbf2671b
      sfeldma@cumulusnetworks.com 提交于
      Use DEVICE_ATTR_RO/RW macros to simplify bridge sysfs attribute definitions.
      Signed-off-by: NScott Feldman <sfeldma@cumulusnetworks.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      fbf2671b
    • E
      vxlan: keep original skb ownership · 8f646c92
      Eric Dumazet 提交于
      Sathya Perla posted a patch trying to address following problem :
      
      <quote>
       The vxlan driver sets itself as the socket owner for all the TX flows
       it encapsulates (using vxlan_set_owner()) and assigns it's own skb
       destructor. This causes all tunneled traffic to land up on only one TXQ
       as all encapsulated skbs refer to the vxlan socket and not the original
       socket.  Also, the vxlan skb destructor breaks some functionality for
       tunneled traffic like wmem accounting and as TCP small queues and
       FQ/pacing packet scheduler.
      </quote>
      
      I reworked Sathya patch and added some explanations.
      
      vxlan_xmit() can avoid one skb_clone()/dev_kfree_skb() pair
      and gain better drop monitor accuracy, by calling kfree_skb() when
      appropriate.
      
      The UDP socket used by vxlan to perform encapsulation of xmit packets
      do not need to be alive while packets leave vxlan code. Its better
      to keep original socket ownership to get proper feedback from qdisc and
      NIC layers.
      
      We use skb->sk to
      
      A) control amount of bytes/packets queued on behalf of a socket, but
      prior vxlan code did the skb->sk transfert without any limit/control
      on vxlan socket sk_sndbuf.
      
      B) security purposes (as selinux) or netfilter uses, and I do not think
      anything is prepared to handle vxlan stacked case in this area.
      
      By not changing ownership, vxlan tunnels behave like other tunnels.
      As Stephen mentioned, we might do the same change in L2TP.
      Reported-by: NSathya Perla <sathya.perla@emulex.com>
      Signed-off-by: NEric Dumazet <edumazet@google.com>
      Cc: Stephen Hemminger <stephen@networkplumber.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      8f646c92
    • E
      tcp: out_of_order_queue do not use its lock · 996b175e
      Eric Dumazet 提交于
      TCP out_of_order_queue lock is not used, as queue manipulation
      happens with socket lock held and we therefore use the lockless
      skb queue routines (as __skb_queue_head())
      
      We can use __skb_queue_head_init() instead of skb_queue_head_init()
      to make this more consistent.
      Signed-off-by: NEric Dumazet <edumazet@google.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      996b175e
    • V
      bonding: fix kstrtou8() return value verification in num_peer_notif · 0b23810d
      Veaceslav Falico 提交于
      It returns 0 in case of success, !0 error otherwise. Fix the improper error
      verification.
      
      Fixes: 2c9839c1 ("bonding: add num_grat_arp attribute netlink support")
      CC: sfeldma@cumulusnetworks.com
      CC: Jay Vosburgh <fubar@us.ibm.com>
      CC: Andy Gospodarek <andy@greyhouse.net>
      Signed-off-by: NVeaceslav Falico <vfalico@redhat.com>
      Acked-by: NScott Feldman <sfeldma@cumulusnetworks.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      0b23810d
    • H
      r8152: replace the return value of rtl_ops_init · 31ca1dec
      hayeswang 提交于
      Replace the boolean value with the error code for the return value
      of the rtl_ops_init().
      Signed-off-by: NHayes Wang <hayeswang@realtek.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      31ca1dec
    • H
      r8152: move the actions of saving the information of the device · e3ad412a
      hayeswang 提交于
      Some information of the device may be used in other functions. Move
      the relative code to make sure it would be initialzed correctly
      before using it.
      Signed-off-by: NHayes Wang <hayeswang@realtek.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      e3ad412a
    • H
      r8152: replace some tabs with spaces · 45f4a19f
      hayeswang 提交于
      Replace the tabs of the variables declaration with the spaces.
      Signed-off-by: NHayes Wang <hayeswang@realtek.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      45f4a19f
    • V
      net: pkt_sched: PIE AQM scheme · d4b36210
      Vijay Subramanian 提交于
      Proportional Integral controller Enhanced (PIE) is a scheduler to address the
      bufferbloat problem.
      
      >From the IETF draft below:
      " Bufferbloat is a phenomenon where excess buffers in the network cause high
      latency and jitter. As more and more interactive applications (e.g. voice over
      IP, real time video streaming and financial transactions) run in the Internet,
      high latency and jitter degrade application performance. There is a pressing
      need to design intelligent queue management schemes that can control latency and
      jitter; and hence provide desirable quality of service to users.
      
      We present here a lightweight design, PIE(Proportional Integral controller
      Enhanced) that can effectively control the average queueing latency to a target
      value. Simulation results, theoretical analysis and Linux testbed results have
      shown that PIE can ensure low latency and achieve high link utilization under
      various congestion situations. The design does not require per-packet
      timestamp, so it incurs very small overhead and is simple enough to implement
      in both hardware and software.  "
      
      Many thanks to Dave Taht for extensive feedback, reviews, testing and
      suggestions. Thanks also to Stephen Hemminger and Eric Dumazet for reviews and
      suggestions.  Naeem Khademi and Dave Taht independently contributed to ECN
      support.
      
      For more information, please see technical paper about PIE in the IEEE
      Conference on High Performance Switching and Routing 2013. A copy of the paper
      can be found at ftp://ftpeng.cisco.com/pie/.
      
      Please also refer to the IETF draft submission at
      http://tools.ietf.org/html/draft-pan-tsvwg-pie-00
      
      All relevant code, documents and test scripts and results can be found at
      ftp://ftpeng.cisco.com/pie/.
      
      For problems with the iproute2/tc or Linux kernel code, please contact Vijay
      Subramanian (vijaynsu@cisco.com or subramanian.vijay@gmail.com) Mythili Prabhu
      (mysuryan@cisco.com)
      Signed-off-by: NVijay Subramanian <subramanian.vijay@gmail.com>
      Signed-off-by: NMythili Prabhu <mysuryan@cisco.com>
      CC: Dave Taht <dave.taht@bufferbloat.net>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d4b36210
    • D
      netfilter: Fix build failure in nfnetlink_queue_core.c. · 83111e7f
      David S. Miller 提交于
      net/netfilter/nfnetlink_queue_core.c: In function 'nfqnl_put_sk_uidgid':
      net/netfilter/nfnetlink_queue_core.c:304:35: error: 'TCP_TIME_WAIT' undeclared (first use in this function)
      net/netfilter/nfnetlink_queue_core.c:304:35: note: each undeclared identifier is reported only once for each function it appears in
      make[3]: *** [net/netfilter/nfnetlink_queue_core.o] Error 1
      
      Just a missing include of net/tcp_states.h
      Reported-by: NEric Dumazet <eric.dumazet@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      83111e7f
    • D
      Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nftables · 9aa28f2b
      David S. Miller 提交于
      Pablo Neira Ayuso says: <pablo@netfilter.org>
      
      ====================
      nftables updates for net-next
      
      The following patchset contains nftables updates for your net-next tree,
      they are:
      
      * Add set operation to the meta expression by means of the select_ops()
        infrastructure, this allows us to set the packet mark among other things.
        From Arturo Borrero Gonzalez.
      
      * Fix wrong format in sscanf in nf_tables_set_alloc_name(), from Daniel
        Borkmann.
      
      * Add new queue expression to nf_tables. These comes with two previous patches
        to prepare this new feature, one to add mask in nf_tables_core to
        evaluate the queue verdict appropriately and another to refactor common
        code with xt_NFQUEUE, from Eric Leblond.
      
      * Do not hide nftables from Kconfig if nfnetlink is not enabled, also from
        Eric Leblond.
      
      * Add the reject expression to nf_tables, this adds the missing TCP RST
        support. It comes with an initial patch to refactor common code with
        xt_NFQUEUE, again from Eric Leblond.
      
      * Remove an unused variable assignment in nf_tables_dump_set(), from Michal
        Nazarewicz.
      
      * Remove the nft_meta_target code, now that Arturo added the set operation
        to the meta expression, from me.
      
      * Add help information for nf_tables to Kconfig, also from me.
      
      * Allow to dump all sets by specifying NFPROTO_UNSPEC, similar feature is
        available to other nf_tables objects, requested by Arturo, from me.
      
      * Expose the table usage counter, so we can know how many chains are using
        this table without dumping the list of chains, from Tomasz Bursztyka.
      ====================
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      9aa28f2b
    • D
      Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next · 6a8c4796
      David S. Miller 提交于
      Jeff Kirsher says:
      
      ====================
      Intel Wired LAN Driver Updates
      
      This series contains updates to i40e only.
      
      Majority of this series contains patches from Greg and Mitch to fix
      up or add functionality to the PF/VF driver interactions.  Notably,
      a fix for SR-IOV VF port VLAN which resolved the problem of port VLAN
      configurations not being persistent across VF driver loads and unloads
      and enable/disable of the feature.  Also do not enable the default port
      on the VEB, which is designed only to bridge the PF to an Open vSwitch
      or bridge.  Another fix to resolve a possible memory corruption
      condition where ARQ messages are written to random memory locations.
      Fix a problem where the 'ip link show' command would display stale
      link address information after the link address was set via the 'ip
      link set' command.
      
      Anjali provides several patches, one which saves information that can
      be used while cleaning the Tx ring and useful in detecting Tx hangs.
      Then provides a fixes to the admin queue shutdown function to ensure
      we are shutting down the queue in the shutdown path and ensure ASQ is
      alive before issuing the admin queue command.
      
      Shannon provides a fix for get/update vsi params where the incorrect
      struct was being used.
      ====================
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      6a8c4796
  2. 06 1月, 2014 20 次提交
  3. 05 1月, 2014 9 次提交