1. 25 3月, 2008 1 次提交
    • P
      [NEIGH]: Fix race between pneigh deletion and ipv6's ndisc_recv_ns (v3). · fa86d322
      Pavel Emelyanov 提交于
      Proxy neighbors do not have any reference counting, so any caller
      of pneigh_lookup (unless it's a netlink triggered add/del routine)
      should _not_ perform any actions on the found proxy entry. 
      
      There's one exception from this rule - the ipv6's ndisc_recv_ns() 
      uses found entry to check the flags for NTF_ROUTER.
      
      This creates a race between the ndisc and pneigh_delete - after 
      the pneigh is returned to the caller, the nd_tbl.lock is dropped 
      and the deleting procedure may proceed.
      
      One of the fixes would be to add a reference counting, but this
      problem exists for ndisc only. Besides such a patch would be too 
      big for -rc4.
      
      So I propose to introduce a __pneigh_lookup() which is supposed
      to be called with the lock held and use it in ndisc code to check
      the flags on alive pneigh entry.
      
      
      Changes from v2:
      As David noticed, Exported the __pneigh_lookup() to ipv6 module. 
      The checkpatch generates a warning on it, since the EXPORT_SYMBOL 
      does not follow the symbol itself, but in this file all the 
      exports come at the end, so I decided no to break this harmony.
      
      Changes from v1:
      Fixed comments from YOSHIFUJI - indentation of prototype in header
      and the pndisc_check_router() name - and a compilation fix, pointed
      by Daniel - the is_routed was (falsely) considered as uninitialized
      by gcc.
      Signed-off-by: NPavel Emelyanov <xemul@openvz.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      fa86d322
  2. 24 3月, 2008 2 次提交
  3. 23 3月, 2008 4 次提交
    • J
      [9P] net/9p/trans_fd.c: remove unused variable · 53a6201f
      Julia Lawall 提交于
      The variable cb is initialized but never used otherwise.
      
      The semantic patch that makes this change is as follows:
      (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @@
      type T;
      identifier i;
      constant C;
      @@
      
      (
      extern T i;
      |
      - T i;
        <+... when != i
      - i = C;
        ...+>
      )
      // </smpl>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      53a6201f
    • J
      [IPV6] net/ipv6/ndisc.c: remove unused variable · 421f099b
      Julia Lawall 提交于
      The variable hlen is initialized but never used otherwise.
      
      The semantic patch that makes this change is as follows:
      (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @@
      type T;
      identifier i;
      constant C;
      @@
      
      (
      extern T i;
      |
      - T i;
        <+... when != i
      - i = C;
        ...+>
      )
      // </smpl>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      421f099b
    • S
      [IPV4] fib_trie: fix warning from rcu_assign_poinger · 6440cc9e
      Stephen Hemminger 提交于
      This gets rid of a warning caused by the test in rcu_assign_pointer.
      I tried to fix rcu_assign_pointer, but that devolved into a long set
      of discussions about doing it right that came to no real solution.
      Since the test in rcu_assign_pointer for constant NULL would never
      succeed in fib_trie, just open code instead.
      Signed-off-by: NStephen Hemminger <shemminger@vyatta.com>
      Acked-by: NPaul E. McKenney <paulmck@linux.vnet.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      6440cc9e
    • H
      [TCP]: Let skbs grow over a page on fast peers · 69d15067
      Herbert Xu 提交于
      While testing the virtio-net driver on KVM with TSO I noticed
      that TSO performance with a 1500 MTU is significantly worse
      compared to the performance of non-TSO with a 16436 MTU.  The
      packet dump shows that most of the packets sent are smaller
      than a page.
      
      Looking at the code this actually is quite obvious as it always
      stop extending the packet if it's the first packet yet to be
      sent and if it's larger than the MSS.  Since each extension is
      bound by the page size, this means that (given a 1500 MTU) we're
      very unlikely to construct packets greater than a page, provided
      that the receiver and the path is fast enough so that packets can
      always be sent immediately.
      
      The fix is also quite obvious.  The push calls inside the loop
      is just an optimisation so that we don't end up doing all the
      sending at the end of the loop.  Therefore there is no specific
      reason why it has to do so at MSS boundaries.  For TSO, the
      most natural extension of this optimisation is to do the pushing
      once the skb exceeds the TSO size goal.
      
      This is what the patch does and testing with KVM shows that the
      TSO performance with a 1500 MTU easily surpasses that of a 16436
      MTU and indeed the packet sizes sent are generally larger than
      16436.
      
      I don't see any obvious downsides for slower peers or connections,
      but it would be prudent to test this extensively to ensure that
      those cases don't regress.
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      69d15067
  4. 22 3月, 2008 2 次提交
  5. 21 3月, 2008 7 次提交
  6. 18 3月, 2008 6 次提交
  7. 13 3月, 2008 2 次提交
  8. 12 3月, 2008 2 次提交
  9. 11 3月, 2008 8 次提交
  10. 08 3月, 2008 1 次提交
  11. 06 3月, 2008 5 次提交
    • D
      RxRPC: fix rxrpc_recvmsg()'s returning of msg_name · 1ff82fe0
      David Howells 提交于
      Fix rxrpc_recvmsg() to return msg_name correctly.  We shouldn't
      overwrite the *msg struct, but should rather write into msg->msg_name
      (there's a '&' unary operator that shouldn't be there).
      Signed-off-by: NDavid Howells <dhowells@redhat.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      1ff82fe0
    • T
      bluetooth: make bnep_sock_cleanup() return void · a4e2acf0
      Tobias Klauser 提交于
      bnep_sock_cleanup() always returns 0 and its return value isn't used
      anywhere in the code.
      Signed-off-by: NTobias Klauser <tklauser@distanz.ch>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a4e2acf0
    • T
      bluetooth: Make hci_sock_cleanup() return void · 04005dd9
      Tobias Klauser 提交于
      hci_sock_cleanup() always returns 0 and its return value isn't used
      anywhere in the code.
      
      Compile-tested with 'make allyesconfig && make net/bluetooth/bluetooth.ko'
      Signed-off-by: NTobias Klauser <tklauser@distanz.ch>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Acked-by: NMarcel Holtmann <marcel@holtmann.org>
      04005dd9
    • D
      bluetooth: hci_core: defer hci_unregister_sysfs() · 147e2d59
      Dave Young 提交于
      Alon Bar-Lev reports:
      
       Feb 16 23:41:33 alon1 usb 3-1: configuration #1 chosen from 1 choice
      Feb 16 23:41:33 alon1 BUG: unable to handle kernel NULL pointer  
      dereference at virtual address 00000008
      Feb 16 23:41:33 alon1 printing eip: c01b2db6 *pde = 00000000
      Feb 16 23:41:33 alon1 Oops: 0000 [#1] PREEMPT
      Feb 16 23:41:33 alon1 Modules linked in: ppp_deflate zlib_deflate  
      zlib_inflate bsd_comp ppp_async rfcomm l2cap hci_usb vmnet(P)  
      vmmon(P) tun radeon drm autofs4 ipv6 aes_generic crypto_algapi  
      ieee80211_crypt_ccmp nf_nat_irc nf_nat_ftp nf_conntrack_irc  
      nf_conntrack_ftp ipt_MASQUERADE iptable_nat nf_nat ipt_REJECT  
      xt_tcpudp ipt_LOG xt_limit xt_state nf_conntrack_ipv4 nf_conntrack  
      iptable_filter ip_tables x_tables snd_pcm_oss snd_mixer_oss  
      snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device  
      bluetooth ppp_generic slhc ioatdma dca cfq_iosched cpufreq_powersave  
      cpufreq_ondemand cpufreq_conservative acpi_cpufreq freq_table uinput  
      fan af_packet nls_cp1255 nls_iso8859_1 nls_utf8 nls_base pcmcia  
      snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm nsc_ircc snd_timer  
      ipw2200 thinkpad_acpi irda snd ehci_hcd yenta_socket uhci_hcd  
      psmouse ieee80211 soundcore intel_agp hwmon rsrc_nonstatic pcspkr  
      e1000 crc_ccitt snd_page_alloc i2c_i801 ieee80211_crypt pcmcia_core  
      agpgart thermal bat!
      tery nvram rtc sr_mod ac sg firmware_class button processor cdrom  
      unix usbcore evdev ext3 jbd ext2 mbcache loop ata_piix libata sd_mod  
      scsi_mod
      Feb 16 23:41:33 alon1
      Feb 16 23:41:33 alon1 Pid: 4, comm: events/0 Tainted: P         
      (2.6.24-gentoo-r2 #1)
      Feb 16 23:41:33 alon1 EIP: 0060:[<c01b2db6>] EFLAGS: 00010282 CPU: 0
      Feb 16 23:41:33 alon1 EIP is at sysfs_get_dentry+0x26/0x80
      Feb 16 23:41:33 alon1 EAX: 00000000 EBX: 00000000 ECX: 00000000 EDX:  
      f48a2210
      Feb 16 23:41:33 alon1 ESI: f72eb900 EDI: f4803ae0 EBP: f4803ae0 ESP:  
      f7c49efc
      Feb 16 23:41:33 alon1 hcid[7004]: HCI dev 0 registered
      Feb 16 23:41:33 alon1 DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068
      Feb 16 23:41:33 alon1 Process events/0 (pid: 4, ti=f7c48000  
      task=f7c3efc0 task.ti=f7c48000)
      Feb 16 23:41:33 alon1 Stack: f7cb6140 f4822668 f7e71e10 c01b304d  
      ffffffff ffffffff fffffffe c030ba9c
      Feb 16 23:41:33 alon1 f7cb6140 f4822668 f6da6720 f7cb6140 f4822668  
      f6da6720 c030ba8e c01ce20b
      Feb 16 23:41:33 alon1 f6e9dd00 c030ba8e f6da6720 f6e9dd00 f6e9dd00  
      00000000 f4822600 00000000
      Feb 16 23:41:33 alon1 Call Trace:
      Feb 16 23:41:33 alon1 [<c01b304d>] sysfs_move_dir+0x3d/0x1f0
      Feb 16 23:41:33 alon1 [<c01ce20b>] kobject_move+0x9b/0x120
      Feb 16 23:41:33 alon1 [<c0241711>] device_move+0x51/0x110
      Feb 16 23:41:33 alon1 [<f9aaed80>] del_conn+0x0/0x70 [bluetooth]
      Feb 16 23:41:33 alon1 [<f9aaed99>] del_conn+0x19/0x70 [bluetooth]
      Feb 16 23:41:33 alon1 [<c012c1a1>] run_workqueue+0x81/0x140
      Feb 16 23:41:33 alon1 [<c02c0c88>] schedule+0x168/0x2e0
      Feb 16 23:41:33 alon1 [<c012fc70>] autoremove_wake_function+0x0/0x50
      Feb 16 23:41:33 alon1 [<c012c9cb>] worker_thread+0x9b/0xf0
      Feb 16 23:41:33 alon1 [<c012fc70>] autoremove_wake_function+0x0/0x50
      Feb 16 23:41:33 alon1 [<c012c930>] worker_thread+0x0/0xf0
      Feb 16 23:41:33 alon1 [<c012f962>] kthread+0x42/0x70
      Feb 16 23:41:33 alon1 [<c012f920>] kthread+0x0/0x70
      Feb 16 23:41:33 alon1 [<c0104c2f>] kernel_thread_helper+0x7/0x18
      Feb 16 23:41:33 alon1 =======================
      Feb 16 23:41:33 alon1 Code: 26 00 00 00 00 57 89 c7 a1 50 1b 3a c0  
      56 53 8b 70 38 85 f6 74 08 8b 0e 85 c9 74 58 ff 06 8b 56 50 39 fa 74  
      47 89 fb eb 02 89 c3 <8b> 43 08 39 c2 75 f7 8b 46 08 83 c0 68 e8 98  
      e7 10 00 8b 43 10
      Feb 16 23:41:33 alon1 EIP: [<c01b2db6>] sysfs_get_dentry+0x26/0x80  
      SS:ESP 0068:f7c49efc
      Feb 16 23:41:33 alon1 ---[ end trace aae864e9592acc1d ]---
      
      Defer hci_unregister_sysfs because hci device could be destructed
      while hci conn devices still there.
      Signed-off-by: NDave Young <hidave.darkstar@gmail.com>
      Tested-by: NStefan Seyfried <seife@suse.de>
      Acked-by: NAlon Bar-Lev <alon.barlev@gmail.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Acked-by: NMarcel Holtmann <marcel@holtmann.org>
      147e2d59
    • N
      [SCTP]: Bring MAX_BURST socket option into ietf API extension compliance · 219b99a9
      Neil Horman 提交于
      Brings max_burst socket option set/get into line with the latest ietf
      socket extensions api draft, while maintaining backwards
      compatibility.
      Signed-off-by: NNeil Horman <nhorman@tuxdriver.com>
      Signed-off-by: NVlad Yasevich <vladislav.yasevich@hp.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      219b99a9