Some watchdog drivers initialize global spinlocks in module's init function
which is tolerable, but some do it in PCI probe function.  So, switch to
static initialization to fix theoretical bugs and, more importantly, stop
giving people bad examples.
Signed-off-by: NAlexey Dobriyan <adobriyan@sw.ru>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>

This patch fixes two returns in the TI Davinci and
PNX4008 in void functions.
Signed-off-by: NFlorian Fainelli <florian.fainelli@telecomint.eu>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

move watchdog tree from drivers/char/watchdog to drivers/watchdog.
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Given that the open routine already calls nonseekable_open(), remove
the redundant check for pwrite().
Signed-off-by: NRobert P. J. Day <rpjday@mindspring.com>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Many struct file_operations in the kernel can be "const".  Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data.  In addition it'll catch accidental writes at compile time to
these shared resources.
Signed-off-by: NArjan van de Ven <arjan@linux.intel.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

The return value of clk_get() should be checked by IS_ERR().
Signed-off-by: NAkinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: NBen Dooks <ben-linux@fluff.org>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

kbuild explicitly includes this at build time.
Signed-off-by: NDave Jones <davej@redhat.com>

Return ENOTTY instead of ENOIOCTLCMD in user-visible ioctl() results

The watchdog drivers used to return ENOIOCTLCMD for bad ioctl() commands.
ENOIOCTLCMD should not be visible by the user, so use ENOTTY instead.
Signed-off-by: NSamuel Tardieu <sam@rfc1149.net>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>
Acked-by: NAlan Cox <alan@redhat.com>
Signed-off-by: NAndrew Morton <akpm@osdl.org>

Added cpu_relax as suggested by Alan Cox.
Signed-off-by: NVitaly Wool <vitalywool@gmail.com>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Add io spinlocks to prevent possible race
conditions between start and stop operations
that are issued from different child processes
where the master process opened /dev/watchdog.
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Change remove code so that we first detach
the driver from userspace, then clean up the
clock and then clean up the memory we allocated.
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Change nowayout to: WATCHDOG_NOWAYOUT as defined
in include/linux/watchdog.h .
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>

Add watchdog support for Philips PNX4008 ARM board inlined.
Signed-off-by: NVitaly Wool <vitalywool@gmail.com>
Signed-off-by: NWim Van Sebroeck <wim@iguana.be>