1. 15 3月, 2013 3 次提交
  2. 14 3月, 2013 2 次提交
  3. 13 3月, 2013 5 次提交
  4. 12 3月, 2013 2 次提交
  5. 11 3月, 2013 1 次提交
  6. 09 3月, 2013 3 次提交
    • L
      rtlwifi: rtl8192cu: Fix schedule while atomic bug splat · 66489978
      Larry Finger 提交于
      When run at debug 3 or higher, rtl8192cu reports a BUG as follows:
      
      BUG: scheduling while atomic: kworker/u:0/5281/0x00000002
      INFO: lockdep is turned off.
      Modules linked in: rtl8192cu rtl8192c_common rtlwifi fuse af_packet bnep bluetooth b43 mac80211 cfg80211 ipv6 snd_hda_codec_conexant kvm_amd k
      vm snd_hda_intel snd_hda_codec bcma rng_core snd_pcm ssb mmc_core snd_seq snd_timer snd_seq_device snd i2c_nforce2 sr_mod pcmcia forcedeth i2c_core soundcore
       cdrom sg serio_raw k8temp hwmon joydev ac battery pcmcia_core snd_page_alloc video button wmi autofs4 ext4 mbcache jbd2 crc16 thermal processor scsi_dh_alua
       scsi_dh_hp_sw scsi_dh_rdac scsi_dh_emc scsi_dh ata_generic pata_acpi pata_amd [last unloaded: rtlwifi]
      Pid: 5281, comm: kworker/u:0 Tainted: G        W    3.8.0-wl+ #119
      Call Trace:
       [<ffffffff814531e7>] __schedule_bug+0x62/0x70
       [<ffffffff81459af0>] __schedule+0x730/0xa30
       [<ffffffff81326e49>] ? usb_hcd_link_urb_to_ep+0x19/0xa0
       [<ffffffff8145a0d4>] schedule+0x24/0x70
       [<ffffffff814575ec>] schedule_timeout+0x18c/0x2f0
       [<ffffffff81459ec0>] ? wait_for_common+0x40/0x180
       [<ffffffff8133f461>] ? ehci_urb_enqueue+0xf1/0xee0
       [<ffffffff810a579d>] ? trace_hardirqs_on+0xd/0x10
       [<ffffffff81459f65>] wait_for_common+0xe5/0x180
       [<ffffffff8107d1c0>] ? try_to_wake_up+0x2d0/0x2d0
       [<ffffffff8145a08e>] wait_for_completion_timeout+0xe/0x10
       [<ffffffff8132ab1c>] usb_start_wait_urb+0x8c/0x100
       [<ffffffff8132adf9>] usb_control_msg+0xd9/0x130
       [<ffffffffa057dd8d>] _usb_read_sync+0xcd/0x140 [rtlwifi]
       [<ffffffffa057de0e>] _usb_read32_sync+0xe/0x10 [rtlwifi]
       [<ffffffffa04b0555>] rtl92cu_update_hal_rate_table+0x1a5/0x1f0 [rtl8192cu]
      
      The cause is a synchronous read from routine rtl92cu_update_hal_rate_table().
      The resulting output is not critical, thus the debug statement is
      deleted.
      Reported-by: NJussi Kivilinna <jussi.kivilinna@mbnet.fi>
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Cc: Stable <stable@vger.kernel.org>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      66489978
    • B
      mwifiex: fix potential out-of-boundary access to ibss rate table · 5f0fabf8
      Bing Zhao 提交于
      smatch found this error:
      
      CHECK   drivers/net/wireless/mwifiex/join.c
        drivers/net/wireless/mwifiex/join.c:1121
        mwifiex_cmd_802_11_ad_hoc_join()
        error: testing array offset 'i' after use.
      
      Cc: <stable@vger.kernel.org> # 3.0+
      Signed-off-by: NBing Zhao <bzhao@marvell.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      5f0fabf8
    • N
      tg3: Update link_up flag for phylib devices · 84421b99
      Nithin Sujir 提交于
      Commit f4a46d1f introduced a bug where
      the ifconfig stats would remain 0 for phylib devices. This is due to
      tp->link_up flag never becoming true causing tg3_periodic_fetch_stats()
      to return.
      
      The link_up flag was being updated in tg3_test_and_report_link_chg()
      after setting up the phy. This function however, is not called for
      phylib devices since the driver does not do the phy setup.
      
      This patch moves the link_up flag update into the common
      tg3_link_report() function that gets called for phylib devices as well
      for non phylib devices when the link state changes.
      
      To avoid updating link_up twice, we replace tg3_carrier_...() calls that
      are followed by tg3_link_report(), with netif_carrier_...(). We can then
      remove the unused tg3_carrier_on() function.
      
      CC: <stable@vger.kernel.org>
      Reported-by: NOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
      Signed-off-by: NNithin Nayak Sujir <nsujir@broadcom.com>
      Signed-off-by: NMichael Chan <mchan@broadcom.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      84421b99
  7. 08 3月, 2013 14 次提交
  8. 07 3月, 2013 7 次提交
    • K
      e1000e: fix accessing to suspended device · e60b22c5
      Konstantin Khlebnikov 提交于
      This patch fixes some annoying messages like 'Error reading PHY register' and
      'Hardware Erorr' and saves several seconds on reboot.
      
      Cc: Bruce Allan <bruce.w.allan@intel.com>
      Signed-off-by: NKonstantin Khlebnikov <khlebnikov@openvz.org>
      Acked-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      Tested-by: NBorislav Petkov <bp@suse.de>
      Tested-by: NAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      e60b22c5
    • K
      e1000e: fix runtime power management transitions · 66148bab
      Konstantin Khlebnikov 提交于
      This patch removes redundant actions from driver and fixes its interaction
      with actions in pci-bus runtime power management code.
      
      It removes pci_save_state() from __e1000_shutdown() for normal adapters,
      PCI bus callbacks pci_pm_*() will do all this for us. Now __e1000_shutdown()
      switches to D3-state only quad-port adapters, because they needs quirk for
      clearing false-positive error from downsteam pci-e port.
      
      pci_save_state() now called after clearing bus-master bit, thus __e1000_resume()
      and e1000_io_slot_reset() must set it back after restoring configuration space.
      
      This patch set get_link_status before calling pm_runtime_put() in e1000_open()
      to allow e1000_idle() get real link status and schedule first runtime suspend.
      
      This patch also enables wakeup for device if management mode is enabled
      (like for WoL) as result pci_prepare_to_sleep() would setup wakeup without
      special actions like custom 'enable_wakeup' sign.
      
      Cc: Bruce Allan <bruce.w.allan@intel.com>
      Signed-off-by: NKonstantin Khlebnikov <khlebnikov@openvz.org>
      Acked-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      Tested-by: NBorislav Petkov <bp@suse.de>
      Tested-by: NAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      66148bab
    • K
      e1000e: fix pci-device enable-counter balance · 4e0855df
      Konstantin Khlebnikov 提交于
      This patch removes redundant and unbalanced pci_disable_device() from
      __e1000_shutdown(). pci_clear_master() is enough, device can go into
      suspended state with elevated enable_cnt.
      
      Bug was introduced in commit 23606cf5
      ("e1000e / PCI / PM: Add basic runtime PM support (rev. 4)") in v2.6.35
      
      Cc: Bruce Allan <bruce.w.allan@intel.com>
      CC: Stable <stable@kernel.org>
      Signed-off-by: NKonstantin Khlebnikov <khlebnikov@openvz.org>
      Acked-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      Tested-by: NBorislav Petkov <bp@suse.de>
      Tested-by: NAaron Brown <aaron.f.brown@intel.com>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      4e0855df
    • E
      tun: add a missing nf_reset() in tun_net_xmit() · f8af75f3
      Eric Dumazet 提交于
      Dave reported following crash :
      
      general protection fault: 0000 [#1] SMP
      CPU 2
      Pid: 25407, comm: qemu-kvm Not tainted 3.7.9-205.fc18.x86_64 #1 Hewlett-Packard HP Z400 Workstation/0B4Ch
      RIP: 0010:[<ffffffffa0399bd5>]  [<ffffffffa0399bd5>] destroy_conntrack+0x35/0x120 [nf_conntrack]
      RSP: 0018:ffff880276913d78  EFLAGS: 00010206
      RAX: 50626b6b7876376c RBX: ffff88026e530d68 RCX: ffff88028d158e00
      RDX: ffff88026d0d5470 RSI: 0000000000000011 RDI: 0000000000000002
      RBP: ffff880276913d88 R08: 0000000000000000 R09: ffff880295002900
      R10: 0000000000000000 R11: 0000000000000003 R12: ffffffff81ca3b40
      R13: ffffffff8151a8e0 R14: ffff880270875000 R15: 0000000000000002
      FS:  00007ff3bce38a00(0000) GS:ffff88029fc40000(0000) knlGS:0000000000000000
      CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
      CR2: 00007fd1430bd000 CR3: 000000027042b000 CR4: 00000000000027e0
      DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
      Process qemu-kvm (pid: 25407, threadinfo ffff880276912000, task ffff88028c369720)
      Stack:
       ffff880156f59100 ffff880156f59100 ffff880276913d98 ffffffff815534f7
       ffff880276913db8 ffffffff8151a74b ffff880270875000 ffff880156f59100
       ffff880276913dd8 ffffffff8151a5a6 ffff880276913dd8 ffff88026d0d5470
      Call Trace:
       [<ffffffff815534f7>] nf_conntrack_destroy+0x17/0x20
       [<ffffffff8151a74b>] skb_release_head_state+0x7b/0x100
       [<ffffffff8151a5a6>] __kfree_skb+0x16/0xa0
       [<ffffffff8151a666>] kfree_skb+0x36/0xa0
       [<ffffffff8151a8e0>] skb_queue_purge+0x20/0x40
       [<ffffffffa02205f7>] __tun_detach+0x117/0x140 [tun]
       [<ffffffffa022184c>] tun_chr_close+0x3c/0xd0 [tun]
       [<ffffffff8119669c>] __fput+0xec/0x240
       [<ffffffff811967fe>] ____fput+0xe/0x10
       [<ffffffff8107eb27>] task_work_run+0xa7/0xe0
       [<ffffffff810149e1>] do_notify_resume+0x71/0xb0
       [<ffffffff81640152>] int_signal+0x12/0x17
      Code: 00 00 04 48 89 e5 41 54 53 48 89 fb 4c 8b a7 e8 00 00 00 0f 85 de 00 00 00 0f b6 73 3e 0f b7 7b 2a e8 10 40 00 00 48 85 c0 74 0e <48> 8b 40 28 48 85 c0 74 05 48 89 df ff d0 48 c7 c7 08 6a 3a a0
      RIP  [<ffffffffa0399bd5>] destroy_conntrack+0x35/0x120 [nf_conntrack]
       RSP <ffff880276913d78>
      
      This is because tun_net_xmit() needs to call nf_reset()
      before queuing skb into receive_queue
      Reported-by: NDave Jones <davej@redhat.com>
      Signed-off-by: NEric Dumazet <edumazet@google.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      f8af75f3
    • S
      be2net: use CSR-BAR SEMAPHORE reg for BE2/BE3 · c5b3ad4c
      Sathya Perla 提交于
      The SLIPORT_SEMAPHORE register shadowed in the
      config-space may not reflect the correct POST stage after
      an EEH reset in BE2/3; it may return FW_READY state even though
      FW is not ready. This causes the driver to prematurely
      poll the FW mailbox and fail.
      
      For BE2/3 use the CSR-BAR/0xac instead.
      Reported-by: NGavin Shan <shangw@linux.vnet.ibm.com>
      Signed-off-by: NSathya Perla <sathya.perla@emulex.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c5b3ad4c
    • B
      sfc: Correct efx_rx_buffer::page_offset when EFX_PAGE_IP_ALIGN != 0 · c73e787a
      Ben Hutchings 提交于
      RX DMA buffers start at an offset of EFX_PAGE_IP_ALIGN bytes from the
      start of a cache line.  This offset obviously needs to be included in
      the virtual address, but this was missed in commit b590ace0
      ('sfc: Fix efx_rx_buf_offset() in the presence of swiotlb') since
      EFX_PAGE_IP_ALIGN is equal to 0 on both x86 and powerpc.
      Signed-off-by: NBen Hutchings <bhutchings@solarflare.com>
      c73e787a
    • B
      sfc: Disable soft interrupt handling during efx_device_detach_sync() · 35205b21
      Ben Hutchings 提交于
      efx_device_detach_sync() locks all TX queues before marking the device
      detached and thus disabling further TX scheduling.  But it can still
      be interrupted by TX completions which then result in TX scheduling in
      soft interrupt context.  This will deadlock when it tries to acquire
      a TX queue lock that efx_device_detach_sync() already acquired.
      
      To avoid deadlock, we must use netif_tx_{,un}lock_bh().
      Signed-off-by: NBen Hutchings <bhutchings@solarflare.com>
      35205b21
  9. 06 3月, 2013 2 次提交
    • G
      benet: Wait f/w POST until timeout · 66d29cbc
      Gavin Shan 提交于
      While PCI card faces EEH errors, reset (usually hot reset) is
      expected to recover from the EEH errors. After EEH core finishes
      the reset, the driver callback (be_eeh_reset) is called and wait
      the firmware to complete POST successfully. The original code would
      return with error once detecting failure during POST stage. That
      seems not enough.
      
      The patch forces the driver (be_eeh_reset) to wait the firmware
      completes POST until timeout, instead of returning error upon
      detection POST failure immediately. Also, it would improve the
      reliability of the EEH funtionality of the driver.
      Signed-off-by: NGavin Shan <shangw@linux.vnet.ibm.com>
      Acked-by: NSathya Perla <sathya.perla@emulex.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      66d29cbc
    • Z
      reset nf before xmit vxlan encapsulated packet · 88c4c066
      Zang MingJie 提交于
      We should reset nf settings bond to the skb as ipip/ipgre do.
      
      If not, the conntrack/nat info bond to the origin packet may continually
      redirect the packet to vxlan interface causing a routing loop.
      
      this is the scenario:
      
           VETP     VXLAN Gateway
          /----\  /---------------\
          |    |  |               |
          |  vx+--+vx --NAT-> eth0+--> Internet
          |    |  |               |
          \----/  \---------------/
      
      when there are any packet coming from internet to the vetp, there will be lots
      of garbage packets coming out the gateway's vxlan interface, but none actually
      sent to the physical interface, because they are redirected back to the vxlan
      interface in the postrouting chain of NAT rule, and dmesg complains:
      
          Mar  1 21:52:53 debian kernel: [ 8802.997699] Dead loop on virtual device vxlan0, fix it urgently!
          Mar  1 21:52:54 debian kernel: [ 8804.004907] Dead loop on virtual device vxlan0, fix it urgently!
          Mar  1 21:52:55 debian kernel: [ 8805.012189] Dead loop on virtual device vxlan0, fix it urgently!
          Mar  1 21:52:56 debian kernel: [ 8806.020593] Dead loop on virtual device vxlan0, fix it urgently!
      
      the patch should fix the problem
      Signed-off-by: NZang MingJie <zealot0630@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      88c4c066
  10. 05 3月, 2013 1 次提交