Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Acked-by: N"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of allocating a var to store 0 and just return it,
change the code to return 0 directly.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Make sure pm_runtime_* calls does not use unnecessary
IS_ERR_VALUE().

Reported by scripts/coccinelle/api/pm_runtime.cocci script.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using if (foo == false), just use
if (!foo).

That allows a faster mental parsing when analyzing the
code.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using if (foo == false), just use
if (!foo).

That allows a faster mental parsing when analyzing the
code.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

instead of testing bools if they are false or true, just use
if (!foo) or if (foo). That makes the code easier to
read and shorter.

Also, properly initialize booleans with true or false.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

lml33dpatch is boolean. So, the possible values are
true or false.

Instead of using if (lml33dpath), just use
if (!lml33dpath).

That allows a faster mental parsing when analyzing the
code.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using if (on == true), just use
if (on).

That allows a faster mental parsing when analyzing the
code.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

instead of testing if it is false or true, just use
if (!foo) or if (foo). That makes the code easier to
read and shorter.

Also, properly initialize booleans with true or false.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using if (foo == false), just use
if (!foo).

That allows a faster mental parsing when analyzing the
code.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.

Also, instead of testing foo == false, just use the
simplified notation if(!foo).
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of using 0 or 1 for boolean, use the true/false
defines.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

The error return code STV0900_NO_ERROR happens only once, at
the end of the functions. So, just return it directly.

This driver should actually be fixed to return standard
Linux error codes, instead of its own macros, but this
should be done on a separate patchset.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

We don't use semicolons after curly braces in the middle of the
code.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

We don't use semicolons after curly braces in the middle of the
code.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

We don't use semicolons after curly braces in the middle of the
code.
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>

Instead of allocating and coping from __user, do it using
one atomic call. That makes the code simpler.

Found by coccinelle.
Acked-by: NHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: NMauro Carvalho Chehab <m.chehab@samsung.com>