1. 08 3月, 2010 2 次提交
    • U
      i2c: move i2c_omap's probe function to .devinit.text · 1139aea9
      Uwe Kleine-König 提交于
      A pointer to omap_i2c_probe is passed to the core via
      platform_driver_register and so the function must not disappear when the
      .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
      unbinding and binding a device to the driver via sysfs will result in an
      oops as does a device being registered late.
      
      An alternative to this patch is using platform_driver_probe instead of
      platform_driver_register plus removing the pointer to the probe function
      from the struct platform_driver.
      Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Cc: Kalle Jokiniemi <ext-kalle.jokiniemi@nokia.com>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Paul Walmsley <paul@pwsan.com>
      Cc: Richard Woodruff <r-woodruff2@ti.com>
      Cc: chandra shekhar <x0044955@ti.com>
      Cc: Jason P Marini <jason.marini@gmail.com>
      Cc: Syed Mohammed Khasim  <x0khasim@ti.com>
      Cc: Jarkko Nikula <jarkko.nikula@nokia.com>
      Cc: Juha Yrjola <juha.yrjola@solidboot.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      1139aea9
    • C
      i2c: omap: Add support for 16-bit registers · d84d3ea3
      Cory Maccarrone 提交于
      The current i2c-omap driver is set up for 32-bit registers, which
      corresponds to most OMAP devices.  However, OMAP730/850 based
      devices use a 16-bit register size.
      
      This change modifies the driver to perform a runtime CPU type check
      to determine the register sizes, and uses a bit shift of either 1
      or 2 bits to compute the proper register sizes for all registers.
      Signed-off-by: NCory Maccarrone <darkstar6262@gmail.com>
      Acked-by: NTony Lindgren <tony@atomide.com>
      Signed-off-by: NBen Dooks <ben-linux@fluff.org>
      d84d3ea3
  2. 24 12月, 2009 2 次提交
    • M
      i2c-omap: OMAP3: Fix I2C lockup during timeout/error cases · 57eb81b1
      Manjunatha GK 提交于
      Current OMAP3 I2C driver code does not follow the correct sequence for soft
      reset. Due to this, lock up issues are reported during timeout/error cases.
      
      This patch fixes above issue by disabling I2C controller as per OMAP3430 TRM
      for soft reset. As per TRM, I2C controller needs to be disabled as a first
      step during soft reset.
      
      Here is correct soft reset sequence:
      a. Ensure that the module is disabled
      (clear the I2Ci.I2C_CON[15] I2C_EN bit to 0).
      b. Set the I2Ci.I2C_SYSC[1] SRST bit to 1.
      c. Enable the module by setting I2Ci.I2C_CON[15] I2C_EN bit to 1.
      d. Check the I2Ci.I2C_SYSS[0] RDONE bit until it is set to 1 to
      indicate the software reset is complete.
      
      Tested on Zoom2, Zoom3, 3430SDP and 3630SDP
      Signed-off-by: NManjunatha GK <manjugk@ti.com>
      Signed-off-by: George, Harith<harith@ti.com>
      Acked-by: Varadarajan, Charu Latha<charu@ti.com>
      Signed-off-by: NBen Dooks <ben-linux@fluff.org>
      57eb81b1
    • C
      i2c-omap: Don't write IE state in unidle if 0 · 07ac31f6
      Cory Maccarrone 提交于
      Commit ef871432... (i2c-omap: OMAP3: PM: (re)init for every transfer
      to support off-mode) introduced a change which make the dev->iestate
      contents be written to the OMAP_I2C_IE_REG every time omap_i2c_unidle
      is called.  Previously, the state was only written if it wasn't equal
      to zero.
      
      In omap_i2c_probe, omap_i2c_unidle() is called prior to omap_i2c_init(),
      in which case dev->iestate has not yet been initialized and will be set
      to zero.  Having this value written to the registers causes deadlock
      while booting.
      
      As such, this change restores the original functionality.
      Signed-off-by: NCory Maccarrone <darkstar6262@gmail.com>
      Signed-off-by: NBen Dooks <ben-linux@fluff.org>
      07ac31f6
  3. 09 12月, 2009 1 次提交
    • R
      i2c-omap: OMAP3: PM: (re)init for every transfer to support off-mode · ef871432
      Rajendra Nayak 提交于
      Because of OMAP off-mode, powerdomain can go off when I2C is idle.
      Save enough state, and do a re-init for each transfer.
      
      Additional save/restore state added by Jagadeesh Bhaskar Pakaravoor
      (SYSC_REG) and Aaro Koskinen (wakeup sources.)
      
      Also, The OMAP3430 TRM states:
      
      "During active mode (I2Ci.I2C_CON[15] I2C_EN bit is set to 1), make no
      changes to the I2Ci.I2C_SCLL and I2Ci.I2C_SCLH registers.  Changes may
      result in unpredictable behavior."
      
      Hence, the I2C_EN bit should be clearer when modifying these
      registers. Please note that clearing the entire I2C_CON register to
      disable the I2C module is safe, because the I2C_CON register is
      re-configured for each transfer.
      Signed-off-by: NJouni Hogander <jouni.hogander@nokia.com>
      Signed-off-by: NRajendra Nayak <rnayak@ti.com>
      Cc: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@ti.com>
      Cc: Aaro Koskinen <aaro.koskinen@nokia.com>
      Cc: Jon Hunter <jon-hunter@ti.com>
      Cc: Hu Tao <taohu@motorola.com>
      Cc: Xiaolong Chen <A21785@motorola.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      Signed-off-by: NBen Dooks <ben-linux@fluff.org>
      ef871432
  4. 21 8月, 2009 3 次提交
  5. 30 7月, 2009 4 次提交
  6. 15 7月, 2009 1 次提交
  7. 22 6月, 2009 1 次提交
    • T
      i2c-omap: Fix build breaking typo cpu_is_omap_2430 · ff0f2426
      Tony Lindgren 提交于
      Hi Ben,
      
      Can you please queue this fix?
      
      Thanks,
      
      Tony
      
      >From ffe2b2cdf6283770b70a197e3748c6b40a1006be Mon Sep 17 00:00:00 2001
      From: Tony Lindgren <tony@atomide.com>
      Date: Wed, 17 Jun 2009 13:14:23 +0300
      Subject: [PATCH] i2c-omap: Fix build breaking typo in cpu_is_omap_2430
      
      Commit 84bf2c86 introduced a typo, it should be cpu_is_omap2430
      instead. The typo was probably caused by a mismerge.
      
      Without this patch all omaps fail to build with:
      error: implicit declaration of function 'cpu_is_omap_2430'
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      Signed-off-by: NBen Dooks <ben-linux@fluff.org>
      ff0f2426
  8. 17 6月, 2009 1 次提交
    • L
      i2c: Use resource_size macro · c6ffddea
      Linus Walleij 提交于
      This replace all instances in the i2c busses tree of
      res->end - res->start + 1 with the handy macro resource_size(res)
      from ioport.h (coming in from platform_device.h).
      
      This was created with a simple
      sed -i -e 's/\([a-z]*\)->end *- *[a-z]*->start *+ *1/resource_size(\1)/g'
      
      Then manually replacing the PXA redefiniton of the same kind
      of macro manually. Recompiled some ARM defconfigs I could find to
      make a rough test so it shouldn't break anything, though I
      couldn't see exactly which configs you need for all the drivers.
      Signed-off-by: NLinus Walleij <linus.walleij@stericsson.com>
      Signed-off-by: NBen Dooks <ben-linux@fluff.org>
      c6ffddea
  9. 13 6月, 2009 2 次提交
  10. 09 2月, 2009 3 次提交
  11. 17 12月, 2008 1 次提交
  12. 22 11月, 2008 12 次提交
  13. 06 9月, 2008 1 次提交
  14. 23 4月, 2008 1 次提交
  15. 24 3月, 2008 1 次提交
    • T
      i2c-omap: Fix unhandled fault · f08ac4e7
      Tony Lindgren 提交于
      If an I2C interrupt happens between disabling interface clock
      and functional clock, the interrupt handler will produce an
      external abort on non-linefetch error when trying to access
      driver registers while interface clock is disabled.
      
      This patch fixes the problem by saving and disabling i2c-omap
      interrupt before turning off the clocks. Also disable functional
      clock before the interface clock as suggested by Paul Walmsley.
      
      Patch also renames enable/disable_clocks functions to unidle/idle
      functions. Note that the driver is currently not taking advantage
      of the idle interrupts. To use the idle interrupts, driver would
      have to enable interface clock based on the idle interrupt
      and dev->idle flag.
      
      This patch has been tested in linux-omap tree with various omaps.
      
      Cc: Paul Walmsley <paul@pwsan.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      f08ac4e7
  16. 28 1月, 2008 1 次提交
  17. 15 1月, 2008 1 次提交
  18. 12 12月, 2007 1 次提交
  19. 20 10月, 2007 1 次提交