1. 21 2月, 2015 1 次提交
    • D
      rhashtable: don't allocate ht structure on stack in test_rht_init · b7f5e5c7
      Daniel Borkmann 提交于
      With object runtime debugging enabled, the rhashtable test suite
      will rightfully throw a warning "ODEBUG: object is on stack, but
      not annotated" from rhashtable_init().
      
      This is because run_work is (correctly) being initialized via
      INIT_WORK(), and not annotated by INIT_WORK_ONSTACK(). Meaning,
      rhashtable_init() is okay as is, we just need to move ht e.g.,
      into global scope.
      
      It never triggered anything, since test_rhashtable is rather a
      controlled environment and effectively runs to completion, so
      that stack memory is not vanishing underneath us, we shouldn't
      confuse any testers with it though.
      
      Fixes: 7e1e7763 ("lib: Resizable, Scalable, Concurrent Hash Table")
      Signed-off-by: NDaniel Borkmann <daniel@iogearbox.net>
      Acked-by: NThomas Graf <tgraf@suug.ch>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b7f5e5c7
  2. 31 1月, 2015 1 次提交