1. 10 7月, 2007 1 次提交
  2. 17 5月, 2007 1 次提交
    • C
      Remove SLAB_CTOR_CONSTRUCTOR · a35afb83
      Christoph Lameter 提交于
      SLAB_CTOR_CONSTRUCTOR is always specified. No point in checking it.
      Signed-off-by: NChristoph Lameter <clameter@sgi.com>
      Cc: David Howells <dhowells@redhat.com>
      Cc: Jens Axboe <jens.axboe@oracle.com>
      Cc: Steven French <sfrench@us.ibm.com>
      Cc: Michael Halcrow <mhalcrow@us.ibm.com>
      Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
      Cc: Miklos Szeredi <miklos@szeredi.hu>
      Cc: Steven Whitehouse <swhiteho@redhat.com>
      Cc: Roman Zippel <zippel@linux-m68k.org>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Dave Kleikamp <shaggy@austin.ibm.com>
      Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
      Cc: "J. Bruce Fields" <bfields@fieldses.org>
      Cc: Anton Altaparmakov <aia21@cantab.net>
      Cc: Mark Fasheh <mark.fasheh@oracle.com>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Christoph Hellwig <hch@lst.de>
      Cc: Jan Kara <jack@ucw.cz>
      Cc: David Chinner <dgc@sgi.com>
      Cc: "David S. Miller" <davem@davemloft.net>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      a35afb83
  3. 09 5月, 2007 1 次提交
  4. 08 5月, 2007 2 次提交
    • C
      slab allocators: Remove SLAB_DEBUG_INITIAL flag · 50953fe9
      Christoph Lameter 提交于
      I have never seen a use of SLAB_DEBUG_INITIAL.  It is only supported by
      SLAB.
      
      I think its purpose was to have a callback after an object has been freed
      to verify that the state is the constructor state again?  The callback is
      performed before each freeing of an object.
      
      I would think that it is much easier to check the object state manually
      before the free.  That also places the check near the code object
      manipulation of the object.
      
      Also the SLAB_DEBUG_INITIAL callback is only performed if the kernel was
      compiled with SLAB debugging on.  If there would be code in a constructor
      handling SLAB_DEBUG_INITIAL then it would have to be conditional on
      SLAB_DEBUG otherwise it would just be dead code.  But there is no such code
      in the kernel.  I think SLUB_DEBUG_INITIAL is too problematic to make real
      use of, difficult to understand and there are easier ways to accomplish the
      same effect (i.e.  add debug code before kfree).
      
      There is a related flag SLAB_CTOR_VERIFY that is frequently checked to be
      clear in fs inode caches.  Remove the pointless checks (they would even be
      pointless without removeal of SLAB_DEBUG_INITIAL) from the fs constructors.
      
      This is the last slab flag that SLUB did not support.  Remove the check for
      unimplemented flags from SLUB.
      Signed-off-by: NChristoph Lameter <clameter@sgi.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      50953fe9
    • N
      mm: make read_cache_page synchronous · 6fe6900e
      Nick Piggin 提交于
      Ensure pages are uptodate after returning from read_cache_page, which allows
      us to cut out most of the filesystem-internal PageUptodate calls.
      
      I didn't have a great look down the call chains, but this appears to fixes 7
      possible use-before uptodate in hfs, 2 in hfsplus, 1 in jfs, a few in
      ecryptfs, 1 in jffs2, and a possible cleared data overwritten with readpage in
      block2mtd.  All depending on whether the filler is async and/or can return
      with a !uptodate page.
      Signed-off-by: NNick Piggin <npiggin@suse.de>
      Cc: Hugh Dickins <hugh@veritas.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      6fe6900e
  5. 18 4月, 2007 1 次提交
  6. 17 3月, 2007 4 次提交
  7. 15 2月, 2007 1 次提交
    • T
      [PATCH] remove many unneeded #includes of sched.h · cd354f1a
      Tim Schmielau 提交于
      After Al Viro (finally) succeeded in removing the sched.h #include in module.h
      recently, it makes sense again to remove other superfluous sched.h includes.
      There are quite a lot of files which include it but don't actually need
      anything defined in there.  Presumably these includes were once needed for
      macros that used to live in sched.h, but moved to other header files in the
      course of cleaning it up.
      
      To ease the pain, this time I did not fiddle with any header files and only
      removed #includes from .c-files, which tend to cause less trouble.
      
      Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
      arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
      allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
      configs in arch/arm/configs on arm.  I also checked that no new warnings were
      introduced by the patch (actually, some warnings are removed that were emitted
      by unnecessarily included header files).
      Signed-off-by: NTim Schmielau <tim@physik3.uni-rostock.de>
      Acked-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      cd354f1a
  8. 13 2月, 2007 5 次提交
  9. 10 2月, 2007 1 次提交
    • E
      [PATCH] ufs: restore back support of openstep · f336953b
      Evgeniy Dushistov 提交于
      This is a fix of regression, which triggered by ~2.6.16.
      
      Patch with name ufs-directory-and-page-cache-from-blocks-to-pages.patch: in
      additional to conversation from block to page cache mechanism added new
      checks of directory integrity, one of them that directory entry do not
      across directory chunks.
      
      But some kinds of UFS: OpenStep UFS and Apple UFS (looks like these are the
      same filesystems) have different directory chunk size, then common
      UFSes(BSD and Solaris UFS).
      
      So this patch adds ability to works with variable size of directory chunks,
      and set it for ufstype=openstep to right size.
      
      Tested on darwin ufs.
      Signed-off-by: NEvgeniy Dushistov <dushistov@mail.ru>
      Cc: <stable@kernel.org>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      f336953b
  10. 31 1月, 2007 3 次提交
  11. 06 1月, 2007 1 次提交
    • E
      [PATCH] fix garbage instead of zeroes in UFS · d63b7090
      Evgeniy Dushistov 提交于
      Looks like this is the problem, which point Al Viro some time ago:
      
      ufs's get_block callback allocates 16k of disk at a time, and links that
      entire 16k into the file's metadata.  But because get_block is called for only
      a single buffer_head (a 2k buffer_head in this case?) we are only able to tell
      the VFS that this 2k is buffer_new().
      
      So when ufs_getfrag_block() is later called to map some more data in the file,
      and when that data resides within the remaining 14k of this fragment,
      ufs_getfrag_block() will incorrectly return a !buffer_new() buffer_head.
      
      I don't see _right_ way to do nullification of whole block, if use inode
      page cache, some pages may be outside of inode limits (inode size), and
      will be lost; if use blockdev page cache it is possible to zero real data,
      if later inode page cache will be used.
      
      The simpliest way, as can I see usage of block device page cache, but not only
      mark dirty, but also sync it during "nullification".  I use my simple tests
      collection, which I used for check that create,open,write,read,close works on
      ufs, and I see that this patch makes ufs code 18% slower then before.
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      d63b7090
  12. 09 12月, 2006 1 次提交
  13. 08 12月, 2006 4 次提交
  14. 11 10月, 2006 1 次提交
  15. 01 10月, 2006 2 次提交
  16. 27 9月, 2006 3 次提交
  17. 28 8月, 2006 2 次提交
    • E
      [PATCH] ufs: truncate correction · ecdc6394
      Evgeniy Dushistov 提交于
      1) When we allocated last fragment in ufs_truncate, we read page, check
         if block mapped to address, and if not trying to allocate it.  This is
         wrong behaviour, fragment may be NOT allocated, but mapped, this
         happened because of "block map" function not checked allocated fragment
         or not, it just take address of the first fragment in the block, add
         offset of fragment and return result, this is correct behaviour in
         almost all situation except call from ufs_truncate.
      
      2) Almost all implementation of UFS, which I can investigate have such
         "defect": if you have full disk, and try truncate file, for example 3GB
         to 2MB, and have hole in this region, truncate return -ENOSPC.  I tried
         evade from this problem, but "block allocation" algorithm is tied to
         right value of i_lastfrag, and fix of this corner case may slow down of
         ordinaries scenarios, so this patch makes behavior of "truncate"
         operations similar to what other UFS implementations do.
      Signed-off-by: NEvgeniy Dushistov <dushistov@mail.ru>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      ecdc6394
    • E
      [PATCH] ufs: write to hole in big file · c37336b0
      Evgeniy Dushistov 提交于
      On UFS, this scenario:
      	open(O_TRUNC)
      	lseek(1024 * 1024 * 80)
      	write("A")
      	lseek(1024 * 2)
      	write("A")
      
      may cause access to invalid address.
      
      This happened because of "goal" is calculated in wrong way in block
      allocation path, as I see this problem exists also in 2.4.
      
      We use construction like this i_data[lastfrag], i_data array of pointers to
      direct blocks, indirect and so on, it has ceratain size ~20 elements, and
      lastfrag may have value for example 40000.
      
      Also this patch fixes related to handling such scenario issues, wrong
      zeroing metadata, in case of block(not fragment) allocation, and wrong goal
      calculation, when we allocate block
      Signed-off-by: NEvgeniy Dushistov <dushistov@mail.ru>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      c37336b0
  18. 06 8月, 2006 2 次提交
  19. 01 8月, 2006 1 次提交
  20. 04 7月, 2006 1 次提交
    • A
      [PATCH] lockdep: annotate the quota code · 5c81a419
      Arjan van de Ven 提交于
      The quota code plays interesting games with the lock ordering; to quote Jan:
      
      | i_mutex of inode containing quota file is acquired after all other
      | quota locks. i_mutex of all other inodes is acquired before quota
      | locks. Quota code makes sure (by resetting inode operations and
      | setting special flag on inode) that noone tries to enter quota code
      | while holding i_mutex on a quota file...
      
      The good news is that all of this special case i_mutex grabbing happens in the
      (per filesystem) low level quota write function.  For this special case we
      need a new I_MUTEX_* nesting level, since this just entirely outside any of
      the regular VFS locking rules for i_mutex.  I trust Jan on his blue eyes that
      this is not ever going to deadlock; and based on that the patch below is what
      it takes to inform lockdep of these very interesting new locking rules.
      
      The new locking rule for the I_MUTEX_QUOTA nesting level is that this is the
      deepest possible level of nesting for i_mutex, and that this only should be
      used in quota write (and possibly read) function of filesystems.  This makes
      the lock ordering of the I_MUTEX_* levels:
      
      I_MUTEX_PARENT -> I_MUTEX_CHILD -> I_MUTEX_NORMAL -> I_MUTEX_QUOTA
      
      Has no effect on non-lockdep kernels.
      Signed-off-by: NArjan van de Ven <arjan@linux.intel.com>
      Acked-by: NIngo Molnar <mingo@elte.hu>
      Cc: Jan Kara <jack@ucw.cz>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      5c81a419
  21. 02 7月, 2006 1 次提交
  22. 01 7月, 2006 1 次提交