1. 05 3月, 2008 1 次提交
    • M
      eCryptfs: make ecryptfs_prepare_write decrypt the page · e4465fda
      Michael Halcrow 提交于
      When the page is not up to date, ecryptfs_prepare_write() should be
      acting much like ecryptfs_readpage(). This includes the painfully
      obvious step of actually decrypting the page contents read from the
      lower encrypted file.
      
      Note that this patch resolves a bug in eCryptfs in 2.6.24 that one can
      produce with these steps:
      
      # mount -t ecryptfs /secret /secret
      # echo "abc" > /secret/file.txt
      # umount /secret
      # mount -t ecryptfs /secret /secret
      # echo "def" >> /secret/file.txt
      # cat /secret/file.txt
      
      Without this patch, the resulting data returned from cat is likely to
      be something other than "abc\ndef\n".
      
      (Thanks to Benedikt Driessen for reporting this.)
      Signed-off-by: NMichael Halcrow <mhalcrow@us.ibm.com>
      Cc: Benedikt Driessen <bdriessen@escrypt.com>
      Cc: <stable@kernel.org>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      e4465fda
  2. 07 2月, 2008 2 次提交
  3. 06 2月, 2008 1 次提交
    • C
      Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user · eebd2aa3
      Christoph Lameter 提交于
      Simplify page cache zeroing of segments of pages through 3 functions
      
      zero_user_segments(page, start1, end1, start2, end2)
      
              Zeros two segments of the page. It takes the position where to
              start and end the zeroing which avoids length calculations and
      	makes code clearer.
      
      zero_user_segment(page, start, end)
      
              Same for a single segment.
      
      zero_user(page, start, length)
      
              Length variant for the case where we know the length.
      
      We remove the zero_user_page macro. Issues:
      
      1. Its a macro. Inline functions are preferable.
      
      2. The KM_USER0 macro is only defined for HIGHMEM.
      
         Having to treat this special case everywhere makes the
         code needlessly complex. The parameter for zeroing is always
         KM_USER0 except in one single case that we open code.
      
      Avoiding KM_USER0 makes a lot of code not having to be dealing
      with the special casing for HIGHMEM anymore. Dealing with
      kmap is only necessary for HIGHMEM configurations. In those
      configurations we use KM_USER0 like we do for a series of other
      functions defined in highmem.h.
      
      Since KM_USER0 is depends on HIGHMEM the existing zero_user_page
      function could not be a macro. zero_user_* functions introduced
      here can be be inline because that constant is not used when these
      functions are called.
      
      Also extract the flushing of the caches to be outside of the kmap.
      
      [akpm@linux-foundation.org: fix nfs and ntfs build]
      [akpm@linux-foundation.org: fix ntfs build some more]
      Signed-off-by: NChristoph Lameter <clameter@sgi.com>
      Cc: Steven French <sfrench@us.ibm.com>
      Cc: Michael Halcrow <mhalcrow@us.ibm.com>
      Cc: <linux-ext4@vger.kernel.org>
      Cc: Steven Whitehouse <swhiteho@redhat.com>
      Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
      Cc: "J. Bruce Fields" <bfields@fieldses.org>
      Cc: Anton Altaparmakov <aia21@cantab.net>
      Cc: Mark Fasheh <mark.fasheh@oracle.com>
      Cc: David Chinner <dgc@sgi.com>
      Cc: Michael Halcrow <mhalcrow@us.ibm.com>
      Cc: Steven French <sfrench@us.ibm.com>
      Cc: Steven Whitehouse <swhiteho@redhat.com>
      Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      eebd2aa3
  4. 18 12月, 2007 1 次提交
  5. 17 10月, 2007 10 次提交
  6. 31 8月, 2007 1 次提交
  7. 20 7月, 2007 1 次提交
  8. 29 6月, 2007 2 次提交
    • M
      zero out last page for llseek/write · d4c5cdb3
      Michael Halcrow 提交于
      When one llseek's past the end of the file and then writes, every page past
      the previous end of the file should be cleared.  Trevor found that the code,
      as is, does not assure that the very last page is always cleared.  This patch
      takes care of that.
      Signed-off-by: NMichael Halcrow <mhalcrow@us.ibm.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      d4c5cdb3
    • M
      eCryptfs: fix write zeros behavior · 240e2df5
      Michael Halcrow 提交于
      This patch fixes the processes involved in wiping regions of the data during
      truncate and write events, fixing a kernel hang in 2.6.22-rc4 while assuring
      that zero values are written out to the appropriate locations during events in
      which the i_size will change.
      
      The range passed to ecryptfs_truncate() from ecryptfs_prepare_write() includes
      the page that is the object of ecryptfs_prepare_write().  This leads to a
      kernel hang as read_cache_page() is executed on the same page in the
      ecryptfs_truncate() execution path.  This patch remedies this by limiting the
      range passed to ecryptfs_truncate() so as to exclude the page that is the
      object of ecryptfs_prepare_write(); it also adds code to
      ecryptfs_prepare_write() to zero out the region of its own page when writing
      past the i_size position.  This patch also modifies ecryptfs_truncate() so
      that when a file is truncated to a smaller size, eCryptfs will zero out the
      contents of the new last page from the new size through to the end of the last
      page.
      Signed-off-by: NMichael Halcrow <mhalcrow@us.ibm.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      240e2df5
  9. 24 5月, 2007 1 次提交
  10. 17 5月, 2007 1 次提交
  11. 08 5月, 2007 1 次提交
  12. 05 3月, 2007 2 次提交
  13. 02 3月, 2007 2 次提交
  14. 13 2月, 2007 6 次提交
  15. 09 12月, 2006 1 次提交
  16. 04 10月, 2006 1 次提交