1. 18 5月, 2009 3 次提交
  2. 20 2月, 2009 1 次提交
  3. 27 1月, 2009 1 次提交
  4. 21 1月, 2009 2 次提交
  5. 18 1月, 2009 8 次提交
  6. 09 1月, 2009 1 次提交
  7. 07 1月, 2009 1 次提交
  8. 06 1月, 2009 1 次提交
  9. 28 12月, 2008 1 次提交
  10. 23 12月, 2008 1 次提交
  11. 16 12月, 2008 2 次提交
  12. 10 12月, 2008 2 次提交
  13. 05 12月, 2008 4 次提交
  14. 03 12月, 2008 1 次提交
    • A
      UBI: fix warnings when debugging is enabled · ed45819f
      Artem Bityutskiy 提交于
      The 'ubi_io_read_vid_hdr()' and 'ubi_io_read_ec_hdr()' function
      have the 'verbose' argument which controls whether they should
      print a warning if the VID/EC header was not found or was corrupted.
      Some callers require the headers to be OK, and pass 1. Some allow
      a corrupted/not present header, and pass 0.
      
             if (UBI_IO_DEBUG)
                     verbose = 1;
      
      And UBI_IO_DEBUG is 1 if CONFIG_MTD_UBI_DEBUG_MSG_BLD is true. So in
      this case the warning is printed all the time. This confuses people.
      
      Thus, do not print the messages as warnings if UBI_IO_DEBUG is true,
      but print them as debugging messages instead.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      ed45819f
  15. 06 11月, 2008 2 次提交
  16. 09 10月, 2008 1 次提交
  17. 27 9月, 2008 1 次提交
    • J
      UBI: fix IS_ERR test · 0e4a008a
      Julien Brunel 提交于
      In case of error, the function add_volume returns an ERR pointer. The
      result of IS_ERR, which is supposed to be used in a test as it is, is
      here checked to be less than zero, which seems odd. We suggest to
      replace this test by a simple IS_ERR test.
      
      A simplified version of the semantic match that finds this problem is
      as follows:
      (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @def0@
      expression x;
      position p0;
      @@
      x@p0 = add_volume(...)
      
      @protected@
      expression def0.x,E;
      position def0.p0;
      position p;
      statement S;
      @@
      x@p0
      ... when != x = E
      if (!IS_ERR(x) && ...) {<... x@p ...>} else S
      
      @unprotected@
      expression def0.x,E;
      identifier fld;
      position def0.p0;
      position p != protected.p;
      @@
      x@p0
      ... when != x = E
      * x@p->fld
      // </smpl>
      Signed-off-by: NJulien Brunel <brunel@diku.dk>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      0e4a008a
  18. 05 9月, 2008 1 次提交
  19. 25 7月, 2008 1 次提交
    • A
      UBI: always start the background thread · d37e6bf6
      Artem Bityutskiy 提交于
      This fix only affects UBI debugging.
      
      If the the background thread is disabled for debugging purposes,
      start it anyway, because otherwise we see tonns of kernel debugging
      complaints like this:
      
      INFO: task ubi_bgt0d:26857 blocked for more than 120 seconds.
      "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
      ubi_bgt0d     D dd37bf94     0 26857      2
             dd37bfcc 00000086 f8e17cea dd37bf94 00000046 00000000 00000000 f5c62430
             f5c62430 f5c62590 c2a09c80 f6cbd498 dd8e9cbc 00000296 dd37bfb0 00000296
             dd8e9cb8 dd8e9cbc dd37bfcc c0119774 00000000 00000000 c0132e89 f6961560
      Call Trace:
       [<f8e17cea>] ? ubi_thread+0x0/0x127 [ubi]
       [<c0119774>] ? complete+0x43/0x4b
       [<c0132e89>] ? kthread+0x0/0x5b
       [<f8e17cea>] ? ubi_thread+0x0/0x127 [ubi]
       [<c0132eae>] kthread+0x25/0x5b
       [<c0132e89>] ? kthread+0x0/0x5b
       [<c0104953>] kernel_thread_helper+0x7/0x14
       =======================
      
      So start it, and go sleep inside it, instead of creating it and never
      start.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      d37e6bf6
  20. 24 7月, 2008 5 次提交