Signed-off-by: NMike McCormack <mikem@ring3k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMike McCormack <mikem@ring3k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMike McCormack <mikem@ring3k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMike McCormack <mikem@ring3k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMike McCormack <mikem@ring3k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMike McCormack <mikem@ring3k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMike McCormack <mikem@ring3k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMike McCormack <mikem@ring3k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NMike McCormack <mikem@ring3k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Make the use in wmi_verify_tspec_params match the declaration
of the variable.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Don't use 0/1 for an A_BOOL.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Make the return an A_BOOL not int.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use A_BOOL as appropriate for actual variable uses.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

It's declared that way in the prototype, use it that way too.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Convert a set of an A_BOOL from 0 to FALSE.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use the appropriate define.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The previous uses of BDADDR_Present set the initial value to
A_ERROR (-1) when not present and A_OK (0) when present.

A later test for (!BDADDR_Present) was therefore logically inverted.
Convert the values to TRUE/FALSE and the test is now logically correct.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Make the declaration type match the assigned from type.
It's not a bool, it's a u8.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Types should match logical uses.
Remove unused extern, make static.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

These structures are device native and need to be 4 bytes long.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove obfuscating A_FAILED(foo) macro.
Just test for foo instead.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Remove obfuscating A_SUCCESS(foo) macro.
Just test for !foo instead.

Reformat a few macros that used A_SUCCESS for better readability.
Add do { foo } while (0) surrounds to those macros too.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Convert enum members to int as well.
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Add bool unicast and bool multicast to set_default_key
Return struct net_device * to add_virtual_intf
Signed-off-by: NJoe Perches <joe@perches.com>
Acked-by: NVipin Mehta <vipin.mehta@atheros.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch removes explicit unlikely() when using BUG_ON() in
wl_cfg80211.c
Signed-off-by: NColy Li <bosong.ly@taobao.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This code elsewhere returns a negative constant to an indicate an error,
while IS_ERR returns the result of a >= operation.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
@@

 if (...) { ...
- return IS_ERR(x);
+ return PTR_ERR(x);
}
// </smpl>
Signed-off-by: NJulia Lawall <julia@diku.dk>
Acked-by: NDavid Brown <davidb@codeaurora.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: NHank Janssen <hjanssen@microsoft.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

For all I know, Appletalk is dead, the only reasonable
use right now would be nostalgia, and that can be served
well enough by old kernels. The code is largely not
in a bad shape, but it still uses the big kernel lock,
and nobody seems motivated to change that.

FWIW, the last release of MacOS that supported Appletalk
was MacOS X 10.5, made in 2007, and it has been abandoned
by Apple with 10.6. Using TCP/IP instead of Appletalk has
been supported since MacOS 7.6, which was released in
1997 and is able to run on most of the legacy hardware.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: netdev@vger.kernel.org
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

smbfs got moved to staging in 2.6.37, so we can
finally remove it in the 2.6.39 merge window.
All users should by now have migrated to cifs.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Cc: linux-cifs@vger.kernel.org
Cc: Jeff Layton <jlayton@redhat.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

autofs3 was moved to staging in 2.6.37, so we can
remove it in the 2.6.39 merge window. If we have
a reason to bring it back after that, this patch
can get reverted.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
About-fscking-timed-by: NH. Peter Anvin <hpa@zytor.com>
Cc: Ian Kent <raven@themaw.net>
Cc: autofs@linux.kernel.org
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

There is nothing that the BKL can possibly
protect here, so just remove it.

Cc: Ross Cohen <rcohen@snurgle.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Fix multiple rts_pstor build errors.

When CONFIG_PCI is not enabled:

drivers/staging/rts_pstor/rtsx.c: In function 'rtsx_acquire_irq':
drivers/staging/rts_pstor/rtsx.c:324: error: implicit declaration of function 'pci_intx'
drivers/staging/rts_pstor/rtsx.c: In function 'rtsx_read_pci_cfg_byte':
drivers/staging/rts_pstor/rtsx.c:336: error: implicit declaration of function 'pci_get_domain_bus_and_slot'
drivers/staging/rts_pstor/rtsx.c:336: warning: assignment makes pointer from integer without a cast
drivers/staging/rts_pstor/rtsx.c: In function 'rtsx_shutdown':
drivers/staging/rts_pstor/rtsx.c:462: error: implicit declaration of function 'pci_disable_msi'
drivers/staging/rts_pstor/rtsx.c: In function 'rtsx_probe':
drivers/staging/rts_pstor/rtsx.c:981: error: implicit declaration of function 'pci_enable_msi'

When CONFIG_SCSI is not enabled:

In file included from drivers/staging/rts_pstor/rtsx.h:45,
                 from drivers/staging/rts_pstor/rtsx.c:28:
include/scsi/scsi_cmnd.h:27:25: warning: "BLK_MAX_CDB" is not defined
include/scsi/scsi_cmnd.h:28:3: error: #error MAX_COMMAND_SIZE can not be bigger than BLK_MAX_CDB
In file included from drivers/staging/rts_pstor/rtsx.h:45,
                 from drivers/staging/rts_pstor/rtsx.c:28:
include/scsi/scsi_cmnd.h: In function 'scsi_bidi_cmnd':
include/scsi/scsi_cmnd.h:184: error: implicit declaration of function 'blk_bidi_rq'
include/scsi/scsi_cmnd.h:185: error: dereferencing pointer to incomplete type
include/scsi/scsi_cmnd.h: In function 'scsi_in':
include/scsi/scsi_cmnd.h:191: error: dereferencing pointer to incomplete type
include/scsi/scsi_cmnd.h: In function 'scsi_get_lba':  CC      drivers/gpu/drm/nouveau/nv04_tv.o

include/scsi/scsi_cmnd.h:269: error: implicit declaration of function 'blk_rq_pos'
In file included from drivers/staging/rts_pstor/rtsx.h:48,
                 from drivers/staging/rts_pstor/rtsx.c:28:
include/scsi/scsi_eh.h: At top level:
include/scsi/scsi_eh.h:84: error: 'BLK_MAX_CDB' undeclared here (not in a function)
drivers/staging/rts_pstor/rtsx.c: In function 'slave_configure':
drivers/staging/rts_pstor/rtsx.c:107: error: implicit declaration of function 'blk_queue_dma_alignment'
Signed-off-by: NRandy Dunlap <randy.dunlap@oracle.com>
Cc: wei_wang@realsil.com.cn
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch fixes errors reported by checkpatch.pl
in westbridge device controller driver in the staging tree.
File containing EXPORT_SYMBOL() macros for all the APIs exported
by the westbridge software has been removed. EXPORT_SYMBOL()
macros are added after the corresponding function definitions.
Signed-off-by: NSutharsan Ramamoorthy <srmt@cypress.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>