1. 21 9月, 2011 1 次提交
  2. 21 7月, 2011 1 次提交
    • J
      fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers · 02c24a82
      Josef Bacik 提交于
      Btrfs needs to be able to control how filemap_write_and_wait_range() is called
      in fsync to make it less of a painful operation, so push down taking i_mutex and
      the calling of filemap_write_and_wait() down into the ->fsync() handlers.  Some
      file systems can drop taking the i_mutex altogether it seems, like ext3 and
      ocfs2.  For correctness sake I just pushed everything down in all cases to make
      sure that we keep the current behavior the same for everybody, and then each
      individual fs maintainer can make up their mind about what to do from there.
      Thanks,
      Acked-by: NJan Kara <jack@suse.cz>
      Signed-off-by: NJosef Bacik <josef@redhat.com>
      Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
      02c24a82
  3. 07 6月, 2011 1 次提交
    • A
      UBI: remove dead code · 4788b60a
      Artem Bityutskiy 提交于
      Thanks to new gcc 4.6 for issuing the following warning:
      
      drivers/mtd/ubi/vtbl.c: In function ‘create_vtbl’:
      drivers/mtd/ubi/vtbl.c:311:33: warning: variable ‘old_seb’ set but not used [-Wunused-but-set-variable]
      
      This patch removes some dead code and fixes the warning.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      4788b60a
  4. 01 6月, 2011 6 次提交
  5. 31 5月, 2011 1 次提交
  6. 25 5月, 2011 1 次提交
  7. 20 5月, 2011 3 次提交
  8. 14 4月, 2011 5 次提交
  9. 05 4月, 2011 3 次提交
  10. 31 3月, 2011 1 次提交
  11. 24 3月, 2011 1 次提交
  12. 16 3月, 2011 7 次提交
    • A
      UBI: make tests modes dynamic · 28237e45
      Artem Bityutskiy 提交于
      Similarly to the debugging checks and message, make the test modes
      be dynamically selected via the "debug_tsts" module parameter or
      via the "/sys/module/ubi/parameters/debug_tsts" sysfs file. This
      is consistent with UBIFS as well.
      
      And now, since all the Kconfig knobs became dynamic, we can remove
      the Kconfig.debug file completely.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      28237e45
    • A
      UBI: make self-checks dynamic · 92d124f5
      Artem Bityutskiy 提交于
      This patch adds a possibility to dynamically switch UBI self-checks
      on and off, instead of toggling them compile-time from the configuration
      menu. This is much more flexible, and consistent with UBIFS, and this
      also simplifies UBI Kconfig menu and the code.
      
      This patch introduces two levels of self-checks - general, which
      includes all self-checks which are relatively fast, and I/O, which
      includes write-verify checks and erase-verify checks, which are
      relatively slow and involve flash I/O.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      92d124f5
    • A
      UBI: make debugging messages dynamic · b342efd4
      Artem Bityutskiy 提交于
      This patch adds a possibility to dynamically select UBI debugging
      messages, instead of selecting them compile-time from the configuration
      menu. This is much more flexible, and consistent with UBIFS, and this
      also simplifies UBI Kconfig menu and the code.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      b342efd4
    • A
      UBI: remove UBI_IO_DEBUG macro · 6f9fdf62
      Artem Bityutskiy 提交于
      This additional little macro is used to print a bit more messages
      while scanning the media. However, we have the 'dbg_bld()' macro
      for this, so we better us 'dbg_bld()' and kill UBI_IO_DEBUG. This
      simplifies the code a tiny bit.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      6f9fdf62
    • A
      UBI: kill debugging buffer · 6edb9793
      Artem Bityutskiy 提交于
      This patch kills the 'ubi->dbg_peb_buf' debugging buffer and the
      associated mutex, because all users of this buffer are now gone.
      We are killing this buffer because we are going to switch to
      dynamic debugging control, just like in UBIFS, which means that
      CONFIG_MTD_UBI_DEBUG_PARANOID will be removed. In this case we'd
      end up always allocating 'ubi->dbg_peb_buf', which is rather large
      (128KiB or more), and this would be wasteful. Thus, we are just
      killing it.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      6edb9793
    • A
      UBI: allocate erase checking buffer on demand · 332873d6
      Artem Bityutskiy 提交于
      Instead of using pre-allocated 'ubi->dbg_peb_buf' buffer in
      'ubi_dbg_check_all_ff()', dynamically allocate it when needed. The
      intend is to get rid of the pre-allocated 'ubi->dbg_peb_buf' buffer
      completely. And the need for this arises because we want to change
      to dynamic debugging control instead of compile-time control, i.e.,
      we are going to kill the CONFIG_MTD_UBI_DEBUG_PARANOID Kconfig
      option, which would mean that 'ubi->dbg_peb_buf' is always allocated,
      which would be wasteful.
      
      Thus, we are getting rid of 'ubi->dbg_peb_buf', and this is a
      preparation for that.
      signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      332873d6
    • A
      UBI: allocate write checking buffer on demand · a7586743
      Artem Bityutskiy 提交于
      Instead of using pre-allocated 'ubi->dbg_peb_buf' buffer in
      'ubi_dbg_check_write()', dynamically allocate it when needed. The
      intend is to get rid of the pre-allocated 'ubi->dbg_peb_buf' buffer
      completely. And the need for this arises because we want to change
      to dynamic debugging control instead of compile-time control, i.e.,
      we are going to kill the CONFIG_MTD_UBI_DEBUG_PARANOID Kconfig
      option, which would mean that 'ubi->dbg_peb_buf' is always allocated,
      which would be wasteful.
      
      Thus, we are getting rid of 'ubi->dbg_peb_buf', and this is a
      preparation for that.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      a7586743
  13. 08 3月, 2011 2 次提交
  14. 07 2月, 2011 5 次提交
    • A
      UBI: always re-read in case of read failures · a87f29cb
      Artem Bityutskiy 提交于
      When the read operation fails, UBI tries to re-read several times in
      a hope that one of the subsequent reads may succeed. However, currently
      UBI re-reads only if MTD failed to read all data, but does not re-reads
      if all the data were read, but with an integrity error (-EBADMSB). This
      patch makes UBI to always re-try reading.
      
      This should be useful for reading NAND pages with unstable bits -
      re-reading may help to get correct data.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      a87f29cb
    • A
      UBI: cleanup comments about corrupted PEBs · fef2deb3
      Artem Bityutskiy 提交于
      Just make them a bit more readable and explanatory.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      fef2deb3
    • A
      UBI: add slab cache for ubi_scan_leb objects · 6c1e875c
      Artem Bityutskiy 提交于
      During scanning UBI allocates one struct ubi_scan_leb object for each PEB,
      so it can end up allocating thousands of them. Use slab cache to reduce
      memory consumption for these 48-byte objects, because currently used
      'kmalloc()' ends up allocating 64 bytes per object, instead of 48.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      6c1e875c
    • A
      UBI: use raw mtd read function in debugging code · 7950d023
      Artem Bityutskiy 提交于
      This change affects only the debugging code. Namely, use mtd->read()
      function instead of ubi_io_read() to avoid bit-flips injection
      (ubi_dbg_is_bitflip()) which we do not want on the debugging path.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      7950d023
    • A
      UBI: try to reveal buggy MTD drivers · 276832d8
      Artem Bityutskiy 提交于
      When reading data from the flash, corrupt the buffer we are about to
      read to. The idea is to fix the following possible situation:
      
      1. The buffer contains data from previous operation, e.g., read from
         another PEB previously. The data looks like expected, e.g., if we
         just do not read anything and return - the caller would not
         notice this. E.g., if we are reading a VID header, the buffer may
         contain a valid VID header from another PEB.
      2. The driver is buggy and returns use success or -EBADMSG or
         -EUCLEAN, but it does not actually put any data to the buffer.
      
      This may confuse UBI or upper layers - they may think the buffer
      contains valid data while in fact it is just old data.
      
      Thus, try to reveal such buggy MTD drivers with simple debugging
      code which fills the read buffer with 0x12 constant.
      Signed-off-by: NArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
      276832d8
  15. 30 1月, 2011 1 次提交
  16. 26 1月, 2011 1 次提交