1. 07 10月, 2009 1 次提交
    • E
      pkt_sched: gen_estimator: Dont report fake rate estimators · d250a5f9
      Eric Dumazet 提交于
      Jarek Poplawski a écrit :
      >
      >
      > Hmm... So you made me to do some "real" work here, and guess what?:
      > there is one serious checkpatch warning! ;-) Plus, this new parameter
      > should be added to the function description. Otherwise:
      > Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
      >
      > Thanks,
      > Jarek P.
      >
      > PS: I guess full "Don't" would show we really mean it...
      
      Okay :) Here is the last round, before the night !
      
      Thanks again
      
      [RFC] pkt_sched: gen_estimator: Don't report fake rate estimators
      
      We currently send TCA_STATS_RATE_EST elements to netlink users, even if no estimator
      is running.
      
      # tc -s -d qdisc
      qdisc pfifo_fast 0: dev eth0 root bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
       Sent 112833764978 bytes 1495081739 pkt (dropped 0, overlimits 0 requeues 0)
       rate 0bit 0pps backlog 0b 0p requeues 0
      
      User has no way to tell if the "rate 0bit 0pps" is a real estimation, or a fake
      one (because no estimator is active)
      
      After this patch, tc command output is :
      $ tc -s -d qdisc
      qdisc pfifo_fast 0: dev eth0 root bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
       Sent 561075 bytes 1196 pkt (dropped 0, overlimits 0 requeues 0)
       backlog 0b 0p requeues 0
      
      We add a parameter to gnet_stats_copy_rate_est() function so that
      it can use gen_estimator_active(bstats, r), as suggested by Jarek.
      
      This parameter can be NULL if check is not necessary, (htb for
      example has a mandatory rate estimator)
      Signed-off-by: NEric Dumazet <eric.dumazet@gmail.com>
      Signed-off-by: NJarek Poplawski <jarkao2@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      d250a5f9
  2. 25 8月, 2009 1 次提交
  3. 26 11月, 2008 1 次提交
  4. 17 10月, 2008 1 次提交
  5. 13 8月, 2008 2 次提交
  6. 08 8月, 2008 1 次提交
  7. 26 7月, 2008 1 次提交
  8. 26 3月, 2008 1 次提交
  9. 29 1月, 2008 13 次提交
  10. 15 9月, 2007 1 次提交
    • J
      [NET_SCHED] protect action config/dump from irqs · e1e992e5
      Jamal Hadi Salim 提交于
      (with no apologies to C Heston)
      
      On Mon, 2007-10-09 at 21:00 +0800, Herbert Xu wrote:
      On Sun, Sep 02, 2007 at 01:11:29PM +0000, Christian Kujau wrote:
      > >
      > > after upgrading to 2.6.23-rc5 (and applying davem's fix [0]), lockdep
      > > was quite noisy when I tried to shape my external (wireless) interface:
      > >
      > > [ 6400.534545] FahCore_78.exe/3552 just changed the state of lock:
      > > [ 6400.534713]  (&dev->ingress_lock){-+..}, at: [<c038d595>]
      > > netif_receive_skb+0x2d5/0x3c0
      > > [ 6400.534941] but this lock took another, soft-read-irq-unsafe lock in the
      > > past:
      > > [ 6400.535145]  (police_lock){-.--}
      >
      > This is a genuine dead-lock.  The police lock can be taken
      > for reading with softirqs on.  If a second CPU tries to take
      > the police lock for writing, while holding the ingress lock,
      > then a softirq on the first CPU can dead-lock when it tries
      > to get the ingress lock.
      Signed-off-by: NJamal Hadi Salim <hadi@cyberus.ca>
      Acked-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      e1e992e5
  11. 11 7月, 2007 3 次提交
  12. 26 4月, 2007 3 次提交
  13. 15 2月, 2007 1 次提交
    • T
      [PATCH] remove many unneeded #includes of sched.h · cd354f1a
      Tim Schmielau 提交于
      After Al Viro (finally) succeeded in removing the sched.h #include in module.h
      recently, it makes sense again to remove other superfluous sched.h includes.
      There are quite a lot of files which include it but don't actually need
      anything defined in there.  Presumably these includes were once needed for
      macros that used to live in sched.h, but moved to other header files in the
      course of cleaning it up.
      
      To ease the pain, this time I did not fiddle with any header files and only
      removed #includes from .c-files, which tend to cause less trouble.
      
      Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
      arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
      allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
      configs in arch/arm/configs on arm.  I also checked that no new warnings were
      introduced by the patch (actually, some warnings are removed that were emitted
      by unnecessarily included header files).
      Signed-off-by: NTim Schmielau <tim@physik3.uni-rostock.de>
      Acked-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      cd354f1a
  14. 11 2月, 2007 1 次提交
  15. 23 9月, 2006 2 次提交
  16. 22 7月, 2006 1 次提交
  17. 13 7月, 2006 1 次提交
  18. 10 7月, 2006 1 次提交
  19. 06 7月, 2006 3 次提交
  20. 01 7月, 2006 1 次提交