1. 09 7月, 2007 1 次提交
  2. 02 7月, 2007 1 次提交
    • P
      3c589_cs: fix local_bh_enable warning · 63ac9b91
      Patrick McHardy 提交于
      Russell King wrote:
      > Having upgraded from 2.6.16 to 2.6.22-rc6, I'm now seeing the following.
      >
      > Looks like netfilter is calling local_bh_enable() with IRQs disabled,
      > which would appear to be illegal.  Thankfully, this is a warn-once
      > warning.
      >
      > WARNING: at /home/rmk/git/linux-2.6-rmk/kernel/softirq.c:138 local_bh_enable()
      > [...]
      > [<c01447fc>] (nf_conntrack_destroy+0x0/0x2c) from [<c012c05c>] (__kfree_skb+0xd0/0x100)
      > [<c012bf8c>] (__kfree_skb+0x0/0x100) from [<c012c0d8>] (kfree_skb+0x4c/0x50)
      >  r5:c12a3800 r4:00000300
      > [<c012c08c>] (kfree_skb+0x0/0x50) from [<bf03cbb0>] (el3_start_xmit+0xb8/0xd0 [3c589_cs])
      > [<bf03caf8>] (el3_start_xmit+0x0/0xd0 [3c589_cs]) from [<c01324dc>] (dev_hard_start_xmit+0x1a8/0x244)
      >  r7:c12a3800 r6:c1a9aa00 r5:c1a9aa00 r4:c12a3800
      > [<c0132334>] (dev_hard_start_xmit+0x0/0x244) from [<c013fcc0>] (__qdisc_run+0xb0/0x198)
      
      Thats a bug in the 3c589_cs driver. Patch attached.
      Signed-off-by: NPatrick McHardy <kaber@trash.net>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      63ac9b91
  3. 29 6月, 2007 1 次提交
  4. 12 5月, 2007 1 次提交
  5. 10 5月, 2007 1 次提交
    • P
      Fix hang on IBM Token Ring PCMCIA card ejection · 5bebf82f
      Paul Walmsley 提交于
      Ejecting a PCMCIA IBM Token Ring card that has not had its dev->open()
      called will reliably trigger an uninitialized spinlock oops when
      spinlock debugging is enabled. The system then hangs, occasionally
      softlockup oopsing.  Apparently ibmtr.c:tok_interrupt() doesn't expect
      to be called before tok_open(), but tok_interrupt() gets called anyway
      when the card is ejected.  So, set an already-existing flag which
      causes tok_interrupt() to bail out early upon card ejection. Tested by
      inserting and removing the PCMCIA card several times.
      Signed-off-by: NPaul Walmsley <paul@booyaka.com>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      5bebf82f
  6. 08 5月, 2007 1 次提交
  7. 26 4月, 2007 3 次提交
  8. 15 3月, 2007 1 次提交
  9. 18 2月, 2007 1 次提交
  10. 23 1月, 2007 1 次提交
  11. 12 1月, 2007 1 次提交
  12. 09 1月, 2007 1 次提交
  13. 05 12月, 2006 3 次提交
  14. 02 12月, 2006 1 次提交
  15. 22 11月, 2006 1 次提交
  16. 07 10月, 2006 1 次提交
  17. 05 10月, 2006 1 次提交
    • D
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells 提交于
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: NDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  18. 14 9月, 2006 1 次提交
  19. 12 9月, 2006 1 次提交
    • A
      [PATCH] Remove more unnecessary driver printk's · d5b20697
      Andy Gospodarek 提交于
      As I promised last week, here is the first pass at removing all
      unnecessary printk's that exist in network device drivers currently in
      promiscuous mode.  The duplicate messages are not needed so they have
      been removed.  Some of these drivers are quite old and might not need an
      update, but I did them all anyway.
      
      I am currently auditing the remaining conditional printk's and will send
      out a patch for those soon.
      Signed-off-by: NAndy Gospodarek <andy@greyhouse.net>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      d5b20697
  20. 24 8月, 2006 1 次提交
  21. 20 8月, 2006 1 次提交
  22. 09 8月, 2006 1 次提交
  23. 03 7月, 2006 1 次提交
  24. 01 7月, 2006 1 次提交
  25. 27 6月, 2006 1 次提交
  26. 23 6月, 2006 2 次提交
    • H
      [NET]: Avoid allocating skb in skb_pad · 5b057c6b
      Herbert Xu 提交于
      First of all it is unnecessary to allocate a new skb in skb_pad since
      the existing one is not shared.  More importantly, our hard_start_xmit
      interface does not allow a new skb to be allocated since that breaks
      requeueing.
      
      This patch uses pskb_expand_head to expand the existing skb and linearize
      it if needed.  Actually, someone should sift through every instance of
      skb_pad on a non-linear skb as they do not fit the reasons why this was
      originally created.
      
      Incidentally, this fixes a minor bug when the skb is cloned (tcpdump,
      TCP, etc.).  As it is skb_pad will simply write over a cloned skb.  Because
      of the position of the write it is unlikely to cause problems but still
      it's best if we don't do it.
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      5b057c6b
    • E
      [PATCH] Remove useless check in drivers/net/pcmcia/xirc2ps_cs.c · da4f5ccf
      Eric Sesterhenn 提交于
      hi,
      
      coverity choked at this check (id #223), assuming that
      skb might be NULL and used anyways later. Since
      start_hard_xmit() always gets called with a valid
      skb, the check is useless and this patch removes it.
      Signed-off-by: NEric Sesterhenn <snakebyte@gmx.de>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      da4f5ccf
  27. 06 6月, 2006 1 次提交
  28. 24 5月, 2006 2 次提交
  29. 20 5月, 2006 1 次提交
  30. 22 4月, 2006 1 次提交
  31. 13 4月, 2006 1 次提交
  32. 01 4月, 2006 1 次提交
    • O
      [PATCH] Don't pass boot parameters to argv_init[] · 9b41046c
      OGAWA Hirofumi 提交于
      The boot cmdline is parsed in parse_early_param() and
      parse_args(,unknown_bootoption).
      
      And __setup() is used in obsolete_checksetup().
      
      	start_kernel()
      		-> parse_args()
      			-> unknown_bootoption()
      				-> obsolete_checksetup()
      
      If __setup()'s callback (->setup_func()) returns 1 in
      obsolete_checksetup(), obsolete_checksetup() thinks a parameter was
      handled.
      
      If ->setup_func() returns 0, obsolete_checksetup() tries other
      ->setup_func().  If all ->setup_func() that matched a parameter returns 0,
      a parameter is seted to argv_init[].
      
      Then, when runing /sbin/init or init=app, argv_init[] is passed to the app.
      If the app doesn't ignore those arguments, it will warning and exit.
      
      This patch fixes a wrong usage of it, however fixes obvious one only.
      Signed-off-by: NOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      9b41046c
  33. 31 3月, 2006 2 次提交