1. 21 12月, 2016 2 次提交
    • L
      ACPI / osl: Remove deprecated acpi_get_table_with_size()/early_acpi_os_unmap_memory() · 8d3523fb
      Lv Zheng 提交于
      Since all users are cleaned up, remove the 2 deprecated APIs due to no
      users.
      As a Linux variable rather than an ACPICA variable, acpi_gbl_permanent_mmap
      is renamed to acpi_permanent_mmap to have a consistent coding style across
      entire Linux ACPI subsystem.
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      8d3523fb
    • L
      ACPICA: Tables: Back port acpi_get_table_with_size() and... · 174cc718
      Lv Zheng 提交于
      ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel
      
      ACPICA commit cac6790954d4d752a083e6122220b8a22febcd07
      
      This patch back ports Linux acpi_get_table_with_size() and
      early_acpi_os_unmap_memory() into ACPICA upstream to reduce divergences.
      
      The 2 APIs are used by Linux as table management APIs for long time, it
      contains a hidden logic that during the early stage, the mapped tables
      should be unmapped before the early stage ends.
      
      During the early stage, tables are handled by the following sequence:
       acpi_get_table_with_size();
       parse the table
       early_acpi_os_unmap_memory();
      During the late stage, tables are handled by the following sequence:
       acpi_get_table();
       parse the table
      Linux uses acpi_gbl_permanent_mmap to distinguish the early stage and the
      late stage.
      
      The reasoning of introducing acpi_get_table_with_size() is: ACPICA will
      remember the early mapped pointer in acpi_get_table() and Linux isn't able to
      prevent ACPICA from using the wrong early mapped pointer during the late
      stage as there is no API provided from ACPICA to be an inverse of
      acpi_get_table() to forget the early mapped pointer.
      
      But how ACPICA can work with the early/late stage requirement? Inside of
      ACPICA, tables are ensured to be remained in "INSTALLED" state during the
      early stage, and they are carefully not transitioned to "VALIDATED" state
      until the late stage. So the same logic is in fact implemented inside of
      ACPICA in a different way. The gap is only that the feature is not provided
      to the OSPMs in an accessible external API style.
      
      It then is possible to fix the gap by providing an inverse of
      acpi_get_table() from ACPICA, so that the two Linux sequences can be
      combined:
       acpi_get_table();
       parse the table
       acpi_put_table();
      In order to work easier with the current Linux code, acpi_get_table() and
      acpi_put_table() is implemented in a usage counting based style:
       1. When the usage count of the table is increased from 0 to 1, table is
          mapped and .Pointer is set with the mapping address (VALIDATED);
       2. When the usage count of the table is decreased from 1 to 0, .Pointer
          is unset and the mapping address is unmapped (INVALIDATED).
      So that we can deploy the new APIs to Linux with minimal effort by just
      invoking acpi_get_table() in acpi_get_table_with_size() and invoking
      acpi_put_table() in early_acpi_os_unmap_memory(). Lv Zheng.
      
      Link: https://github.com/acpica/acpica/commit/cac67909Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      174cc718
  2. 21 10月, 2016 2 次提交
  3. 10 9月, 2016 2 次提交
    • B
      ACPICA: Update version to 20160831 · cb7d668f
      Bob Moore 提交于
      ACPICA commit 3c8c04c2e8a371018b3a29f5cfe27a241caea48d
      
      Version 20160831
      
      Link: https://github.com/acpica/acpica/commit/3c8c04c2Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      cb7d668f
    • L
      ACPICA: Interpreter: Fix MLC issues by switching to new term_list grammar for table loading · de56ba95
      Lv Zheng 提交于
      ACPICA commit 0e24fb67cde08d7df7671d7d7b183490dc79707e
      
      The MLC (Module Level Code) is an ACPICA terminology describing the AML
      code out of any control method, its support is an indication of the
      interpreter behavior during the table loading.
      
      The original implementation of MLC in ACPICA had several issues:
      1. Out of any control method, besides of the object creating opcodes, only
         the code blocks wrapped by "If/Else/While" opcodes were supported.
      2. The supported MLC code blocks were executed after loading the table
         rather than being executed right in place.
         ============================================================
         The demo of this order issue is as follows:
           Name (OBJ1, 1)
           If (CND1 == 1)
           {
             Name (OBJ2, 2)
           }
           Name (OBJ3, 3)
         The original MLC support created OBJ2 after OBJ3's creation.
         ============================================================
      Other than these limitations, MLC support in ACPICA looks correct. And
      supporting this should be easy/natural for ACPICA, but enabling of this was
      blocked by some ACPICA internal and OSPM specific initialization order
      issues we've fixed recently. The wrong support started from the following
      false bug fixing commit:
        Commit: 7f0c826a
        Subject: ACPICA: Add support for module-level executable AML code
        Commit: 9a884ab6
        Subject: ACPICA: Add additional module-level code support
        ...
      
      We can confirm Windows interpreter behavior via reverse engineering means.
      It can be proven that not only If/Else/While wrapped code blocks, all
      opcodes can be executed at the module level, including operation region
      accesses. And it can be proven that the MLC should be executed right in
      place, not in such a deferred way executed after loading the table.
      
      And the above facts indeed reflect the spec words around ACPI definition
      block tables (DSDT/SSDT/...), the entire table and the Scope object is
      defined by the AML specification in BNF style as:
        AMLCode := def_block_header term_list
        def_scope := scope_op pkg_length name_string term_list
      The bodies of the scope opening terms (AMLCode/Scope) are all term_list,
      thus the table loading should be no difference than the control method
      evaluations as the body of the Method is also defined by the AML
      specification as term_list:
        def_method := method_op pkg_length name_string method_flags term_list
      The only difference is: after evaluating control method, created named
      objects may be freed due to no reference, while named objects created by
      the table loading should only be freed after unloading the table.
      
      So this patch follows the spec and the de-facto standard behavior, enables
      the new grammar (term_list) for the table loading.
      
      By doing so, beyond the fixes to the above issues, we can see additional
      differences comparing to the old grammar based table loading:
      1. Originally, beyond the scope opening terms (AMLCode/Scope),
         If/Else/While wrapped code blocks under the scope creating terms
         (Device/power_resource/Processor/thermal_zone) are also supported as
         deferred MLC, which violates the spec defined grammar where object_list
         is enforced. With MLC support improved as non-deferred, the interpreter
         parses such scope creating terms as term_list rather object_list like the
         scope opening terms.
         After probing the Windows behavior and proving that it also parses these
         terms as term_list, we submitted an ECR (Engineering Change Request) to
         the ASWG (ACPI Specification Working Group) to clarify this. The ECR is
         titled as "ASL Grammar Clarification for Executable AML Opcodes" and has
         been accepted by the ASWG. The new grammar will appear in ACPI
         specification 6.2.
      2. Originally, Buffer/Package/operation_region/create_XXXField/bank_field
         arguments are evaluated in a deferred way after loading the table. With
         MLC support improved, they are also parsed right in place during the
         table loading.
         This is also Windows compliant and the only difference is the removal
         of the debugging messages implemented before acpi_ds_execute_arguments(),
         see Link # [1] for the details. A previous commit should have ensured
         that acpi_check_address_range() won't regress.
      
      Note that enabling this feature may cause regressions due to long term
      Linux ACPI support on top of the wrong grammar. So this patch also prepares
      a global option to be used to roll back to the old grammar during the
      period between a regression is reported and the regression is
      root-cause-fixed. Lv Zheng.
      
      Link: https://bugzilla.kernel.org/show_bug.cgi?id=112911 # [1]
      Link: https://bugzilla.kernel.org/show_bug.cgi?id=117671 # [1]
      Link: https://bugzilla.kernel.org/show_bug.cgi?id=153541 # [1]
      Link: https://github.com/acpica/acpica/issues/122
      Link: https://bugs.acpica.org/show_bug.cgi?id=963
      Link: https://github.com/acpica/acpica/commit/0e24fb67Reported-and-tested-by: NChris Bainbridge <chris.bainbridge@gmail.com>
      Reported-by: NEhsan <dashesy@gmail.com>
      Reported-and-tested-by: NDutch Guy <lucht_piloot@gmx.net>
      Tested-by: NMika Westerberg <mika.westerberg@linux.intel.com>
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      de56ba95
  4. 13 8月, 2016 4 次提交
  5. 11 7月, 2016 1 次提交
  6. 05 5月, 2016 2 次提交
  7. 09 4月, 2016 1 次提交
  8. 05 4月, 2016 1 次提交
  9. 24 2月, 2016 1 次提交
  10. 16 1月, 2016 2 次提交
  11. 05 1月, 2016 1 次提交
    • R
      ACPICA: Drop Linux-specific waking vector functions · e3e9b577
      Rafael J. Wysocki 提交于
      Commit f06147f9 (ACPICA: Hardware: Enable firmware waking vector
      for both 32-bit and 64-bit FACS) added three functions that aren't
      present in upstream ACPICA, acpi_hw_set_firmware_waking_vectors(),
      acpi_set_firmware_waking_vectors() and acpi_set_firmware_waking_vector64(),
      to allow Linux to use the previously existing API for setting the
      platform firmware waking vector.
      
      However, that wasn't necessary, since the ACPI sleep support code
      in Linux can be modified to use the upstream ACPICA's API easily
      and the additional functions may be dropped which reduces the code
      size and puts the kernel's ACPICA code more in line with the upstream.
      
      Make the changes as per the above.  While at it, make the relevant
      function desctiption comments reflect the upstream ACPICA's ones.
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      Acked-by: NLv Zheng <lv.zheng@intel.com>
      e3e9b577
  12. 01 1月, 2016 3 次提交
  13. 15 12月, 2015 2 次提交
    • L
      ACPICA: Debugger: Fix runtime stub issues of ACPI_DEBUGGER_EXEC using different stub mechanism · 8a2a2501
      Lv Zheng 提交于
      ACPICA commit 11522d6b894054fc4d62dd4f9863ec151296b386
      
      The ACPI_DEBUGGER_EXEC is a problem now when the debugger code is compiled
      but runtime disabled. They actually will get executed in this situation.
      Although such executions are harmless if we can correctly make
      acpi_db_single_step() a runtime stub, users may still do not want to see the
      debugger print messages logged into OSPMs' kernel logs when a debugger
      driver is not loaded to enable the debugger during runtime.
      
      This patch fixes this issue by introducing new stub mechanism instead of
      ACPI_DEBUGGER_EXEC. Lv Zheng.
      
      Link: https://github.com/acpica/acpica/commit/11522d6bSigned-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      8a2a2501
    • L
      ACPICA: Debugger: Convert some mechanisms to OSPM specific · f8d31489
      Lv Zheng 提交于
      The following mechanisms are OSPM specific:
      1. Redirect output destination to console: no file redirection will be
         needed by an in-kernel debugger, there is even no file can be accessed
         when the debugger is running in the kernel mode.
      2. Output command prompts: programs other than acpiexec can have different
         prompt characters and the prompt characters may be implemented as a
         special character sequence to form a char device IO protocol.
      3. Command ready/complete handshake: OSPM debugger may wait more conditions
         to implement OSPM specific semantics (for example, FIFO full/empty
         conditions for O_NONBLOCK or IO open/close conditions).
      Leaving such OSPM specific stuffs in the ACPICA debugger core blocks
      Linux debugger IO driver implementation.
      
      Several new OSL APIs are provided by this patch:
      1. acpi_os_initialize_command_signals: initialize command handshake mechanism
         or any other OSPM specific stuffs.
      2. acpi_os_terminate_command_signals: reversal of
         acpi_os_initialize_command_signals.
      3. acpi_os_wait_command_ready: putting debugger task into wait state when a
         command is not ready. OSPMs can terminate command loop by returning
         AE_CTRL_TERMINATE from this API. Normally, wait_event() or
         wait_for_multiple_object() may be used to implement this API.
      4. acpi_os_notify_command_complete: putting user task into running state when a
         command has been completed. OSPMs can terminate command loop by
         returning AE_CTRL_TERMINATE from this API. Normally, wake_up() or
         set_event() may be used to implement this API.
      This patch also converts current command signaling implementation into a
      generic debugger layer (osgendbg.c) to be used by the existing OSPMs or
      acpiexec, in return, Linux can have chance to implement its own command
      handshake mechanism. This patch also implements acpiexec batch mode in a
      multi-threading mode comaptible style as a demo (this can be confirmed by
      configuring acpiexec into DEBUGGER_MULTI_THREADED mode where the batch mode
      is still working). Lv Zheng.
      
      Note that the OSPM specific command handshake mechanism is required by
      Linux kernel because:
      1. Linux kernel trends to use wait queue to synchronize two threads, using
         mutexes to achieve that will cause false "dead lock" warnings.
      2. The command handshake mechanism implemented by ACPICA is implemented in
         this way because of a design issue in debugger IO streaming. Debugger IO
         outputs are simply cached using a giant buffer, this should be tuned by
         Linux in the future.
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      f8d31489
  14. 22 10月, 2015 3 次提交
    • B
      ACPICA: Update version to 20150930 · b3196882
      Bob Moore 提交于
      ACPICA commit e9c75ca267262326e80d49a290e8387a5963e2d2
      
      Version 20150930.
      
      Link: https://github.com/acpica/acpica/commit/e9c75ca2Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      b3196882
    • L
      ACPI: Enable build of AML interpreter debugger · 4d946f79
      Lv Zheng 提交于
      This patch enables ACPICA debugger files using a configurable
      CONFIG_ACPI_DEBUGGER configuration item. Those debugger related code that
      was originally masked as ACPI_FUTURE_USAGE now gets unmasked.
      
      Necessary OSL stubs are also added in this patch:
      1. acpi_os_readable(): This should be arch specific in Linux, while this
          patch doesn't introduce real implementation and a complex mechanism to
          allow architecture specific acpi_os_readable() to be implemented to
          validate the address. It may be done by future commits.
      2. acpi_os_get_line(): This is used to obtain debugger command input. This
          patch only introduces a simple KDB concept example in it and the
          example should be co-working with the code implemented in
          acpi_os_printf(). Since this KDB example won't be compiled unless
          ENABLE_DEBUGGER is defined and it seems Linux has already stopped to
          use ENABLE_DEBUGGER, thus do not expect it can work properly.
      
      This patch also cleans up all other ACPI_FUTURE_USAGE surroundings
      accordingly.
      1. Since linkage error can be automatically detected, declaration in the
         headers needn't be surrounded by ACPI_FUTURE_USAGE.
         So only the following separate exported fuction bodies are masked by
         this macro (other exported fucntions may have already been masked at
         entire module level via drivers/acpi/acpica/Makefile):
           acpi_install_exception_handler()
           acpi_subsystem_status()
           acpi_get_system_info()
           acpi_get_statistics()
           acpi_install_initialization_handler()
      2. Since strip can automatically zap the no-user functions, functions that
         are not marked with ACPI_EXPORT_SYMBOL() needn't get surrounded by
         ACPI_FUTURE_USAGE.
         So the following function which is not used by Linux kernel now won't
         get surrounded by this macro:
           acpi_ps_get_name()
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      4d946f79
    • L
      ACPICA: Debugger: Add thread ID support so that single step mode can only... · f988f24e
      Lv Zheng 提交于
      ACPICA: Debugger: Add thread ID support so that single step mode can only apply to the debugger thread
      
      When the debugger is running in the kernel mode, acpi_db_single_step() may
      also be invoked by the kernel runtime code path but the single stepping
      command prompt may be erronously logged as the kernel logs and runtime code
      path cannot proceed.
      
      This patch fixes this issue by adding acpi_gbl_db_thread_id for the debugger
      thread and preventing acpi_db_single_step() to be invoked from other threads.
      
      It is not suitable to add acpi_thread_id parameter for acpi_os_execute() as
      the function may be implemented as work queue on some hosts. So it is
      better to let the hosts invoke acpi_set_debugger_thread_id(). Currently
      acpiexec is not configured as DEBUGGER_MULTI_THREADED, but we can do this.
      When we do this, it is better to invoke acpi_set_debugger_thread_id() in
      acpi_os_execute() when the execution type is OSL_DEBUGGER_MAIN_THREAD. The
      support should look like:
        create_thread(&tid);
        if (type == OSL_DEBUGGER_MAIN_THREAD)
            acpi_set_debugger_thread_id(tid);
        resume_thread(tid);
      Similarly, semop() may be used for pthread implementation. But this patch
      simply skips debugger thread ID check for application instead of
      introducing such complications as there is no need to skip
      acpi_db_single_step() for an application debugger - acpiexec.
      
      Note that the debugger thread ID can also be used by acpi_os_printf() to
      filter out debugger output. Lv Zheng.
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      f988f24e
  15. 26 8月, 2015 2 次提交
  16. 24 7月, 2015 3 次提交
  17. 02 7月, 2015 5 次提交
    • B
      ACPICA: Update version to 20150619 · ce55d01e
      Bob Moore 提交于
      ACPICA commit 2fcf4f4c95e6a4875f39a929f8f92ef50cc53bb5
      ACPICA commit d7a940bb308d001b5d2b196174fee36c7daa61d6
      
      Version 20150619.
      
      Link: https://github.com/acpica/acpica/commit/2fcf4f4c
      Link: https://github.com/acpica/acpica/commit/d7a940bbSigned-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      ce55d01e
    • B
      ACPICA: Namespace: Change namespace override to avoid node deletion · 8ea98655
      Bob Moore 提交于
      ACPICA commit c0ce529e1fbb8ec47d2522a3aa10f3ab77e16e41
      
      There is no reference counting implemented for struct acpi_namespace_node, so it
      is currently not removable during runtime.
      This patch changes the namespace override code to keep the old
      struct acpi_namespace_node undeleted so that the override mechanism can happen
      during runtime. Bob Moore.
      
      Link: https://github.com/acpica/acpica/commit/c0ce529eSigned-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      8ea98655
    • L
      ACPICA: Tables: Enable default 64-bit FADT addresses favor · 0ea61381
      Lv Zheng 提交于
      ACPICA commit 4da56eeae0749dfe8491285c1e1fad48f6efafd8
      
      The following commit temporarily disables correct 64-bit FADT addresses
      favor during the period the root cause of the bug is not fixed:
       Commit: 85dbd580
       ACPICA: Tables: Restore old behavor to favor 32-bit FADT addresses.
      
      With enough protections, this patch re-enables 64-bit FADT addresses by
      default. If regressions are reported against such change, this patch should
      be bisected and reverted.
      Note that 64-bit FACS favor and 64-bit firmware waking vector favor are
      excluded by this commit in order not to break OSPMs. Lv Zheng.
      
      Link: https://bugzilla.kernel.org/show_bug.cgi?id=74021
      Link: https://github.com/acpica/acpica/commit/4da56eea
      Cc: 3.15.1+ <stable@vger.kernel.org> # 3.15.1+
      Reported-and-tested-by: NOswald Buddenhagen <ossi@kde.org>
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      0ea61381
    • L
      ACPICA: Tables: Enable both 32-bit and 64-bit FACS · c04e1fb4
      Lv Zheng 提交于
      ACPICA commit f7b86f35416e3d1f71c3d816ff5075ddd33ed486
      
      The following commit is reported to have broken s2ram on some platforms:
       Commit: 0249ed24
       ACPICA: Add option to favor 32-bit FADT addresses.
      The platform reports 2 FACS tables (which is not allowed by ACPI
      specification) and the new 32-bit address favor rule forces OSPMs to use
      the FACS table reported via FADT's X_FIRMWARE_CTRL field.
      
      The root cause of the reported bug might be one of the followings:
      1. BIOS may favor the 64-bit firmware waking vector address when the
         version of the FACS is greater than 0 and Linux currently only supports
         resuming from the real mode, so the 64-bit firmware waking vector has
         never been set and might be invalid to BIOS while the commit enables
         higher version FACS.
      2. BIOS may favor the FACS reported via the "FIRMWARE_CTRL" field in the
         FADT while the commit doesn't set the firmware waking vector address of
         the FACS reported by "FIRMWARE_CTRL", it only sets the firware waking
         vector address of the FACS reported by "X_FIRMWARE_CTRL".
      
      This patch excludes the cases that can trigger the bugs caused by the root
      cause 2.
      
      There is no handshaking mechanism can be used by OSPM to tell BIOS which
      FACS is currently used. Thus the FACS reported by "FIRMWARE_CTRL" may still
      be used by BIOS and the 0 value of the 32-bit firmware waking vector might
      trigger such failure.
      
      This patch tries to favor 32bit FACS address in another way where both the
      FACS reported by "FIRMWARE_CTRL" and the FACS reported by "X_FIRMWARE_CTRL"
      are loaded so that further commit can set firmware waking vector in the
      both tables to ensure we can exclude the cases that trigger the bugs caused
      by the root cause 2. The exclusion is split into 2 commits as this commit
      is also useful for dumping more ACPI tables, it won't get reverted when
      such exclusion is no longer necessary. Lv Zheng.
      
      Link: https://bugzilla.kernel.org/show_bug.cgi?id=74021
      Link: https://github.com/acpica/acpica/commit/f7b86f35
      Cc: 3.14.1+ <stable@vger.kernel.org> # 3.14.1+
      Reported-and-tested-by: NOswald Buddenhagen <ossi@kde.org>
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      c04e1fb4
    • L
      ACPICA: Hardware: Enable 64-bit firmware waking vector for selected FACS · aca2a5d3
      Lv Zheng 提交于
      ACPICA commit 7aa598d711644ab0de5f70ad88f1e2de253115e4
      
      The following commit is reported to have broken s2ram on some platforms:
       Commit: 0249ed24
       ACPICA: Add option to favor 32-bit FADT addresses.
      The platform reports 2 FACS tables (which is not allowed by ACPI
      specification) and the new 32-bit address favor rule forces OSPMs to use
      the FACS table reported via FADT's X_FIRMWARE_CTRL field.
      
      The root cause of the reported bug might be one of the followings:
      1. BIOS may favor the 64-bit firmware waking vector address when the
         version of the FACS is greater than 0 and Linux currently only supports
         resuming from the real mode, so the 64-bit firmware waking vector has
         never been set and might be invalid to BIOS while the commit enables
         higher version FACS.
      2. BIOS may favor the FACS reported via the "FIRMWARE_CTRL" field in the
         FADT while the commit doesn't set the firmware waking vector address of
         the FACS reported by "FIRMWARE_CTRL", it only sets the firware waking
         vector address of the FACS reported by "X_FIRMWARE_CTRL".
      
      This patch excludes the cases that can trigger the bugs caused by the root
      cause 1.
      
      ACPI specification says:
      A. 32-bit FACS address (FIRMWARE_CTRL field in FADT):
         Physical memory address of the FACS, where OSPM and firmware exchange
         control information.
         If the X_FIRMWARE_CTRL field contains a non zero value then this field
         must be zero.
         A zero value indicates that no FACS is specified by this field.
      B. 64-bit FACS address (X_FIRMWARE_CTRL field in FADT):
         64bit physical memory address of the FACS.
         This field is used when the physical address of the FACS is above 4GB.
         If the FIRMWARE_CTRL field contains a non zero value then this field
         must be zero.
         A zero value indicates that no FACS is specified by this field.
      Thus the 32bit and 64bit firmware waking vector should indicate completely
      different resuming environment - real mode (1MB addressable) and non real
      mode (4GB+ addressable) and currently Linux only supports resuming from
      real mode.
      
      This patch enables 64-bit firmware waking vector for selected FACS via new
      acpi_set_firmware_waking_vectors() API so that it's up to OSPMs to
      determine which resuming mode should be used by BIOS and ACPICA changes
      won't trigger the bugs caused by the root cause 1. Lv Zheng.
      
      Link: https://bugzilla.kernel.org/show_bug.cgi?id=74021
      Link: https://github.com/acpica/acpica/commit/7aa598d7Reported-and-tested-by: NOswald Buddenhagen <ossi@kde.org>
      Signed-off-by: NLv Zheng <lv.zheng@intel.com>
      Signed-off-by: NBob Moore <robert.moore@intel.com>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      aca2a5d3
  18. 22 5月, 2015 1 次提交
  19. 14 4月, 2015 2 次提交