We should first check whether platform data is NULL or not, before
dereferencing it to get the keymap.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Reviewed-by: NFelipe Balbi <balbi@ti.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

In case of an error in h3600ts_connect(), deconstruct in correct order
and with the right calls.
Signed-off-by: NChristoph Fritz <chf.fritz@googlemail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NShubhrajyoti D <a0393217@india.ti.com>
Acked-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

In rpckbd_open prror path, free_irq() was using NULL rather than the
driver data as the data pointer so free_irq() wouldn't have matched.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NManoj Iyer <manoj.iyer@canonical.com>
Acked-by: NPing Cheng <pingc@wacom.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

On a "really fragile" laptop I noticed a single
    i8042.c: i8042 controller selftest failed. (0x1 != 0x55)

error in the log. But there's no reason to print this message at
KERN_ERR level each time that loop fails, especially since the message
telling about the overall selftest failure is printed at KERN_INFO level
(on X86).

Add an actual error message for non-X86 systems, where a selftest
failure is (apparently) more serious. Remove a space in an another error
message.
Signed-off-by: NPaul Bolle <pebolle@tiscali.nl>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

'struct dmi_system_id' arrays must always have a terminator to keep
dmi_check_system() from looking at data (and possibly crashing) it
isn't supposed to look at.

The issue went unnoticed until ef8313bb,
but was introduced about a year earlier with
7705d548 (which also similarly changed
lifebook.c, but the problem there got eliminated shortly afterwards).

The first hunk therefore is a stable candidate back to 2.6.33, while
the full change is needed only on 2.6.38.
Signed-off-by: NJan Beulich <jbeulich@novell.com>
Cc: stable@kernel.org
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We should return IRQ_NONE from interrupt handler in case keyboard
does not report DATA_AVAIL condition.
Signed-off-by: NRajeev Kumar <rajeev-dlh.kumar@st.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Some devices provide absolute axes with min/max of 0/0 (e.g. wacom's
ABS_MISC axis). Current uinput restrictions do not allow duplication of
these devices and require hacks in userspace to work around this.

If the kernel accepts physical devices with a min/max of 0/0, uinput
shouldn't disallow the same range.
Signed-off-by: NPeter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

This allows for debugging non-functional keys easily from
userspace.
Signed-off-by: NSeth Forshee <seth.forshee@canonical.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Scancodes are useful debugging aids when incorrect keycodes
are being sent, as is common with laptop hotkeys.
Signed-off-by: NSeth Forshee <seth.forshee@canonical.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NSylvestre Ledru <sylvestre.ledru@scilab.org>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Touch resolution is reported to the userland by retrieving the value
from the HID descriptor. But pen resolution is not since it can not
be retrieved. The current Wacom X driver has a resolution table.
To centralize the source of these values, the resolution entries are
added in the wacom_features struct for x and y coordinates respectively.
The values are then reported to the userland.
Signed-off-by: NPing Cheng <pingc@wacom.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Signed-off-by: NPing Cheng <pingc@wacom.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Commit 0b950d3d (Input: tsc2005 - add open/close) introduced a
locking issue with the ESD watchdog: __tsc2005_disable() is calling
cancel_delayed_work_sync() with mutex held, and the work also needs the
same mutex.

Fix the problem by using mutex_trylock() in tsc2005_esd_work(). If the
mutex is taken, we know we are in the middle of disable or enable and
the watchdog check can be skipped.
Signed-off-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Use relative jiffies to schedule the watchdog. Otherwise it will run
like a mad one.
Signed-off-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

drivers/input/touchscreen/tsc2005.c: In function ‘tsc2005_probe’:
drivers/input/touchscreen/tsc2005.c:666: error: implicit declaration of function ‘set_irq_wake’

In addition, migrate from set_irq_wake() (marked "do not use" as of commit
a0cd9ca2 ("genirq: Namespace cleanup")) to
irq_set_irq_wake().
Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

I believe that enable/disable functionality should not be implemented on
the individual driver level but rather in device core, potentially
reusing parts of PM framework. Therefore the driver-specific "disable"
attribute is removed from the mainline driver.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Introduce open and close methods for the input device to keep the device
powered down when it is not in use. Also rework interaction between
interrupt thread and starting/shutting off/resetting the device: instead
of taking a mutex in the intterrupt thread and elsewhere disable interrupts
before transitioning the device in a new state.

The ESD handling is also separated from the IRQ thread; we poll regularly
at a given interval and simply skip reads if we see that valid interrupt
happened not so long ago. This allows us not cancel and reschedule ESD
work from interrupt context all the time.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We will most likely rearm it yet again the IRQ thread so doing it here
is pointless.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We do not need process context to send input events so let's switch to
a regular timer. I am going to get rid of taking ts->mutex in
tsc2005_irq_thread() later.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Sparse in unhappy when people use 0 instead of NULL for pointers so
let's rework the way we initialize spi_transfer structure in
tsc2005_cmd() and tsc2005_write().
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

If implementation to perform self-test/reset has not been provided by the
platform code hide 'selftest' sysfs attribute instead of returning error
when someone tries to use it.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We need to make sure we have time/work initialized before requesting and
enabling interrupts, otherwise we might start using them way too early.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We know what bus we are residing on (SPI) so let's make this data
available to the users.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Set up SPI device as parent of the input device so it gets placed into
proper place in sysfs tree.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

We should not leave garbage pointers in driver structure after we unbind
it from the device or if bind fails.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Add proper module description so that it would show in 'modinfo'
output.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

The boot process is noisy as it is and input core already announces
all new device so let's get rid of the banner message in the driver.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

TSC2005 is not a platform driver so it should not define "platform:tsc2005"
module alias.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Newer code should not be using legacy suspend/resume methods but
rather supply dev_pm_ops structure as it allows better control
over power management.
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Instead of peeking into underlying device and using dev_get/set_drvdata(),
let's use SPI layer's implementation to access driver-private data
(which may be different from driver-core private data).
Tested-by: NAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Discussions:

http://www.mail-archive.com/linux-omap@vger.kernel.org/msg26748.html

Introduce a driver for the Texas Instruments TSC2005 touchscreen
controller (http://focus.ti.com/docs/prod/folders/print/tsc2005.html).

The patch is based on a driver by Lauri Leukkunen, with modifications
by David Brownell, Phil Carmody, Imre Deak, Hiroshi DOYU, Ari Kauppi,
Tony Lindgren, Jarkko Nikula, Eero Nurkkala and Roman Tereshonkov.
Signed-off-by: NLauri Leukkunen <lauri.leukkunen@nokia.com>
[aaro.koskinen@nokia.com: patch description, rebasing & cleanup]
Signed-off-by: NAaro Koskinen <aaro.koskinen@nokia.com>
[ext-srikar.1.bhavanarayana@nokia.com: various fixes]
Signed-off-by: NSrikar <ext-srikar.1.bhavanarayana@nokia.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

drivers/input is reserved for input core code and input handlers with
drivers belonging to one of the sub-directories.
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

Without a grant reference, full access to the domain's memory is
required to use the shared page. Add an additional parameter in
xenstore to allow grant mapping to be used.
Signed-off-by: NDaniel De Graaf <dgdegra@tycho.nsa.gov>
Signed-off-by: NKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: NIan Campbell <Ian.Campbell@eu.citrix.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>

A virtualized display device is usually viewed with the vncviewer
application, either by 'xm vnc domU' or with vncviewer localhost:port.
vncviewer and the RFB protocol provides absolute coordinates to the
virtual display. These coordinates are either passed through to a PV
guest or converted to relative coordinates for a HVM guest.

A PV guest receives these coordinates and passes them to the kernels
evdev driver. There it can be picked up by applications such as the
xorg-input drivers. Using absolute coordinates avoids issues such as
guest mouse pointer not tracking host mouse pointer due to wrong mouse
acceleration settings in the guests X display.

Advertise either absolute or relative coordinates to the input system
and the evdev driver, depending on what dom0 provides. The xorg-input
driver prefers relative coordinates even if a devices provides both.
Signed-off-by: NOlaf Hering <olaf@aepfle.de>
Signed-off-by: NStefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>