net/bluetooth/l2cap_core.c: In function ‘l2cap_recv_frame’:
net/bluetooth/l2cap_core.c:3612:15: warning: ‘sk’ may be used uninitialized in this function
net/bluetooth/l2cap_core.c:3612:15: note: ‘sk’ was declared here

Actually the problem is in the inline function l2cap_data_channel(), we
branch to the label 'done' which tests 'sk' before we set it to anything.

Initialize it to NULL to fix this.
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Fix a regression from the L2CAP "rewrite" patches.
Purge the tx_q already happens on l2cap_chan_del() so we don't need it at
l2cap_disconnect_req().
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

l2cap_get_sock_by_scid was changed to not lock the socket anymore, but I
forgot to change all the users of this function.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Fix an locking issue with the new l2cap_att_channel(). l2cap_att_channel()
was trying to lock a locked socket.
Reported-by: NAnderson Lizardo <anderson.lizardo@openbossa.org>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Despite it works, handling through l2cap_data_channel() is wrongs.
That function should handle only connection oriented data.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

tx_q is the queue used by ERTM mode.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

That was unnecessary use of it.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Change some BT_DBG messages and consequently remove some struct sock
declarations.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of moving all the Channel related operation to struct l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

This is a regression acctually, caused by the first patch series for
creating a formal strcut l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel stuff to l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel stuff to l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

This also triggered a change in l2cap_send_disconn_req() parameters.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel stuff to l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel stuff to l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel stuff to l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As part of the moving channel to stuff to struct l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

This is part of "moving things to l2cap_chan". As one the first move it
triggered a big number of changes in the funcions parameters, basically
changing the struct sock param to struct l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Move some channel specific stuff to l2cap_core.c, this will make things
more clear.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

They are also l2cap_chan specific.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

ident is chan property, no need to reside on socket.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

As we use struct list_head to keep L2CAP channels list the workaround with
del_list is not needed anymore.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Use a well known Kernel API is always a good idea than implement your own
list.
In the future we might use RCU on this list.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

struct l2cap_chan cames to create a clear separation between what
properties and data belongs to the L2CAP channel and what belongs to the
socket. By now we just fold the struct sock * in struct l2cap_chan as all
the channel info is struct l2cap_pinfo today.

In the next commits we will see a move of channel stuff to struct
l2cap_chan.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

This patch lets 'l2cap_pinfo.unacked_frames' be incremented only
the first time a frame is transmitted.

Previously it was being incremented for retransmitted packets
too resulting the value to cross the transmit window size.
Signed-off-by: NSuraj Sumangala <suraj@atheros.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Information requests/responses are unbound to L2CAP channel. Patch
fixes issue arising when two devices connects at the same time to
each other. This way we do not process out of the context messages.
We are safe dropping info_rsp since info_timer is left running.
Signed-off-by: NAndrei Emeltchenko <andrei.emeltchenko@nokia.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

bt_accept_enqueue() is not really a channel action, so do it outside.
This patch is part of a set of patches to create an struct l2cap_chan to
have a clear separation between the struct sock and the L2CAP channel
stuff.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

This patch lets 'l2cap_pinfo.unacked_frames' be incremented only
the first time a frame is transmitted.

Previously it was being incremented for retransmitted packets
too resulting the value to cross the transmit window size.
Signed-off-by: NSuraj Sumangala <suraj@atheros.com>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Use ERR_PTR mechanism to return error from hci_connect.
Signed-off-by: NVille Tervo <ville.tervo@nokia.com>
Signed-off-by: NAnderson Briglia <anderson.briglia@openbossa.org>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

The message for the initialization of the L2CAP layer was being
printed twice.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

If the new connection update parameter are accepted, the LE master
host sends the LE Connection Update Command to its controller informing
the new requested parameters.
Signed-off-by: NClaudio Takahasi <claudio.takahasi@openbossa.org>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Implements L2CAP Connection Parameter Update Response defined in
the Bluetooth Core Specification, Volume 3, Part A, section 4.21.
Address the LE Connection Parameter Procedure initiated by the slave.

Connection Interval Minimum and Maximum have the same range: 6 to
3200. Time = N * 1.25ms. Minimum shall be less or equal to Maximum.
The Slave Latency field shall have a value in the range of 0 to
((connSupervisionTimeout / connIntervalMax) - 1). Latency field shall
be less than 500. connSupervisionTimeout = Timeout Multiplier * 10 ms.
Multiplier field shall have a value in the range of 10 to 3200.
Signed-off-by: NClaudio Takahasi <claudio.takahasi@openbossa.org>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

This patch splits the L2CAP command handling function in order to
have a clear separation between the commands related to BR/EDR and
LE. Commands and responses in the LE signaling channel are not being
handled yet, command reject is sent to all received requests. Bluetooth
Core Specification, Volume 3, Part A, section 4 defines the signaling
packets formats and allowed commands/responses over the LE signaling
channel.
Signed-off-by: NClaudio Takahasi <claudio.takahasi@openbossa.org>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Add support for LE server sockets.
Signed-off-by: NVille Tervo <ville.tervo@nokia.com>
Acked-by: NMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Add basic LE connection support to L2CAP. LE
connection can be created by specifying cid
in struct sockaddr_l2
Signed-off-by: NVille Tervo <ville.tervo@nokia.com>
Acked-by: NMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

l2cap_load() was added to trigger l2cap.ko module loading from the RFCOMM
and BNEP modules. Now that L2CAP module is gone, we don't need it anymore.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>

Actually doesn't make sense have these modules built separately.
The L2CAP layer is needed by almost all Bluetooth protocols and profiles.
There isn't any real use case without having L2CAP loaded.
SCO is only essential for Audio transfers, but it is so small that we can
have it loaded always in bluetooth.ko without problems.
If you really doesn't want it you can disable SCO in the kernel config.
Signed-off-by: NGustavo F. Padovan <padovan@profusion.mobi>