1. 18 5月, 2010 1 次提交
  2. 06 5月, 2010 2 次提交
    • J
      [SCSI] Retry commands with UNIT_ATTENTION sense codes to fix ext3/ext4 I/O error · 77a42297
      James Bottomley 提交于
      There's nastyness in the way we currently handle barriers (and
      discards): They're effectively filesystem commands, but they get
      processed as BLOCK_PC commands.  Unfortunately BLOCK_PC commands are
      taken by SCSI to be SG_IO commands and the issuer expects to see and
      handle any returned errors, however trivial.  This leads to a huge
      problem, because the block layer doesn't expect this to happen and any
      trivially retryable error on a barrier causes an immediate I/O error
      to the filesystem.
      
      The only real way to hack around this is to take the usual class of
      offending errors (unit attentions) and make them all retryable in the
      case of a REQ_HARDBARRIER.  A correct fix would involve a rework of
      the entire block and SCSI submit system, and so is out of scope for a
      quick fix.
      
      Cc: Hannes Reinecke <hare@suse.de>
      Cc: Stable Tree <stable@kernel.org>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      77a42297
    • H
      [SCSI] Enable retries for SYNCRONIZE_CACHE commands to fix I/O error · c213e140
      Hannes Reinecke 提交于
      Some arrays are giving I/O errors with ext3 filesystems when
      SYNCHRONIZE_CACHE gets a UNIT_ATTENTION.  What is happening is that
      these commands have no retries, so the UNIT_ATTENTION causes the
      barrier to fail.  We should be enable retries here to clear any
      transient error and allow the barrier to succeed.
      Signed-off-by: NHannes Reinecke <hare@suse.de>
      Cc: Stable Tree <stable@kernel.org>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      c213e140
  3. 02 5月, 2010 3 次提交
  4. 01 5月, 2010 1 次提交
  5. 23 4月, 2010 1 次提交
  6. 12 4月, 2010 4 次提交
  7. 09 4月, 2010 4 次提交
  8. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  9. 28 3月, 2010 10 次提交
  10. 16 3月, 2010 1 次提交
  11. 15 3月, 2010 1 次提交
  12. 13 3月, 2010 1 次提交
  13. 09 3月, 2010 2 次提交
    • M
      qlogicpti: Remove slash in QlogicPTI irq name · 77d39263
      Meelis Roos 提交于
      qlogicpti driver registers its irq with a name containing slash.
      This results in 
      
      [   71.049735] WARNING: at fs/proc/generic.c:316 __xlate_proc_name+0xa8/0xb8()
      [   71.132815] name 'Qlogic/PTI'
      
      because proc_mkdir with the name of the irq fails. Fix it by just 
      removing the slash from irq name. Discovered and tested on real hardware 
      (Sun Ultra 1).
      Signed-off-by: NMeelis Roos <mroos@linux.ee>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      77d39263
    • G
      [SCSI] scsi_transport_fc: Fix synchronization issue while deleting vport · 0d9dc7c8
      Gal Rosen 提交于
      The issue occur while deleting 60 virtual ports through the sys
      interface /sys/class/fc_vports/vport-X/vport_delete. It happen while in
      a mistake each request sent twice for the same vport. This interface is
      asynchronous, entering the delete request into a work queue, allowing
      more than one request to enter to the delete work queue. The result is a
      NULL pointer. The first request already delete the vport, while the
      second request got a pointer to the vport before the device destroyed.
      Re-create vport later cause system freeze.
      
      Solution: Check vport flags before entering the request to the work queue.
      
      [jejb: fixed int<->long problem on spinlock flags variable]
      Signed-off-by: NGal Rosen <galr@storwize.com>
      Acked-by: NJames Smart <james.smart@emulex.com>
      Cc: Stable Tree <stable@kernel.org>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      0d9dc7c8
  14. 08 3月, 2010 1 次提交
    • U
      platform-drivers: move probe to .devinit.text in drivers/scsi · 1b07193b
      Uwe Kleine-König 提交于
      A pointer to a probe callback is passed to the core via
      platform_driver_register and so the function must not disappear when the
      .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
      unbinding and binding a device to the driver via sysfs will result in an
      oops as does a device being registered late.
      
      An alternative to this patch is using platform_driver_probe instead of
      platform_driver_register plus removing the pointer to the probe function
      from the struct platform_driver.
      Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: David Brownell <dbrownell@users.sourceforge.net>
      Cc: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
      Cc: Henrik Kretzschmar <henne@nachtwindheim.de>
      Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
      Cc: Kay Sievers <kay.sievers@vrfy.org>
      Cc: peter fuerst <post@pfrst.de>
      Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
      Acked-by: NRalf Baechle <ralf@linux-mips.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      1b07193b
  15. 07 3月, 2010 7 次提交