1. 11 5月, 2012 1 次提交
    • J
      drivers/net: Convert compare_ether_addr to ether_addr_equal · 2e42e474
      Joe Perches 提交于
      Use the new bool function ether_addr_equal to add
      some clarity and reduce the likelihood for misuse
      of compare_ether_addr for sorting.
      
      Done via cocci script:
      
      $ cat compare_ether_addr.cocci
      @@
      expression a,b;
      @@
      -	!compare_ether_addr(a, b)
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	compare_ether_addr(a, b)
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!ether_addr_equal(a, b) == 0
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!ether_addr_equal(a, b) != 0
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	ether_addr_equal(a, b) == 0
      +	!ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	ether_addr_equal(a, b) != 0
      +	ether_addr_equal(a, b)
      
      @@
      expression a,b;
      @@
      -	!!ether_addr_equal(a, b)
      +	ether_addr_equal(a, b)
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2e42e474
  2. 27 3月, 2012 2 次提交
    • S
      iwlegacy: fix BSSID setting · e92109be
      Stanislaw Gruszka 提交于
      Current commit 0775f9f9
      "mac80211: remove spurious BSSID change flag" exposed bug on iwlegacy,
      that we do not set BSSID address correctly and then device was not able
      to receive frames after successful associate.
      
      On the way fix scan canceling comment. Apparently ->post_associate()
      do cancel scan itself, but scan cancel on BSS_CHANGED_BSSID is needed.
      I'm not sure why, but when I removed it, I had frequent auth failures:
      
       wlan4: send auth to 54:e6:fc:98:63:fe (try 1/3)
       wlan4: send auth to 54:e6:fc:98:63:fe (try 2/3)
       wlan4: send auth to 54:e6:fc:98:63:fe (try 3/3)
       wlan4: authentication with 54:e6:fc:98:63:fe timed out
      Signed-off-by: NStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      e92109be
    • S
      iwlegacy: do not nulify il->vif on reset · 883a649b
      Stanislaw Gruszka 提交于
      This il->vif is dereferenced in different part of iwlegacy code, so do
      not nullify it. This should fix random crashes observed in companion
      with microcode errors i.e. crash in il3945_config_ap().
      
      Additionally this should address also
      WARNING: at drivers/net/wireless/iwlegacy/common.c:4656 il_mac_remove_interface
      at least one of the possible reasons of that warning.
      
      Cc: stable@vger.kernel.org
      Signed-off-by: NStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      883a649b
  3. 14 3月, 2012 1 次提交
  4. 23 2月, 2012 15 次提交
  5. 07 2月, 2012 17 次提交
  6. 05 1月, 2012 1 次提交
    • S
      iwlegacy: move some i/o helpers out of inline · 17d4eca6
      Stanislaw Gruszka 提交于
      This save us about 20k of text size, and should have no impact on
      performance as hot paths do not use much I/O.
      
      Before:
         text	   data	    bss	    dec	    hex	filename
       108512	   1784	    168	 110464	  1af80	drivers/net/wireless/iwlegacy/iwl3945.ko
       165730	   2164	    156	 168050	  29072	drivers/net/wireless/iwlegacy/iwl4965.ko
        91942	    328	     48	  92318	  1689e	drivers/net/wireless/iwlegacy/iwlegacy.ko
      
      After:
         text	   data	    bss	    dec	    hex	filename
        95556	   1784	    168	  97508	  17ce4	drivers/net/wireless/iwlegacy/iwl3945.ko
       154853	   2164	    156	 157173	  265f5	drivers/net/wireless/iwlegacy/iwl4965.ko
        91634	    328	     48	  92010	  1676a	drivers/net/wireless/iwlegacy/iwlegacy.ko
      Signed-off-by: NStanislaw Gruszka <sgruszka@redhat.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      17d4eca6
  7. 07 12月, 2011 1 次提交
  8. 15 11月, 2011 2 次提交