提交 · bdc01d5711b33444a23dde3334cc24a0fe97d917 · openeuler / raspberrypi-kernel

08 5月, 2015 40 次提交

staging: rtl8192u: Make core functions static · bdc01d57

由 Nickolaus Woodruff 提交于 4月 12, 2015

This patch fixes the following sparse warnings in r8192U_core.c:

  CHECK   drivers/staging/rtl8192u/r8192U_core.c
drivers/staging/rtl8192u/r8192U_core.c:3212:6: warning: symbol
'rtl819x_watchdog_wqcallback' was not declared. Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:3276:6: warning: symbol
'watch_dog_timer_callback' was not declared. Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:3282:5: warning: symbol
'_rtl8192_up' was not declared. Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:3333:5: warning: symbol
'rtl8192_close' was not declared. Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:3406:6: warning: symbol
'rtl8192_restart' was not declared. Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:4618:6: warning: symbol
'rtl8192_irq_rx_tasklet' was not declared. Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:4736:6: warning: symbol
'rtl8192_cancel_deferred_work' was not declared. Should it be static?
Signed-off-by: NNickolaus Woodruff <nickolauswoodruff@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

bdc01d57

staging: comedi: mite: use a better MODULE_DESCRIPTION() · 3ad94703

由 Ian Abbott 提交于 5月 01, 2015

Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

3ad94703

staging: comedi: mite.h: whitespace changes in function declarations · f2348c73

由 Ian Abbott 提交于 5月 01, 2015

Reformat some function declarations to avoid bunching up near column 80.

Also add a blank line after a `struct` definition.
Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

f2348c73

staging: comedi: mite.c: reformat comments · 65f6fac9

由 Ian Abbott 提交于 5月 01, 2015

Use the usual style for block comments.  Squash double spaces after
comment opening sequences.
Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

65f6fac9

staging: comedi: mite.h: reformat some comments · f751a0d5

由 Ian Abbott 提交于 5月 01, 2015

Use the usual style for block comments.  Squash double spaces after
comment opening sequences.
Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

f751a0d5

staging: comedi: mite.h: remove "../comedi_pci.h" and make self-reliant · c95f212d

由 Ian Abbott 提交于 5月 01, 2015

"mite.h" relies on a lot of things declared including "../comedi_pci.h",
but doesn't need anything in "../comedi_pci.h" itself. None of the
Comedi modules that include "mite.h" rely on it to include
"../comedi_pci.h" on their behalf.

Remove the inclusion of "../comedi_pci.h" from "mite.h", and add enough
other includes and (incomplete) `struct` declarations to make it compile
without warnings or errors even when included first in a .c file.
Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

c95f212d

staging: comedi: mite.c: remove commented out USE_KMALLOC · c0cb606a

由 Ian Abbott 提交于 5月 01, 2015

The definition of the macro `USE_KMALLOC` is commented out, and nothing
refers to it.  Remove the commented out macro.
Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

c0cb606a

staging: comedi: mite.h: remove PCIMIO_COMPAT · 5f7c6822

由 Ian Abbott 提交于 5月 01, 2015

The macro `PCIMIO_COMPAT` is defined, but never used.  Remove it.
Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

5f7c6822

staging: comedi: mite: move #include <linux/slab.h> · 272b1ae5

由 Ian Abbott 提交于 5月 01, 2015

The Comedi driver modules build fine if the inclusion of <linux/slab.h>
is removed from "mite.h", so remove it.  However, since "mite.c" calls
`kzalloc()`, include <linux/slab.h> there.
Signed-off-by: NIan Abbott <abbotti@mev.co.uk>
Reviewed-by: NH Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

272b1ae5

staging: dgnc: remove redundant check · eef94f6b

由 Giedrius Statkevičius 提交于 4月 10, 2015

count doesn't get changed in between identical checks in
dgnc_tty_write() so remove the second check
Signed-off-by: NGiedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

eef94f6b

staging: dgnc: remove dead code in dgnc_tty_write() · a74d8e21

由 Giedrius Statkevičius 提交于 4月 10, 2015

Remove the dead code protected by in_user in dgnc_tty_write() because it
is set to 0 and never changed to 1 thus the code in ifs never gets
executed.
Signed-off-by: NGiedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

a74d8e21

staging: ion: chunk_heap: use pr_debug for heap creation print · dc44f4e1

由 Mitchel Humpherys 提交于 4月 09, 2015

We're currently printing to the kernel log at `info' level when we
successfully create the chunk heap, but success messages should be done
at `debug' level.  Fix this.
Signed-off-by: NMitchel Humpherys <mitchelh@codeaurora.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

dc44f4e1

staging: dgnc: remove redundant !ch checks · 071494d8

由 Giedrius Statkevičius 提交于 4月 10, 2015

Remove checks that are redundant since we don't have boards with partially
initialized ->channels[i].
Signed-off-by: NGiedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

071494d8

staging: dgnc: don't forget to check if ->channels[i] is NULL in dgnc_tty_uninit() · ce2927e9

由 Giedrius Statkevičius 提交于 4月 10, 2015

Add a check if ->channels[i] is NULL because a NULL pointer may be dereferenced
in case one of the allocations failed
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NGiedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

ce2927e9

staging: dgnc: clean up allocation of ->channels[i] · fa52d96c

由 Giedrius Statkevičius 提交于 4月 10, 2015

Check if kzalloc fails in dgnc_tty_init() and if it does then free all
previously allocated ->channels[i] and set them to NULL. This makes the code
less error/bug prone because instead of needing programmers attention to add
checks everywhere we do that in one place. Also, remove a bogus comment and
check in the same loop because ->channels[i] isn't allocated anywhere else.
Finally, remove a unnecessary check if ->channels[i] is NULL in the next loop
because it can't be.
Signed-off-by: NGiedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fa52d96c

Staging: sm750fb: Fix spelling error in TODO · 258f6a50

由 Robin Karlsson 提交于 4月 10, 2015

Fixed spelling error in TODO.
Signed-off-by: NRobin Karlsson <s.r.karlsson@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

258f6a50

Staging: sm750fb: Remove space after parenthesis · 31296ba5

由 Amitoj Kaur Chawla 提交于 4月 08, 2015

Fixed error by removing space after open parenthesis '('
Problem found using checkpatch.pl
ERROR: space prohibited after that open parenthesis '('
Signed-off-by: NAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

31296ba5

staging: dgnc: remove some dead code from dgnc_tty.c · 86b4e7e2

由 Giedrius Statkevičius 提交于 4月 08, 2015

Remove some dead code that will never be executed or which serves no purpose
Signed-off-by: NGiedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

86b4e7e2

Staging: fixed multiple spelling errors. · 69e98df7

由 Carlos E. Garcia 提交于 4月 24, 2015

Fixed multiple spelling errors.
Signed-off-by: NCarlos E. Garcia <carlos@cgarcia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

69e98df7

drivers: staging: fbtft: fbtft-bus.c: Fix different address space warning on I/O mem · 02eb884f

由 Tolga Ceylan 提交于 5月 01, 2015

To fix sparse warning of incorrect type in assignment
(different address space), added annotation __iomem to
vmem8 and modified direct reads with ioread8().
Signed-off-by: NTolga Ceylan <tolga.ceylan@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

02eb884f

staging/lustre/ptlrpc: Replace OBD_CPT_ALLOC etc by kzalloc_node · bae97e81

由 Julia Lawall 提交于 5月 03, 2015

Replace OBD_CPT_ALLOC, OBD_CPT_ALLOC_PTR, and OBD_CPT_ALLOC_GFP by
corresponding calls to kzalloc_node.  The semantic patch for the
OBD_CPT_ALLOC case is as follows: (http://coccinelle.lip6.fr/).

// <smpl>
@@ expression ptr,cptab,cpt,size; @@
- OBD_CPT_ALLOC(ptr, cptab, cpt, size)
+ ptr = kzalloc_node(size, GFP_NOFS, cfs_cpt_spread_node(cptab, cpt))
// </smpl>

Note that the original OBD macros would check if the cptab argument was
NULL and fall back on kzalloc in that case.  Oleg Drokin argues that this
test is not needed because the code containing these calls is only invoked
after initialization has been completed, in which case the possible cptab
arguments are not NULL.
Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

bae97e81

drivers: staging: lustre: lustre: Replace OBD_CPT_ALLOC etc by kzalloc_node · b18d1100

由 Julia Lawall 提交于 5月 03, 2015

Replace OBD_CPT_ALLOC, OBD_CPT_ALLOC_PTR, and OBD_CPT_ALLOC_GFP by
corresponding calls to kzalloc_node.  The semantic patch for the
OBD_CPT_ALLOC case is as follows: (http://coccinelle.lip6.fr/).

// <smpl>
@@ expression ptr,cptab,cpt,size; @@
- OBD_CPT_ALLOC(ptr, cptab, cpt, size)
+ ptr = kzalloc_node(size, GFP_NOFS, cfs_cpt_spread_node(cptab, cpt))
// </smpl>

Note that the original OBD macros would check if the cptab argument was
NULL and fall back on kzalloc in that case.  Oleg Drokin argues that this
test is not needed because the code containing these calls is only invoked
after initialization has been completed, in which case the possible cptab
arguments are not NULL.
Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

b18d1100

staging: lustre: ptlrpc: Replace OBD_CPT_ALLOC etc by kzalloc_node · e3bf447a

由 Julia Lawall 提交于 5月 03, 2015

Replace OBD_CPT_ALLOC, OBD_CPT_ALLOC_PTR, and OBD_CPT_ALLOC_GFP by
corresponding calls to kzalloc_node.  The semantic patch for the
OBD_CPT_ALLOC case is as follows: (http://coccinelle.lip6.fr/).

// <smpl>
@@ expression ptr,cptab,cpt,size; @@
- OBD_CPT_ALLOC(ptr, cptab, cpt, size)
+ ptr = kzalloc_node(size, GFP_NOFS, cfs_cpt_spread_node(cptab, cpt))
// </smpl>

Note that the original OBD macros would check if the cptab argument was
NULL and fall back on kzalloc in that case.  Oleg Drokin argues that this
test is not needed because the code containing these calls is only invoked
after initialization has been completed, in which case the possible cptab
arguments are not NULL.
Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

e3bf447a

staging: lustre: ptlrpc: service: remove unneeded null test before free · 207e99c2