Since the mode search is not string-based anymore, we can drop XxYx24
entries which were just duplicated XxYx32 entries.
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Eliminate string comparison from the video mode search.
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The default rate_idx is same for all video modes, no need to keep that
in the table.
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Delete unused table.
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

XG45 is not recognized/supported by the driver.
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

XG_41 is not listed in xgifb_pci_table, so the code can be safely dropped.
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Initialize ModeIdIndex according to the selected video mode. Currently
index 0 is always used and wrong clock data may be used.
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Delete code that has been commented out.
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Initialize ModeIdIndex according to the selected video mode. Currently
index 0 is always used and wrong video mode data may be used.
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Delete code that has been commented out.
Signed-off-by: NAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Some platforms (e.g. ppc460ex) have 36-bit physical addressing, while
sizeof(unsigned long) == 4. Adapt xgifb driver to use phys_addr_t for
physical address variables instead of unsigned long.
Signed-off-by: NDmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

XGIfb driver transfers integer port number through several typecasts via
pjIOAddress field. Drop that field completely and use vga_base field of
xgifb_info directly.
Signed-off-by: NDmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The RelIO field is unused in the driver, drop it.
Signed-off-by: NDmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

In function XGIfb_do_set_var() remove unused variable sr_data.
Signed-off-by: NDmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NChristopher Harvey <charvey@matrox.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This doesn't happen with the usbip virtual hci module, but another
module wanting to interface with this user space code could cause a
seg-fault by sending data without newlines.
Signed-off-by: NChristopher Harvey <charvey@matrox.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace kmalloc+memset pair by kzalloc() in 'wl_wds_device_alloc()'.
Add error handling to avoid null derefernce.
Signed-off-by: NSantosh Nayak <santoshprasadnayak@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch changes the space of the indent to the tab that warning
found by the checkpatch.pl tool.

Signed-off-by: Hitoshi NAKAMORI<hitoshi.nakamori@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The below patch is a resend to fix some typos and comments that
I have found while reading.
Signed-off-by: NJustin P. Mattock <justinmattock@gmail.com>
Acked-by: NDavid Daney <david.daney@cavium.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Nwwang <wei_wang@realsil.com.cn>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Minor error path clean-up.
Signed-off-by: NRob Clark <rob@ti.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch replaces existing event logging mechanism from ioctl to debugfs.
This patch replaces previous patch submitted by Chris Kelly. Previous patch can
be found at :-
http://article.gmane.org/gmane.linux.usb.general/60026/Signed-off-by: NRupesh Gujare <rgujare@ozmodevices.com>
Signed-off-by: NChris Kelly <ckelly@ozmodevices.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

1. use wd: prefix for all messages
2. fix strings
3. change from dev_dbg to dev_err where appropriate
Signed-off-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The function has returned false in both error and success
cases.

1. change return value to int and return appropriate errno
2. use typical Linux kernel error handling.
3. normalize debug messages
Signed-off-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

1. use only mei_driver_name and remove define MEI_DRIVER_NAME
2. drop MEI_DEV_NAME and assign device name directly
3. drop mei_driver_string, it is not used
Signed-off-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fix sparse warning:
'amt_wd_dev' was not declared. Should it be static
Signed-off-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

one instance of bare printk was forgotten in init.c file
Signed-off-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

mei_wd_set_start_timeout is only used from within wd.c
so remove its declaration from interface.h and mark
it static
Signed-off-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

define pr_fmt macro and remove mei: from the messages
Signed-off-by: NTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The below patch fixes a typo that I found while reading.
Signed-off-by: NJustin P. Mattock <justinmattock@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The below patch fixes a typo I found while reading.
Signed-off-by: NJustin P. Mattock <justinmattock@gmail.com>
Cc: Willy Tarreau <willy@meta-x.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The below patch fixes a typo I found while reading.
Signed-off-by: NJustin P. Mattock <justinmattock@gmail.com>
Cc: Andres Salomon <dilinger@queued.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The below patch fixes a typo that I found while reading.
Signed-off-by: NJustin P. Mattock <justinmattock@gmail.com>
Acked-by: NChris Kelly <ckelly@ozmodevices.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The below patch fixes a typo I found while reading.
Signed-off-by: NJustin P. Mattock <justinmattock@gmail.com>
Cc: Julian Andres Klode <jak@jak-linux.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

stub_shutdown_connection() and vhci_shutdown_connection() use
task_is_dead() before kthread_stop(). This buys nothing and wrong.
kthread_stop() is fine even if this thread is dead. However, if it
is dead nothing protects this task_struct, we shouldn't touch this
memory.

Change the code to do the necessary get_task_struct/put_task_struct.

This patch assumes that

	- xxx_shutdown_connection() is always called, so we can't
	  leak the task_struct.

	- kthread_stop_put() can't be called twice on the same task.
Signed-off-by: NOleg Nesterov <oleg@redhat.com>
Cc: Tobias Klauser <tklauser@distanz.ch>
Cc: Matt Mooney <mfm@muteddisk.com>,
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

In drivers/staging/rtl8192e/rtl8192e/rtl_core.c the follwing printk-message can be found:

printk(KERN_ERR "rtl8193e: Unable to allocate space "

This is quite obviously just a typo, all other similar messages use
"rtl8192e" and the string "rtl8193e" does not occur anywhere else in the
source of the driver.
Signed-off-by: NAxel Koellhofer <AxelKoellhofer@web.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Reformated comment blocks to meet Coding Style
Signed-off-by: NAndrew Miller <amiller@amilx.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Removed some old comments and a few blank lines
Signed-off-by: NAndrew Miller <amiller@amilx.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix some more spacing issues I missed before
Signed-off-by: NAndrew Miller <amiller@amilx.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>