1. 15 8月, 2010 2 次提交
    • J
      hwmon: (pc87360) Fix device resource declaration · b9783dce
      Jean Delvare 提交于
      It's not OK to call platform_device_add_resources() multiple times
      in a row. Despite its name, this functions sets the resources, it
      doesn't add them. So we have to prepare an array with all the
      resources, and then call platform_device_add_resources() once.
      
      Before this fix, only the last I/O resource would be actually
      registered. The other I/O resources were leaked.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Cc: Jim Cromie <jim.cromie@gmail.com>
      Cc: stable@kernel.org
      b9783dce
    • J
      hwmon: (k8temp) Adjust confusing if indentation · df149d02
      Julia Lawall 提交于
      Move the if(err) statement after the if into the if branch indicated by its
      indentation.  The preceding if(err) test implies that err cannot be nonzero
      unless the if branch is taken.
      
      The semantic match that finds this problem is as follows:
      (http://coccinelle.lip6.fr/)
      
      // <smpl>
      @r disable braces5@
      position p1,p2;
      statement S1,S2;
      @@
      
      (
      if (...) { ... }
      |
      if (...) S1@p1 S2@p2
      )
      
      @script:python@
      p1 << r.p1;
      p2 << r.p2;
      @@
      
      if (p1[0].column == p2[0].column):
       cocci.print_main("branch",p4)
       cocci.print_secs("after",p5)
      // </smpl>  
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      df149d02
  2. 14 8月, 2010 38 次提交