Skip to content

R
raspberrypi-kernel

openeuler / raspberrypi-kernel

通知 13
Star 1
Fork 0
R
raspberrypi-kernel
切换分支/标签
  1. 14 10月, 2012 1 次提交
    • R
      ARM: config: sort select statements alphanumerically · b1b3f49c
      由 Russell King 提交于 
      As suggested by Andrew Morton:

  This is a pet peeve of mine.  Any time there's a long list of items
  (header file inclusions, kconfig entries, array initalisers, etc) and
  someone wants to add a new item, they *always* go and stick it at the
  end of the list.

  Guys, don't do this.  Either put the new item into a randomly-chosen
  position or, probably better, alphanumerically sort the list.

lets sort all our select statements alphanumerically.  This commit was
created by the following perl:

while (<>) {
	while (/\\\s*$/) {
		$_ .= <>;
	}
	undef %selects if /^\s*config\s+/;
	if (/^\s+select\s+(\w+).*/) {
		if (defined($selects{$1})) {
			if ($selects{$1} eq $_) {
				print STDERR "Warning: removing duplicated $1 entry\n";
			} else {
				print STDERR "Error: $1 differently selected\n".
					"\tOld: $selects{$1}\n".
					"\tNew: $_\n";
				exit 1;
			}
		}
		$selects{$1} = $_;
		next;
	}
	if (%selects and (/^\s*$/ or /^\s+help/ or /^\s+---help---/ or
			  /^endif/ or /^endchoice/)) {
		foreach $k (sort (keys %selects)) {
			print "$selects{$k}";
		}
		undef %selects;
	}
	print;
}
if (%selects) {
	foreach $k (sort (keys %selects)) {
		print "$selects{$k}";
	}
}

It found two duplicates:

Warning: removing duplicated S5P_SETUP_MIPIPHY entry
Warning: removing duplicated HARDIRQS_SW_RESEND entry

and they are identical duplicates, hence the shrinkage in the diffstat
of two lines.

We have four testers reporting success of this change (Tony, Stephen,
Linus and Sekhar.)
Acked-by: NJason Cooper <jason@lakedaemon.net>
Acked-by: NTony Lindgren <tony@atomide.com>
Acked-by: NStephen Warren <swarren@nvidia.com>
Acked-by: NLinus Walleij <linus.walleij@linaro.org>
Acked-by: NSekhar Nori <nsekhar@ti.com>
Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      b1b3f49c
  3. 29 9月, 2012 5 次提交
  5. 01 8月, 2012 1 次提交
  7. 18 7月, 2012 3 次提交
  9. 16 5月, 2012 1 次提交
  11. 15 5月, 2012 3 次提交
  13. 14 5月, 2012 1 次提交
  15. 11 5月, 2012 1 次提交
  17. 31 3月, 2012 1 次提交
  19. 29 3月, 2012 1 次提交
  21. 07 3月, 2012 2 次提交
  23. 22 2月, 2012 1 次提交
  25. 21 1月, 2012 2 次提交
  27. 05 1月, 2012 2 次提交
  29. 27 11月, 2011 1 次提交
  31. 21 11月, 2011 1 次提交
  33. 18 11月, 2011 1 次提交
  35. 17 10月, 2011 2 次提交
  37. 26 9月, 2011 1 次提交
  39. 22 8月, 2011 1 次提交
  41. 29 3月, 2011 2 次提交
  43. 18 2月, 2011 1 次提交
  45. 31 1月, 2011 1 次提交
  47. 14 1月, 2011 1 次提交
  49. 22 11月, 2010 1 次提交
  51. 20 10月, 2010 2 次提交