1. 02 12月, 2006 2 次提交
  2. 29 11月, 2006 1 次提交
    • T
      [PATCH] ahci: ignore PORT_IRQ_IF_ERR on JMB controllers · 41669553
      Tejun Heo 提交于
      JMicron AHCI controllers set PORT_IRQ_IF_ERR on device errors.  The
      IRQ status bit indicates interface error or protocol mismatch and ahci
      driver interprets it into AC_ERR_ATA_BUS.  So, whenever an ATAPI
      device raises check condition, ahci interprets it as ATA bus error and
      thus resets it which, in turn, raises check condition thus creating a
      reset loop and rendering the device unuseable.
      
      This patch makes JMB controllers ignore PORT_IRQ_IF_ERR when
      interpreting error condition.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      Cc: Justin Tsai <justin@jmicron.com>
      41669553
  3. 28 11月, 2006 1 次提交
  4. 03 11月, 2006 1 次提交
  5. 01 11月, 2006 1 次提交
  6. 22 10月, 2006 1 次提交
  7. 05 10月, 2006 1 次提交
    • D
      IRQ: Maintain regs pointer globally rather than passing to IRQ handlers · 7d12e780
      David Howells 提交于
      Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
      of passing regs around manually through all ~1800 interrupt handlers in the
      Linux kernel.
      
      The regs pointer is used in few places, but it potentially costs both stack
      space and code to pass it around.  On the FRV arch, removing the regs parameter
      from all the genirq function results in a 20% speed up of the IRQ exit path
      (ie: from leaving timer_interrupt() to leaving do_IRQ()).
      
      Where appropriate, an arch may override the generic storage facility and do
      something different with the variable.  On FRV, for instance, the address is
      maintained in GR28 at all times inside the kernel as part of general exception
      handling.
      
      Having looked over the code, it appears that the parameter may be handed down
      through up to twenty or so layers of functions.  Consider a USB character
      device attached to a USB hub, attached to a USB controller that posts its
      interrupts through a cascaded auxiliary interrupt controller.  A character
      device driver may want to pass regs to the sysrq handler through the input
      layer which adds another few layers of parameter passing.
      
      I've build this code with allyesconfig for x86_64 and i386.  I've runtested the
      main part of the code on FRV and i386, though I can't test most of the drivers.
      I've also done partial conversion for powerpc and MIPS - these at least compile
      with minimal configurations.
      
      This will affect all archs.  Mostly the changes should be relatively easy.
      Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
      
      	struct pt_regs *old_regs = set_irq_regs(regs);
      
      And put the old one back at the end:
      
      	set_irq_regs(old_regs);
      
      Don't pass regs through to generic_handle_irq() or __do_IRQ().
      
      In timer_interrupt(), this sort of change will be necessary:
      
      	-	update_process_times(user_mode(regs));
      	-	profile_tick(CPU_PROFILING, regs);
      	+	update_process_times(user_mode(get_irq_regs()));
      	+	profile_tick(CPU_PROFILING);
      
      I'd like to move update_process_times()'s use of get_irq_regs() into itself,
      except that i386, alone of the archs, uses something other than user_mode().
      
      Some notes on the interrupt handling in the drivers:
      
       (*) input_dev() is now gone entirely.  The regs pointer is no longer stored in
           the input_dev struct.
      
       (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
           something different depending on whether it's been supplied with a regs
           pointer or not.
      
       (*) Various IRQ handler function pointers have been moved to type
           irq_handler_t.
      Signed-Off-By: NDavid Howells <dhowells@redhat.com>
      (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
      7d12e780
  8. 28 9月, 2006 1 次提交
  9. 31 8月, 2006 1 次提交
  10. 24 8月, 2006 1 次提交
    • J
      libata: Grand renaming. · cca3974e
      Jeff Garzik 提交于
      The biggest change is that ata_host_set is renamed to ata_host.
      
      * ata_host_set			=> ata_host
      * ata_probe_ent->host_flags	=> ata_probe_ent->port_flags
      * ata_probe_ent->host_set_flags	=> ata_probe_ent->_host_flags
      * ata_host_stats		=> ata_port_stats
      * ata_port->host		=> ata_port->scsi_host
      * ata_port->host_set		=> ata_port->host
      * ata_port_info->host_flags	=> ata_port_info->flags
      * ata_(.*)host_set(.*)\(\)	=> ata_\1host\2()
      
      The leading underscore in ata_probe_ent->_host_flags is to avoid
      reusing ->host_flags for different purpose.  Currently, the only user
      of the field is libata-bmdma.c and probe_ent itself is scheduled to be
      removed.
      
      ata_port->host is reused for different purpose but this field is used
      inside libata core proper and of different type.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      cca3974e
  11. 10 8月, 2006 2 次提交
  12. 09 8月, 2006 1 次提交
  13. 04 8月, 2006 1 次提交
  14. 29 7月, 2006 7 次提交
  15. 20 7月, 2006 1 次提交
  16. 06 7月, 2006 2 次提交
  17. 03 7月, 2006 1 次提交
  18. 27 6月, 2006 1 次提交
  19. 23 6月, 2006 3 次提交
  20. 31 5月, 2006 4 次提交
    • T
      [PATCH] ahci: convert to new probing mechanism and add hotplug support · 4296971d
      Tejun Heo 提交于
      Convert to new probing mechanism and add hotplug support by enabling
      PORT_IRQ_PHYRDY, marking ehi for hotplug and scheduling EH on
      CONNECT/PHYRDY interrupts.
      
      Unfortunately, ahci cannot reliably wait for the first D2H FIS after
      hotplug.  It sometimes succeeds but times out more often than not, so
      ATA_FLAG_SKIP_D2H_BSY is used.
      
      This patch also fixes ahci_hardreset() such that D2H Register FIS RX
      area is cleared before issuing COMRESET.  Without this,
      ata_busy_sleep() after COMRESET might prematually finish if the
      previous TF contains DRDY && !BSY.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      4296971d
    • T
      [PATCH] libata-hp: update unload-unplug · 720ba126
      Tejun Heo 提交于
      Update unload unplug - driver unloading / PCI removal.  This is done
      by ata_port_detach() which short-circuits EH, disables all devices and
      freezes the port.  With this patch, EH and unloading/unplugging are
      properly synchronized.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      720ba126
    • T
      [PATCH] libata-hp: hook warmplug · ccf68c34
      Tejun Heo 提交于
      Hook transportt->user_scan() and hostt->slave_destroy().
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      ccf68c34
    • T
      [PATCH] libata-hp-prep: add prereset() method and implement ata_std_prereset() · f5914a46
      Tejun Heo 提交于
      With hotplug, every reset might be a probing reset and thus something
      similar to probe_init() is needed.  prereset() method is called before
      a series of resets to a port and is the counterpart of postreset().
      prereset() can tell EH to use different type of reset or skip reset by
      modifying ehc->i.action.
      
      This patch also implements ata_std_prereset().  Most controllers
      should be able to use this function directly or with some wrapping.
      After hotplug, different controllers need different actions to resume
      the PHY and detect the newly attached device.  Controllers can be
      categorized as follows.
      
      * Controllers which can wait for the first D2H FIS after hotplug.
        Note that if the waiting is implemented by polling TF status, there
        needs to be a way to set BSY on PHY status change.  It can be
        implemented by hardware or with the help of the driver.
      
      * Controllers which can wait for the first D2H FIS after sending
        COMRESET.  These controllers need to issue COMRESET to wait for the
        first FIS.  Note that the received D2H FIS could be the first D2H
        FIS after POR (power-on-reset) or D2H FIS in response to the
        COMRESET.  Some controllers use COMRESET as TF status
        synchronization point and clear TF automatically (sata_sil).
      
      * Controllers which cannot wait for the first D2H FIS reliably.
        Blindly issuing SRST to spinning-up device often results in command
        issue failure or timeout, causing extended delay.  For these
        controllers, ata_std_prereset() explicitly waits ATA_SPINUP_WAIT
        (currently 8s) to give newly attached device time to spin up, then
        issues reset.  Note that failing to getting ready in ATA_SPINUP_WAIT
        is not critical.  libata will retry.  So, the timeout needs to be
        long enough to spin up most devices.
      
      LLDDs can tell ata_std_prereset() which of above action is needed with
      ATA_FLAG_HRST_TO_RESUME and ATA_FLAG_SKIP_D2H_BSY flags.  These flags
      are PHY-specific property and will be moved to ata_link later.
      
      While at it, this patch unifies function typedef's such that they all
      have named arguments.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      f5914a46
  21. 15 5月, 2006 6 次提交
    • T
      [PATCH] ahci: implement NCQ suppport · 12fad3f9
      Tejun Heo 提交于
      Implement NCQ support.
      
      Original implementation is from Jens Axboe.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      12fad3f9
    • T
      [PATCH] ahci: kill pp->cmd_tbl_sg · a9764c2b
      Tejun Heo 提交于
      With NCQ, there are multiple sg tables, so pp->cmd_tbl_sg doesn't cut
      it.  Directly calculate sg table address from pp->cmd_tbl.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      a9764c2b
    • T
      [PATCH] ahci: add HOST_CAP_NCQ constant · 979db803
      Tejun Heo 提交于
      Add HOST_CAP_NCQ.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      979db803
    • T
      [PATCH] ahci: clean up AHCI constants in preparation for NCQ · dd410ff1
      Tejun Heo 提交于
      * Rename CMD_TBL_HDR to CMD_TBL_HDR_SZ as it's size not offset.
      
      * Define MAX_CMDS and CMD_SZ and use them in calculation of other
        constants.
      
      * Define CMD_TBL_AR_SZ as product of CMD_TBL_SZ and MAX_CMDS, and use
        it when calculating PRIV_DMA_SZ.
      
      * CMD_SLOT_SZ is also dependent on MAX_CMDS but hasn't been changed
        because I didn't want to change the value used by the original code
        (32 commands).  Later NCQ change will bump MAX_CMDS to 32 anyway and
        the hard coded 32 can be changed to MAX_CMDS then.
      
      * Reorder HOST_CAP_* flags.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      dd410ff1
    • T
      [PATCH] ahci: add PIOS interim interrupt handling · 2a3917a8
      Tejun Heo 提交于
      During multiblock PIO, multiple PIOS interrupts are generated before
      qc compltion.  Current code prints unnecessary message for such cases.
      This is exposed when new EH slows down attached device into PIO mode.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      2a3917a8
    • T
      [PATCH] ahci: convert to new EH · 78cd52d0
      Tejun Heo 提交于
      Convert AHCI to new EH.  Unfortunately, ICH7 AHCI reacts badly if IRQ
      mask is diddled during operation.  So, freezing is implemented by
      unconditionally clearing interrupt conditions while frozen.
      
      * Interrupts are categorized according to required action.
        e.g. Connection status or unknown FIS error requires freezing the
        port while TF or HBUS_DATA don't.
      
      * Only CONNECT (reflects SErr.X) interrupt is taken into account not
        PHYRDY (SErr.N), as CONNECT is better cue for starting EH.
      
      * AHCI may be invoked without any active command.  e.g. CONNECT irq
        occuring while no qc in progress still triggers EH and will reset
        the port and revalidate attached device.
      Signed-off-by: NTejun Heo <htejun@gmail.com>
      78cd52d0