1. 10 5月, 2013 1 次提交
    • J
      [SCSI] sas: unify the pointlessly separated enums sas_dev_type and sas_device_type · aa9f8328
      James Bottomley 提交于
      These enums have been separate since the dawn of SAS, mainly because the
      latter is a procotol only enum and the former includes additional state
      for libsas.  The dichotomy causes endless confusion about which one you
      should use where and leads to pointless warnings like this:
      
      drivers/scsi/mvsas/mv_sas.c: In function 'mvs_update_phyinfo':
      drivers/scsi/mvsas/mv_sas.c:1162:34: warning: comparison between 'enum sas_device_type' and 'enum sas_dev_type' [-Wenum-compare]
      
      Fix by eliminating one of them.  The one kept is effectively the sas.h
      one, but call it sas_device_type and make sure the enums are all
      properly namespaced with the SAS_ prefix.
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      aa9f8328
  2. 24 8月, 2012 2 次提交
  3. 20 7月, 2012 3 次提交
  4. 08 7月, 2012 1 次提交
  5. 23 4月, 2012 1 次提交
    • D
      [SCSI] libsas, libata: fix start of life for a sas ata_port · b2024459
      Dan Williams 提交于
      This changes the ordering of initialization and probing events from:
        1/ allocate rphy in PORTE_BYTES_DMAED, DISCE_REVALIDATE_DOMAIN
        2/ allocate ata_port and schedule port probe in DISCE_PROBE
      ...to:
        1/ allocate ata_port in PORTE_BYTES_DMAED, DISCE_REVALIDATE_DOMAIN
        2/ allocate rphy in PORTE_BYTES_DMAED, DISCE_REVALIDATE_DOMAIN
        3/ schedule port probe in DISCE_PROBE
      
      This ordering prevents PHYE_SIGNAL_LOSS_EVENTS from sneaking in to
      destrory ata devices before they have been fully initialized:
      
        BUG: unable to handle kernel paging request at 0000000000003b10
        IP: [<ffffffffa0053d7e>] sas_ata_end_eh+0x12/0x5e [libsas]
        ...
        [<ffffffffa004d1af>] sas_unregister_common_dev+0x78/0xc9 [libsas]
        [<ffffffffa004d4d4>] sas_unregister_dev+0x4f/0xad [libsas]
        [<ffffffffa004d5b1>] sas_unregister_domain_devices+0x7f/0xbf [libsas]
        [<ffffffffa004c487>] sas_deform_port+0x61/0x1b8 [libsas]
        [<ffffffffa004bed0>] sas_phye_loss_of_signal+0x29/0x2b [libsas]
      
      ...and kills the awkward "sata domain_device briefly existing in the
      domain without an ata_port" state.
      Reported-by: NMichal Kosciowski <michal.kosciowski@intel.com>
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Acked-by: NJeff Garzik <jgarzik@redhat.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      b2024459
  6. 01 3月, 2012 12 次提交
    • D
      [SCSI] libsas: don't recover end devices attached to disabled phys · 26a2e68f
      Dan Williams 提交于
      If userspace has decided to disable a phy the kernel should honor that
      and not inadvertantly re-enable the phy via error recovery.  This is
      more straightforward in the sata case where link recovery (via
      libata-eh) is separate from sas_task cancelling in libsas-eh.  Teach
      libsas to accept -ENODEV as a successful response from I_T_nexus_reset
      ('successful' in terms of not escalating further).
      
      This is a more comprehensive fix then "libsas: don't recover 'gone'
      devices in sas_ata_hard_reset()", as it is no longer sata-specific.
      
      aic94xx does check the return value from sas_phy_reset() so if the phy
      is disabled we proceed with clearing the I_T_nexus.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      26a2e68f
    • D
      [SCSI] libsas: revert ata srst · 9a10b33c
      Dan Williams 提交于
      libata issues follow up srsts when the controller has a hard time
      recording the signature-fis after a reset, or if the link supports port
      multipliers.  libsas does not support port multipliers and no current
      libsas lldds appear to need help retrieving the signature fis.  Revert
      it for now to remove confusion.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      9a10b33c
    • D
      [SCSI] libsas: async ata scanning · 9508a66f
      Dan Williams 提交于
      libsas ata error handling is already async but this does not help the
      scan case.  Move initial link recovery out from under host->scan_mutex,
      and delay synchronization with eh until after all port probe/recovery
      work has been queued.
      
      Device ordering is maintained with scan order by still calling
      sas_rphy_add() in order of domain discovery.
      
      Since we now scan the domain list when invoking libata-eh we need to be
      careful to check for fully initialized ata ports.
      Acked-by: NJack Wang <jack_wang@usish.com>
      Acked-by: NJeff Garzik <jgarzik@redhat.com>
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      9508a66f
    • D
      [SCSI] libsas: restore scan order · 92625f9b
      Dan Williams 提交于
      ata devices are always scanned after ssp.  Prior to the ata error
      handling reworks libsas would tend to scan devices in ascending expander
      phy order.  Restore this ordering by deferring ssp discovery to a
      DISCE_PROBE event, and keep the probe order consistent with the
      discovery order, not the placement of sata devices.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      92625f9b
    • D
      [SCSI] libsas: let libata recover links that fail to transmit initial sig-fis · 354cf829
      Dan Williams 提交于
      libsas fails to discover all sata devices in the domain.  If a device fails
      negotiation and does not transmit a signature fis the link needs recovery.
      libata already understands how to manage slow to come up links, so treat these
      conditions as ata device attach events for the purposes of creating an
      ata_port.  This allows libata to manage retrying link bring up.
      
      Rediscovery is modified to be careful about checking changes in dev_type.  It
      looks like libsas leaks old devices if the sas address changes, but that's a
      fix for another patch.
      Acked-by: NJack Wang <jack_wang@usish.com>
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      354cf829
    • D
      [SCSI] libsas: improve debug statements · d214d81e
      Dan Williams 提交于
      It's difficult to determine which domain_device is triggering error recovery,
      so convert messages like:
      
        sas: ex 5001b4da000e703f phy08:T attached: 5001b4da000e7028
        sas: ex 5001b4da000e703f phy09:T attached: 5001b4da000e7029
        ...
        ata7: sas eh calling libata port error handler
        ata8: sas eh calling libata port error handler
      
      ...into:
      
        sas: ex 5001517e85cfefff phy05:T:9 attached: 5001517e85cfefe5 (stp)
        sas: ex 5001517e3b0af0bf phy11:T:8 attached: 5001517e3b0af0ab (stp)
        ...
        sas: ata7: end_device-21:1: dev error handler
        sas: ata8: end_device-20:0:5: dev error handler
      
      which shows attached link rate, device type, and associates a
      domain_device with its ata_port id to correlate messages emitted from
      libata-eh.
      
      As Doug notes, we can also take the opportunity to clarify expander phy
      routing capabilities.
      
      [dgilbert@interlog.com: clarify table2table with 'U']
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      d214d81e
    • D
      [SCSI] libsas: fix mixed topology recovery · d230ce69
      Dan Williams 提交于
      If we have a domain with sas and sata devices there may still be sas
      recovery actions to take after peeling off the commands to send to
      libata.
      Reported-by: NAndrzej Jakowski <andrzej.jakowski@intel.com>
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      d230ce69
    • D
      [SCSI] libsas: close scsi_remove_target() vs libata-eh race · 8abda4d2
      Dan Williams 提交于
      ata_port lifetime in libata follows the host.  In libsas it follows the
      scsi_target.  Once scsi_remove_device() has caused all commands to be
      completed it allows scsi_remove_target() to immediately proceed to
      freeing the ata_port causing bug reports like:
      
      [  848.393333] BUG: spinlock bad magic on CPU#4, kworker/u:2/5107
      [  848.400262] general protection fault: 0000 [#1] SMP
      [  848.406244] CPU 4
      [  848.408310] Modules linked in: nls_utf8 ipv6 uinput i2c_i801 i2c_core iTCO_wdt iTCO_vendor_support ioatdma dca sg sd_mod sr_mod cdrom ahci libahci isci libsas libata scsi_transport_sas [last unloaded: scsi_wait_scan]
      [  848.432060]
      [  848.434137] Pid: 5107, comm: kworker/u:2 Not tainted 3.2.0-isci+ #8 Intel Corporation S2600CP/S2600CP
      [  848.445310] RIP: 0010:[<ffffffff8126a68c>]  [<ffffffff8126a68c>] spin_dump+0x5e/0x8c
      [  848.454787] RSP: 0018:ffff8807f868dca0  EFLAGS: 00010002
      [  848.461137] RAX: 0000000000000048 RBX: ffff8807fe86a630 RCX: ffffffff817d0be0
      [  848.469520] RDX: 0000000000000000 RSI: ffffffff814af1cf RDI: 0000000000000002
      [  848.477959] RBP: ffff8807f868dcb0 R08: 00000000ffffffff R09: 000000006b6b6b6b
      [  848.486327] R10: 000000000003fb8c R11: ffffffff81a19448 R12: 6b6b6b6b6b6b6b6b
      [  848.494699] R13: ffff8808027dc520 R14: 0000000000000000 R15: 000000000000001e
      [  848.503067] FS:  0000000000000000(0000) GS:ffff88083fd00000(0000) knlGS:0000000000000000
      [  848.512899] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
      [  848.519710] CR2: 00007ff77d001000 CR3: 00000007f7a5d000 CR4: 00000000000406e0
      [  848.528072] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
      [  848.536446] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
      [  848.544831] Process kworker/u:2 (pid: 5107, threadinfo ffff8807f868c000, task ffff8807ff348000)
      [  848.555327] Stack:
      [  848.557959]  ffff8807fe86a630 ffff8807fe86a630 ffff8807f868dcd0 ffffffff8126a6e0
      [  848.567072]  ffffffff817c142f ffff8807fe86a630 ffff8807f868dcf0 ffffffff8126a703
      [  848.576190]  ffff8808027dc520 0000000000000286 ffff8807f868dd10 ffffffff814af1bb
      [  848.585281] Call Trace:
      [  848.588409]  [<ffffffff8126a6e0>] spin_bug+0x26/0x28
      [  848.594357]  [<ffffffff8126a703>] do_raw_spin_unlock+0x21/0x88
      [  848.601283]  [<ffffffff814af1bb>] _raw_spin_unlock_irqrestore+0x2c/0x65
      [  848.609089]  [<ffffffffa001c103>] ata_scsi_port_error_handler+0x548/0x557 [libata]
      [  848.618331]  [<ffffffff81061813>] ? async_schedule+0x17/0x17
      [  848.625060]  [<ffffffffa004f30f>] async_sas_ata_eh+0x45/0x69 [libsas]
      [  848.632655]  [<ffffffff810618aa>] async_run_entry_fn+0x97/0x125
      [  848.639670]  [<ffffffff81057439>] process_one_work+0x207/0x38d
      [  848.646577]  [<ffffffff8105738c>] ? process_one_work+0x15a/0x38d
      [  848.653681]  [<ffffffff810576f7>] worker_thread+0x138/0x21c
      [  848.660305]  [<ffffffff810575bf>] ? process_one_work+0x38d/0x38d
      [  848.667493]  [<ffffffff8105b098>] kthread+0x9d/0xa5
      [  848.673382]  [<ffffffff8106e1bd>] ? trace_hardirqs_on_caller+0x12f/0x166
      [  848.681304]  [<ffffffff814b7704>] kernel_thread_helper+0x4/0x10
      [  848.688324]  [<ffffffff814af534>] ? retint_restore_args+0x13/0x13
      [  848.695530]  [<ffffffff8105affb>] ? __init_kthread_worker+0x5b/0x5b
      [  848.702929]  [<ffffffff814b7700>] ? gs_change+0x13/0x13
      [  848.709155] Code: 00 00 48 8d 88 38 04 00 00 44 8b 80 84 02 00 00 31 c0 e8 cf 1b 24 00 41 83 c8 ff 44 8b 4b 08 48 c7 c1 e0 0b 7d 81 4d 85 e4 74 10 <45> 8b 84 24 84 02 00 00 49 8d 8c 24 38 04 00 00 8b 53 04 48 89
      [  848.732467] RIP  [<ffffffff8126a68c>] spin_dump+0x5e/0x8c
      [  848.738905]  RSP <ffff8807f868dca0>
      [  848.743743] ---[ end trace 143161646eee8caa ]---
      
      ...so arrange for the ata_port to have the same end of life as the domain
      device.
      Reported-by: NMarcin Tomczak <marcin.tomczak@intel.com>
      Acked-by: NJeff Garzik <jgarzik@redhat.com>
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      8abda4d2
    • D
      [SCSI] isci: stop interpreting ->lldd_lu_reset() as an ata soft-reset · 43a5ab15
      Dan Williams 提交于
      Driving resets from libsas-eh is pre-mature as libata will make a
      decision about performing a softreset.  Currently libata determines
      whether to perform a softreset based on ata_eh_followup_srst_needed(),
      and none of those conditions apply to isci.
      
      Remove the srst implementation and translate ->lldd_lu_reset() for ata
      devices as a request to drive a reset via libata-eh.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      43a5ab15
    • D
      [SCSI] libsas: don't recover 'gone' devices in sas_ata_hard_reset() · cb48d672
      Dan Williams 提交于
      The commands that timeout when a disk is forcibly removed may trigger
      libata to attempt recovery of the device.  If libsas has decided to
      remove the device don't permit ata to continue to issue resets to its
      last known phy.
      
      The primary motivation for this patch is hotplug testing by writing 0 to
      /sys/class/sas_phy/phyX/enable.  Without this check this test leads to
      libata issuing a reset and re-enabling the device that wants to be torn
      down.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      cb48d672
    • D
      [SCSI] libsas: fix sas_find_local_phy(), take phy references · f41a0c44
      Dan Williams 提交于
      In the direct-attached case this routine returns the phy on which this
      device was first discovered.  Which is broken if we want to support
      wide-targets, as this phy reference can become stale even though the
      port is still active.
      
      In the expander-attached case this routine tries to lookup the phy by
      scanning the attached sas addresses of the parent expander, and BUG_ONs
      if it can't find it.  However since eh and the libsas workqueue run
      independently we can still be attempting device recovery via eh after
      libsas has recorded the device as detached.  This is even easier to hit
      now that eh is blocked while device domain rediscovery takes place, and
      that libata is fed more timed out commands increasing the chances that
      it will try to recover the ata device.
      
      Arrange for dev->phy to always point to a last known good phy, it may be
      stale after the port is torn down, but it will catch up for wide port
      reconfigurations, and never be NULL.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      f41a0c44
    • D
      [SCSI] libsas: poll for ata device readiness after reset · 36a39947
      Dan Williams 提交于
      Use ata_wait_after_reset() to poll for link recovery after a reset.
      This combined with sas_ha->eh_mutex prevents expander rediscovery from
      probing phys in an intermediate state.  Local discovery does not have a
      mechanism to filter link status changes during this timeout, so it
      remains the responsibility of lldds to prevent premature port teardown.
      Although once all lldd's support ->lldd_ata_check_ready() that could be
      used as a gate to local port teardown.
      
      The signature fis is re-transmitted when the link comes back so we
      should be revalidating the ata device class, but that is left to a future
      patch.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      36a39947
  7. 20 2月, 2012 12 次提交
    • D
      [SCSI] libsas: async ata-eh · 50824d6c
      Dan Williams 提交于
      Once sas_ata_hard_reset() starts honoring the 'deadline' parameter a
      pathological configuration could take 25 seconds per ata device
      (serialized) to recover.  Run per-port recoveries in parallel.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      50824d6c
    • D
      [SCSI] libsas: execute transport link resets with libata-eh via host workqueue · 81c757bc
      Dan Williams 提交于
      Link resets leave ata affiliations intact, so arrange for libsas to make
      an effort to avoid dropping the device due to a slow-to-recover link.
      Towards this end carry out reset in the host workqueue so that it can
      check for ata devices and kick the reset request to libata.  Hard
      resets, in contrast, bypass libata since they are meant for associating
      an ata device with another initiator in the domain (tears down
      affiliations).
      
      Need to add a new transport_sas_phy_reset() since the current
      sas_phy_reset() is a utility function to libsas lldds.  They are not
      prepared for it to loop back into eh.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      81c757bc
    • D
      [SCSI] libsas: use libata-eh-reset for sata rediscovery fis transmit failures · b52df417
      Dan Williams 提交于
      Since sata devices can take several seconds to recover the link on reset
      the 0.5 seconds that libsas currently waits may not be enough.  Instead
      if we are rediscovering a phy that was previously attached to a sata
      device let libata handle any resets to encourage the device to transmit
      the initial fis.
      
      Once sas_ata_hard_reset() and lldds learn how to honor 'deadline' libsas
      should stop encountering phys in an intermediate state, until then this
      will loop until the fis is transmitted or ->attached_sas_addr gets
      cleared, but in the more likely initial discovery case we keep existing
      behavior.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      b52df417
    • D
      [SCSI] libsas: defer SAS_TASK_NEED_DEV_RESET commands to libata · 3a2cdf39
      Dan Williams 提交于
      lldds use the SAS_TASK_NEED_DEV_RESET interface to request that eh
      perform a reset.  In the sata device case defer the commands that
      triggered the reset to libata-eh context so it can perform its pre and
      post reset management.
      
      In the sas_ata_post_internal() case the reset request is falling on deaf
      ears as the sas_task is immediately destroyed without any reset action.
      Since it is currently a nop, and likely superfluous given the conversion
      to new-style libata-eh, just drop the request.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      3a2cdf39
    • D
      [SCSI] libsas: fix timeout vs completion race · 9095a64a
      Dan Williams 提交于
      Until we have told the lldd to forget a task a timed out operation can
      return from the hardware at any time.  Since completion frees the task
      we need to make sure that no tasks run their normal completion handler
      once eh has decided to manage the task.  Similar to
      ata_scsi_cmd_error_handler() freeze completions to let eh judge the
      outcome of the race.
      
      Task collector mode is problematic because it presents a situation where
      a task can be timed out and aborted before the lldd has even seen it.
      For this case we need to guarantee that a task that an lldd has been
      told to forget does not get queued after the lldd says "never seen it".
      With sas_scsi_timed_out we achieve this with the ->task_queue_flush
      mutex, rather than adding more time.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      9095a64a
    • D
      [SCSI] libsas: close error handling vs sas_ata_task_done() race · 3dff5721
      Dan Williams 提交于
      Since sas_ata does not implement ->freeze(), completions for scmds and
      internal commands can still arrive concurrent with
      ata_scsi_cmd_error_handler() and sas_ata_post_internal() respectively.
      By the time either of those is called libata has committed to completing
      the qc, and the ATA_PFLAG_FROZEN flag tells sas_ata_task_done() it has
      lost the race.
      
      In the sas_ata_post_internal() case we take on the additional
      responsibility of freeing the sas_task to close the race with
      sas_ata_task_done() freeing the the task while sas_ata_post_internal()
      is in the process of invoking ->lldd_abort_task().
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      3dff5721
    • D
      [SCSI] libsas: kill invocation of scsi_eh_finish_cmd from sas_ata_task_done · e500a34b
      Dan Williams 提交于
      Prior to the conversion to the new-style libata-eh sas_ata_task_done()
      may have been the last opportunity to clean up the scmd, but now
      libata-eh explicitly handles this case.  It also races against sas-eh.
      If a lldd completes a task after SAS_TASK_STATE_ABORTED is set it could
      trigger a spurious decrement of shost->host_failed.  Current lldds have
      the band-aid of checking SAS_TASK_STATE_ABORTED before calling
      ->task_done(), but better to just let the scmds escalate to libata for
      race free cleanup.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      e500a34b
    • D
      [SCSI] libsas: use ->set_dmamode to notify lldds of NCQ parameters · b91bb296
      Dan Williams 提交于
      sas_discover_sata() notifies lldds of sata devices twice.  Once to allow
      the 'identify' to be sent, and a second time to allow aic94xx (the only
      libsas driver that cares about sata_dev.identify) to setup NCQ
      parameters before the device becomes known to the midlayer.  Replace
      this double notification and intervening 'identify' with an explicit
      ->lldd_ata_set_dmamode notification.  With this change all ata internal
      commands are issued by libata, so we no longer need sas_issue_ata_cmd().
      
      The data from the identify command only needs to be cached in one
      location so ata_device.id replaces domain_device.sata_dev.identify.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      b91bb296
    • D
      [SCSI] libsas: prevent domain rediscovery competing with ata error handling · 87c8331f
      Dan Williams 提交于
      libata error handling provides for a timeout for link recovery.  libsas
      must not rescan for previously known devices in this interval otherwise
      it may remove a device that is simply waiting for its link to recover.
      Let libata-eh make the determination of when the link is stable and
      prevent libsas (host workqueue) from taking action while this
      determination is pending.
      
      Using a mutex (ha->disco_mutex) to flush and disable revalidation while
      eh is running requires any discovery action that may block on eh be
      moved to its own context outside the lock.  Probing ATA devices
      explicitly waits on ata-eh and the cache-flush-io issued during device
      removal may also pend awaiting eh completion.  Essentially any rphy
      add/remove activity needs to run outside the lock.
      
      This adds two new cleanup states for sas_unregister_domain_devices()
      'allocated-but-not-probed', and 'flagged-for-destruction'.  In the
      'allocated-but-not-probed' state  dev->rphy points to a rphy that is
      known to have not been through a sas_rphy_add() event.  At domain
      teardown check if this device is still pending probe and cleanup
      accordingly.  Similarly if a device has already been queued for removal
      then sas_unregister_domain_devices has nothing to do.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      87c8331f
    • D
      [SCSI] libsas: convert dev->gone to flags · e139942d
      Dan Williams 提交于
      In preparation for adding tracking of another device state "destroy".
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      e139942d
    • D
      [SCSI] libsas: remove ata_port.lock management duties from lldds · 312d3e56
      Dan Williams 提交于
      Each libsas driver (mvsas, pm8001, and isci) has invented a different
      method for managing the ap->lock.  The lock is held by the ata
      ->queuecommand() path.  mvsas drops it prior to acquiring any internal
      locks which allows it to hold its internal lock across calls to
      task->task_done().  This capability is important as it is the only way
      the driver can flush task->task_done() instances to guarantee that it no
      longer has any in-flight references to a domain_device at
      ->lldd_dev_gone() time.
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      312d3e56
    • D
      [SCSI] libsas: remove unused ata_task_resp fields · 95ac7fd1
      Dan Williams 提交于
      Commit 1e34c838 "[SCSI] libsas: remove spurious sata control register
      read/write" removed the routines to fake the presence of the sata
      control registers, now remove the unused data structure fields to kill
      any remaining confusion.
      Acked-by: NJack Wang <jack_wang@usish.com>
      Signed-off-by: NDan Williams <dan.j.williams@intel.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      95ac7fd1
  8. 27 5月, 2011 1 次提交
  9. 25 5月, 2011 1 次提交
  10. 15 3月, 2011 1 次提交
    • J
      [SCSI] libsas: fix ata list corruption issue · a82058a7
      James Bottomley 提交于
      I think this stems from a misunderstanding of how the ata error handler
      works.  ata_scsi_cmd_error_handler() gets called with a passed in list
      of commands to handle.  However, that list may still not be empty when
      it exits.  The command ata_scsi_port_error_handler() must be called
      (which takes no list) before the list will be completely emptied.  This
      bites the sas error handler because the two are called from different
      functions and the original list has gone out of scope before
      ata_scsi_port_error_handler() is called. leading to some commands
      dangling on bare stack, which is a potential memory corruption issue.
      Fix this by manually deleting all outstanding commands from the on-stack
      list before it goes out of scope.
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      a82058a7
  11. 02 3月, 2011 5 次提交