1. 20 5月, 2006 4 次提交
    • V
      [SCTP]: Validate the parameter length in HB-ACK chunk. · a601266e
      Vladislav Yasevich 提交于
      If SCTP receives a badly formatted HB-ACK chunk, it is possible
      that we may access invalid memory and potentially have a buffer
      overflow.  We should really make sure that the chunk format is
      what we expect, before attempting to touch the data.
      Signed-off-by: NVlad Yasevich <vladislav.yasevich@hp.com>
      Signed-off-by: NSridhar Samudrala <sri@us.ibm.com>
      a601266e
    • V
      [SCTP]: Respect the real chunk length when walking parameters. · dd2d1c6f
      Vladislav Yasevich 提交于
      When performing bound checks during the parameter processing, we
      want to use the real chunk and paramter lengths for bounds instead
      of the rounded ones.  This prevents us from potentially walking of
      the end if the chunk length was miscalculated.  We still use rounded
      lengths when advancing the pointer. This was found during a
      conformance test that changed the chunk length without modifying
      parameters.
      Signed-off-by: NVlad Yasevich <vladislav.yasevich@hp.com>
      Signed-off-by: NSridhar Samudrala <sri@us.ibm.com>
      dd2d1c6f
    • V
      [SCTP]: A better solution to fix the race between sctp_peeloff() and · 61c9fed4
      Vladislav Yasevich 提交于
      sctp_rcv().
      
      The goal is to hold the ref on the association/endpoint throughout the
      state-machine process.  We accomplish like this:
      
        /* ref on the assoc/ep is taken during lookup */
      
        if owned_by_user(sk)
       	sctp_add_backlog(skb, sk);
        else
       	inqueue_push(skb, sk);
      
        /* drop the ref on the assoc/ep */
      
      However, in sctp_add_backlog() we take the ref on assoc/ep and hold it
      while the skb is on the backlog queue.  This allows us to get rid of the
      sock_hold/sock_put in the lookup routines.
      
      Now sctp_backlog_rcv() needs to account for potential association move.
      In the unlikely event that association moved, we need to retest if the
      new socket is locked by user.  If we don't this, we may have two packets
      racing up the stack toward the same socket and we can't deal with it.
      If the new socket is still locked, we'll just add the skb to its backlog
      continuing to hold the ref on the association.  This get's rid of the
      need to move packets from one backlog to another and it also safe in
      case new packets arrive on the same backlog queue.
      
      The last step, is to lock the new socket when we are moving the
      association to it.  This is needed in case any new packets arrive on
      the association when it moved.  We want these to go to the backlog since
      we would like to avoid the race between this new packet and a packet
      that may be sitting on the backlog queue of the old socket toward the
      same association.
      Signed-off-by: NVladislav Yasevich <vladislav.yasevich@hp.com>
      Signed-off-by: NSridhar Samudrala <sri@us.ibm.com>
      61c9fed4
    • S
      [SCTP]: Set sk_err so that poll wakes up after a non-blocking connect failure. · 8de8c873
      Sridhar Samudrala 提交于
      Also fix some other cases where sk_err is not set for 1-1 style sockets.
      Signed-off-by: NSridhar Samudrala <sri@us.ibm.com>
      8de8c873
  2. 19 5月, 2006 5 次提交
  3. 18 5月, 2006 15 次提交
  4. 17 5月, 2006 16 次提交