1. 04 4月, 2009 4 次提交
    • H
      thinkpad-acpi: restrict access to some firmware LEDs · a4d5effc
      Henrique de Moraes Holschuh 提交于
      Some of the ThinkPad LEDs indicate critical conditions that can cause
      data loss or cause hardware damage when ignored (e.g. force-ejecting
      a powered up bay; ignoring a failing battery, or empty battery; force-
      undocking with the dock buses still active, etc).
      
      On almost all ThinkPads, LED access is write-only, and the firmware
      usually does fire-and-forget signaling on them, so you effectively
      lose whatever message the firmware was trying to convey to the user
      when you override the LED state, without any chance to restore it.
      
      Restrict access to all LEDs that can convey important alarms, or that
      could mislead the user into incorrectly operating the hardware.  This
      will make the Lenovo engineers less unhappy about the whole issue.
      
      Allow users that really want it to still control all LEDs, it is the
      unaware user that we have to worry about.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      a4d5effc
    • H
      thinkpad-acpi: remove HKEY disable functionality · 2586d566
      Henrique de Moraes Holschuh 提交于
      The HKEY disable functionality basically cripples the entire event
      model of the ThinkPad firmware and of the thinkpad-acpi driver.
      Remove this functionality from the driver.  HKEY must be enabled at
      all times while thinkpad-acpi is loaded, and disabled otherwise.
      
      For sysfs, according to the sysfs ABI and the thinkpad-acpi sysfs
      rules of engagement, we will just remove the attributes.  This will be
      done in two stages: disable their function now, after two kernel
      releases, remove the attributes.
      
      For procfs, we call WARN().  If nothing triggers it, I will simply
      remove the enable/disable commands entirely in the future along with
      the sysfs attributes.
      
      I don't expect much, if any fallout from this.  There really isn't any
      reason to mess with hotkey_enable or with the enable/disable commands
      to /proc/acpi/ibm/hotkey, and this has been true for years...
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      2586d566
    • H
      thinkpad-acpi: add new debug helpers and warn of deprecated atts · 73a94d86
      Henrique de Moraes Holschuh 提交于
      Add a debug helper that discloses the TGID of the userspace task
      attempting to access the driver.  This is highly useful when dealing
      with bug reports, since often the user has no idea that some userspace
      application is accessing thinkpad-acpi...
      
      Also add a helper to log warnings about sysfs attributes that are
      deprecated.
      
      Use the new helpers to issue deprecation warnings for bluetooth_enable
      and wwan_enabled, that have been deprecated for a while, now.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      73a94d86
    • H
      thinkpad-acpi: documentation cleanup · 078ac19e
      Henrique de Moraes Holschuh 提交于
      Some cleanups to the documentation of the driver.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      078ac19e
  2. 16 1月, 2009 3 次提交
  3. 06 1月, 2009 1 次提交
  4. 29 8月, 2008 1 次提交
  5. 21 7月, 2008 2 次提交
  6. 12 6月, 2008 1 次提交
  7. 29 4月, 2008 6 次提交
  8. 16 2月, 2008 5 次提交
  9. 09 2月, 2008 1 次提交
  10. 02 2月, 2008 7 次提交
  11. 06 11月, 2007 4 次提交
  12. 20 10月, 2007 2 次提交
  13. 26 9月, 2007 1 次提交
  14. 17 9月, 2007 2 次提交
    • H
      ACPI: thinkpad-acpi: bump up version to 0.16 · 3b0c6485
      Henrique de Moraes Holschuh 提交于
      Name it thinkpad-acpi version 0.16 to avoid any confusion with some 0.15
      thinkpad-acpi development snapshots and backports that had input layer
      support, but no hotkey_report_mode support.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      3b0c6485
    • H
      ACPI: thinkpad-acpi: revert new 2.6.23 CONFIG_THINKPAD_ACPI_INPUT_ENABLED option · ff80f137
      Henrique de Moraes Holschuh 提交于
      Revert new 2.6.23 CONFIG_THINKPAD_ACPI_INPUT_ENABLED Kconfig option because
      it would create a legacy we don't want to support.
      
      CONFIG_THINKPAD_ACPI_INPUT_ENABLED was added to try to fix an issue that is
      now moot with the addition of the netlink ACPI event report interface to
      the ACPI core.
      
      Now that ACPI core can send events over netlink, we can use a different
      strategy to keep backwards compatibility with older userspace, without the
      need for the CONFIG_THINKPAD_ACPI_INPUT_ENABLED games.  And it arrived
      before CONFIG_THINKPAD_ACPI_INPUT_ENABLED made it to a stable mainline
      kernel, even, which is Good.
      
      This patch is in sync with some changes to thinkpad-acpi backports, that
      will keep things sane for userspace across different combinations of kernel
      versions, thinkpad-acpi backports (or the lack thereof), and userspace
      capabilities:
      
      Unless a module parameter is used, thinkpad-acpi will now behave in such a
      way that it will work well (by default) with userspace that still uses only
      the old ACPI procfs event interface and doesn't care for thinkpad-acpi
      input devices.
      
      It will also always work well with userspace that has been updated to use
      both the thinkpad-acpi input devices, and ACPI core netlink event
      interface, regardless of any module parameter.
      
      The module parameter was added to allow thinkpad-acpi to work with
      userspace that has been partially updated to use thinkpad-acpi input
      devices, but not the new ACPI core netlink event interface.  To use this
      mode of hot key reporting, one has to specify the hotkey_report_mode=2
      module parameter.
      
      The thinkpad-acpi driver exports the value of hotkey_report_mode through
      sysfs, as well.  thinkpad-acpi backports to older kernels, that do not
      support the new ACPI core netlink interface, have code to allow userspace
      to switch hotkey_report_mode at runtime through sysfs.  This capability
      will not be provided in mainline thinkpad-acpi as it is not needed there.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Cc: Michael S. Tsirkin <mst@dev.mellanox.co.il>
      Cc: Hugh Dickins <hugh@veritas.com>
      Cc: Richard Hughes <hughsient@gmail.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      ff80f137