1. 25 10月, 2011 1 次提交
  2. 11 10月, 2011 1 次提交
  3. 16 9月, 2011 3 次提交
  4. 11 8月, 2011 3 次提交
    • K
      net/irda: sh_sir: tidyup compile warning · 2eed7982
      Kuninori Morimoto 提交于
      This patch tidyup below warning
      
      ${LINUX}/drivers/net/irda/sh_sir.c:514:6: warning:
       'val' may be used uninitialized in this function
      Signed-off-by: NKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2eed7982
    • K
      net/irda: sh_sir: add missing header · 86d0aff0
      Kuninori Morimoto 提交于
      This patch fixup below build error on sh_sir
      
      sh_sir.c: In function 'sh_sir_write':
      sh_sir.c:127:2: error: implicit declaration of function 'iowrite16'
      sh_sir.c: In function 'sh_sir_read':
      sh_sir.c:132:2: error: implicit declaration of function 'ioread16'
      sh_sir.c: At top level:
      sh_sir.c:561:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sh_sir_irq'
      sh_sir.c: In function 'sh_sir_probe':
      sh_sir.c:727:2: error: implicit declaration of function 'ioremap_nocache'
      sh_sir.c:727:16: warning: assignment makes pointer from integer without a cast
      sh_sir.c:762:2: error: implicit declaration of function 'request_irq'
      sh_sir.c:762:23: error: 'sh_sir_irq' undeclared (first use in this function)
      sh_sir.c:762:23: note: each undeclared identifier is reported only once for each function it appears in
      sh_sir.c:762:35: error: 'IRQF_DISABLED' undeclared (first use in this function)
      sh_sir.c:776:2: error: implicit declaration of function 'iounmap'
      sh_sir.c: At top level:
      sh_sir.c:436:13: warning: 'sh_sir_clear_all_err' defined but not used
      sh_sir.c:474:12: warning: 'sh_sir_is_which_phase' defined but not used
      sh_sir.c:490:13: warning: 'sh_sir_tx' defined but not used
      sh_sir.c:540:13: warning: 'sh_sir_rx' defined but not used
      Signed-off-by: NKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      86d0aff0
    • K
      net/irda: sh_irda: add missing header · a916d82b
      Kuninori Morimoto 提交于
      This patch fixup below build error on sh_irda
      
      sh_irda.c: In function 'sh_irda_write':
      sh_irda.c:174: error: implicit declaration of function 'iowrite16'
      sh_irda.c: In function 'sh_irda_read':
      sh_irda.c:184: error: implicit declaration of function 'ioread16'
      sh_irda.c: At top level:
      sh_irda.c:492: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sh_irda_irq'
      sh_irda.c: In function 'sh_irda_probe':
      sh_irda.c:776: error: implicit declaration of function 'ioremap_nocache'
      sh_irda.c:776: warning: assignment makes pointer from integer without a cast
      sh_irda.c:811: error: implicit declaration of function 'request_irq'
      sh_irda.c:811: error: 'sh_irda_irq' undeclared (first use in this function)
      sh_irda.c:811: error: (Each undeclared identifier is reported only once
      sh_irda.c:811: error: for each function it appears in.)
      sh_irda.c:811: error: 'IRQF_DISABLED' undeclared (first use in this function)
      sh_irda.c:825: error: implicit declaration of function 'iounmap'
      Signed-off-by: NKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a916d82b
  5. 04 8月, 2011 1 次提交
  6. 24 6月, 2011 1 次提交
  7. 22 6月, 2011 2 次提交
  8. 07 6月, 2011 1 次提交
  9. 06 6月, 2011 1 次提交
  10. 04 6月, 2011 1 次提交
    • L
      Revert "tty: make receive_buf() return the amout of bytes received" · 55db4c64
      Linus Torvalds 提交于
      This reverts commit b1c43f82.
      
      It was broken in so many ways, and results in random odd pty issues.
      
      It re-introduced the buggy schedule_work() in flush_to_ldisc() that can
      cause endless work-loops (see commit a5660b41: "tty: fix endless
      work loop when the buffer fills up").
      
      It also used an "unsigned int" return value fo the ->receive_buf()
      function, but then made multiple functions return a negative error code,
      and didn't actually check for the error in the caller.
      
      And it didn't actually work at all.  BenH bisected down odd tty behavior
      to it:
        "It looks like the patch is causing some major malfunctions of the X
         server for me, possibly related to PTYs.  For example, cat'ing a
         large file in a gnome terminal hangs the kernel for -minutes- in a
         loop of what looks like flush_to_ldisc/workqueue code, (some ftrace
         data in the quoted bits further down).
      
         ...
      
         Some more data: It -looks- like what happens is that the
         flush_to_ldisc work queue entry constantly re-queues itself (because
         the PTY is full ?) and the workqueue thread will basically loop
         forver calling it without ever scheduling, thus starving the consumer
         process that could have emptied the PTY."
      
      which is pretty much exactly the problem we fixed in a5660b41.
      
      Milton Miller pointed out the 'unsigned int' issue.
      Reported-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
      Reported-by: NMilton Miller <miltonm@bga.com>
      Cc: Stefan Bigler <stefan.bigler@keymile.com>
      Cc: Toby Gray <toby.gray@realvnc.com>
      Cc: Felipe Balbi <balbi@ti.com>
      Cc: Greg Kroah-Hartman <gregkh@suse.de>
      Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      55db4c64
  11. 01 6月, 2011 1 次提交
  12. 24 5月, 2011 1 次提交
  13. 10 5月, 2011 1 次提交
  14. 23 4月, 2011 1 次提交
  15. 19 4月, 2011 1 次提交
  16. 31 3月, 2011 1 次提交
  17. 30 3月, 2011 2 次提交
  18. 18 2月, 2011 1 次提交
  19. 19 1月, 2011 1 次提交
  20. 10 1月, 2011 2 次提交
  21. 04 1月, 2011 1 次提交
    • S
      smsc-ircc2: Fix section mismatch derived from smsc_ircc_pnp_probe() · 1170bed0
      Sedat Dilek 提交于
      This fixes the following warning:
      
      drivers/net/irda/smsc-ircc2.o(.data+0x18): Section mismatch in reference from the variable smsc_ircc_pnp_driver to the function .init.text:smsc_ircc_pnp_probe()
      The variable smsc_ircc_pnp_driver references
      the function __init smsc_ircc_pnp_probe()
      If the reference is valid then annotate the
      variable with __init* or __refdata (see linux/init.h) or name the variable:
      *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
      
      Tested with linux-next (next-20101231)
      Signed-off-by: NSedat Dilek <sedat.dilek@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      1170bed0
  22. 21 12月, 2010 1 次提交
  23. 12 12月, 2010 1 次提交
    • T
      drivers/net: don't use flush_scheduled_work() · 23f333a2
      Tejun Heo 提交于
      flush_scheduled_work() is on its way out.  This patch contains simple
      conversions to replace flush_scheduled_work() usage with direct
      cancels and flushes.
      
      Directly cancel the used works on driver detach and flush them in
      other cases.
      
      The conversions are mostly straight forward and the only dangers are,
      
      * Forgetting to cancel/flush one or more used works.
      
      * Cancelling when a work should be flushed (ie. the work must be
        executed once scheduled whether the driver is detaching or not).
      
      I've gone over the changes multiple times but it would be much
      appreciated if you can review with the above points in mind.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Cc: "David S. Miller" <davem@davemloft.net>
      Cc: Jay Cliburn <jcliburn@gmail.com>
      Cc: Michael Chan <mchan@broadcom.com>
      Cc: Divy Le Ray <divy@chelsio.com>
      Cc: e1000-devel@lists.sourceforge.net
      Cc: Vasanthy Kolluri <vkolluri@cisco.com>
      Cc: Samuel Ortiz <samuel@sortiz.org>
      Cc: Lennert Buytenhek <buytenh@wantstofly.org>
      Cc: Andrew Gallatin <gallatin@myri.com>
      Cc: Francois Romieu <romieu@fr.zoreil.com>
      Cc: Ramkrishna Vepa <ramkrishna.vepa@exar.com>
      Cc: Matt Carlson <mcarlson@broadcom.com>
      Cc: David Brownell <dbrownell@users.sourceforge.net>
      Cc: Shreyas Bhatewara <sbhatewara@vmware.com>
      Cc: netdev@vger.kernel.org
      23f333a2
  24. 22 11月, 2010 1 次提交
  25. 02 11月, 2010 1 次提交
  26. 18 10月, 2010 1 次提交
  27. 12 10月, 2010 1 次提交
  28. 11 10月, 2010 1 次提交
  29. 27 9月, 2010 1 次提交
  30. 23 9月, 2010 1 次提交
  31. 26 8月, 2010 1 次提交
    • J
      drivers/net/irda: Eliminate memory leak · 8d34e7d6
      Julia Lawall 提交于
      dev_alloc_skb allocates some memory, so that memory should be freed before
      leaving the function in an error case.
      
      Corrected some typos in a nearby comment as well.
      
      A simplified version of the semantic match that finds this problem is:
      (http://coccinelle.lip6.fr/)
      
      // <smpl>
      @r exists@
      local idexpression x;
      expression E;
      identifier f1;
      iterator I;
      @@
      
      x = dev_alloc_skb(...);
      <... when != x
           when != true (x == NULL || ...)
           when != if (...) { <+...x...+> }
           when != I (...) { <+...x...+> }
      (
       x == NULL
      |
       x == E
      |
       x->f1
      )
      ...>
      * return ...;
      // </smpl>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      8d34e7d6
  32. 17 8月, 2010 1 次提交
  33. 04 8月, 2010 1 次提交