1. 11 8月, 2011 1 次提交
  2. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  3. 07 7月, 2009 1 次提交
    • Y
      mlx4_core: Handle multi-physical function devices · cc4ac2e7
      Yevgeny Petrilin 提交于
      MT26468 (PCI ID 0x6764) devices can expose multiple physical
      functions.  The current driver only handles the primary physical
      function.  For other functions, the QUERY_FW firmware command will
      fail with the CMD_STAT_MULTI_FUNC_REQ error code.  Don't try to drive
      such devices, but print a message saying the driver is skipping those
      devices rather than just "QUERY_FW command failed."
      Signed-off-by: NYevgeny Petrilin <yevgenyp@mellanox.co.il>
      
      [ Rather than keeping unsupported devices bound to the driver, simply
        print a more informative error message and exit - Roland ]
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      cc4ac2e7
  4. 26 7月, 2008 1 次提交
  5. 23 7月, 2008 1 次提交
  6. 17 4月, 2008 1 次提交
  7. 10 10月, 2007 2 次提交
    • R
      mlx4_core: Use mmiowb() to avoid firmware commands getting jumbled up · 2e61c646
      Roland Dreier 提交于
      Firmware commands are sent to the HCA by writing multiple words to a
      command register block.  Access to this block of registers is
      serialized with a mutex.  However, on large SGI systems writes to the
      register block may be reordered within the system interconnect and
      reach the HCA in a different order than they were issued (even with
      the mutex).  Fix this by adding an mmiowb() before dropping the mutex.
      
      This bug was observed with real workloads with the similar FW command
      code in the mthca driver, and adding the mmiowb() as in commit
      66547550 ("IB/mthca: Use mmiowb() to avoid firmware commands getting
      jumbled up") was confirmed to fix the problems, so we should add the
      same fix to mlx4.
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      2e61c646
    • D
      mlx4_core: Use enum value GO_BIT_TIMEOUT_MSECS · 36ce10d3
      Dotan Barak 提交于
      Rename GO_BIT_TIMEOUT to GO_BIT_TIMEOUT_MSECS for clarity, and
      actually use it as the go bit timeout (instead of having the define
      but then ignoring it and using a hard-coded 10 * HZ for the actual
      timeout).
      Signed-off-by: NDotan Barak <dotanb@dev.mellanox.co.il>
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      36ce10d3
  8. 21 7月, 2007 1 次提交
    • R
      mlx4_core: Change command token on timeout · 0981582d
      Roland Dreier 提交于
          
      The FW command token is currently only updated on a command completion
      event. This means that on command timeout, the same token will be
      reused for new command, which results in a mess if the timed out
      command *does* eventually complete.
      
      This is the same change as the patch for mthca from Michael
      S. Tsirkin <mst@dev.mellanox.co.il> that was just merged.  It seems
      sensible to avoid gratuitous differences in FW command processing
      between mthca and mlx4.
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      0981582d
  9. 09 5月, 2007 1 次提交
    • R
      IB/mlx4: Add a driver Mellanox ConnectX InfiniBand adapters · 225c7b1f
      Roland Dreier 提交于
      Add an InfiniBand driver for Mellanox ConnectX adapters.  Because
      these adapters can also be used as ethernet NICs and Fibre Channel 
      HBAs, the driver is split into two modules: 
       
        mlx4_core: Handles low-level things like device initialization and 
          processing firmware commands.  Also controls resource allocation 
          so that the InfiniBand, ethernet and FC functions can share a 
          device without stepping on each other. 
       
        mlx4_ib: Handles InfiniBand-specific things; plugs into the 
          InfiniBand midlayer. 
      Signed-off-by: NRoland Dreier <rolandd@cisco.com>
      225c7b1f