1. 11 8月, 2010 1 次提交
  2. 28 7月, 2010 1 次提交
  3. 25 5月, 2010 1 次提交
  4. 17 5月, 2010 6 次提交
  5. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  6. 18 1月, 2010 1 次提交
    • P
      [SCSI] aacraid: fix File System going into read-only mode · cacb6dc3
      These particular problems were reported by Cisco and SAP and customers
      as well. Cisco reported on RHEL4 U6 and SAP reported on SLES9 SP4 and
      SLES10 SP2. We added these fixes on RHEL4 U6 and gave a private build
      to IBM and Cisco. Cisco and IBM tested it for more than 15 days and
      they reported that they did not see the issue so far. Before the fix,
      Cisco used to see the issue within 5 days. We generated a patch for
      SLES9 SP4 and SLES10 SP2 and submitted to Novell. Novell applied the
      patch and gave a test build to SAP. SAP tested and reported that the
      build is working properly.
      
      We also tested in our lab using the tools "dishogsync", which is IO
      stress tool and the tool was provided by Cisco.
      
      Issue1:  File System going into read-only mode
      
      Root cause: The driver tends to not free the memory (FIB) when the
      management request exits prematurely. The accumulation of such
      un-freed memory causes the driver to fail to allocate anymore memory
      (FIB) and hence return 0x70000 value to the upper layer, which puts
      the file system into read only mode.
      
      Fix details: The fix makes sure to free the memory (FIB) even if the
      request exits prematurely hence ensuring the driver wouldn't run out
      of memory (FIBs).
      
      
      Issue2: False Raid Alert occurs
      
      When the Physical Drives and Logical drives are reported as deleted or
      added, even though there is no change done on the system
      
      Root cause: Driver IOCTLs is signaled with EINTR while waiting on
      response from the lower layers. Returning "EINTR" will never initiate
      internal retry.
      
      Fix details: The issue was fixed by replacing "EINTR" with
      "ERESTARTSYS" for mid-layer retries.
      Signed-off-by: NPenchala Narasimha Reddy <ServeRAIDDriver@hcl.in>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      cacb6dc3
  7. 05 12月, 2009 1 次提交
    • M
      [SCSI] modify change_queue_depth to take in reason why it is being called · e881a172
      Mike Christie 提交于
      This patch modifies scsi_host_template->change_queue_depth so that
      it takes an argument indicating why it is being called. This will be
      used so that if a LLD needs to do some extra processing when
      handling queue fulls or later ramp ups, it can do so.
      
      This is a simple port of the drivers setting a change_queue_depth
      callback. In the patch I just have these LLDs adjust the queue depth
      if the user was requesting it.
      Signed-off-by: NMike Christie <michaelc@cs.wisc.edu>
      
      [Vasu.Dev: v2
      	Also converted pmcraid_change_queue_depth and then verified
      all modules compile  using "make allmodconfig" for any new build
      warnings on X86_64.
      
      	Updated original description after combing two original
      patches from Mike to make this patch git bisectable.]
      Signed-off-by: NVasu Dev <vasu.dev@intel.com>
      [jejb: fixed up 53c700]
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      e881a172
  8. 04 12月, 2009 1 次提交
  9. 14 4月, 2009 1 次提交
  10. 07 4月, 2009 3 次提交
  11. 03 4月, 2009 1 次提交
  12. 30 12月, 2008 2 次提交
  13. 03 12月, 2008 1 次提交
  14. 02 12月, 2008 1 次提交
  15. 09 10月, 2008 1 次提交
  16. 12 7月, 2008 1 次提交
    • M
      [SCSI] aacraid: prevent copy_from_user() BUG! · 09050715
      Mark Salyzyn 提交于
      Seen:
      
      	kernel BUG at arch/i386/lib/usercopy.c:872
      
      under a 2.6.18-8.el5 kernel. Traced it to a garbage-in/garbage-out
      ioctl condition in the aacraid driver.
      
      Adaptec's special ioctl scb passthrough needs to check the validity of
      the individual scatter gather count fields to the maximum the adapter
      supports. Doing so will have the side effect of preventing
      copy_from_user() from bugging out while populating the dma buffers.
      This is a hardening effort, issue was triggered by an errant version
      of the management tools and thus the BUG should not be seen in the
      field.
      
      [jejb: fixed up compile failure]
      Signed-off-by: NMark Salyzyn <aacraid@adaptec.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@HansenPartnership.com>
      09050715
  17. 21 6月, 2008 1 次提交
  18. 05 6月, 2008 1 次提交
  19. 03 5月, 2008 3 次提交
  20. 02 5月, 2008 1 次提交
  21. 20 4月, 2008 1 次提交
  22. 19 4月, 2008 2 次提交
  23. 16 4月, 2008 2 次提交
  24. 08 4月, 2008 3 次提交
  25. 12 2月, 2008 2 次提交