1. 02 9月, 2015 1 次提交
  2. 01 9月, 2015 12 次提交
  3. 31 8月, 2015 4 次提交
    • D
      ipv4: Fix 32-bit build. · 80ec1927
      David S. Miller 提交于
         net/ipv4/af_inet.c: In function 'snmp_get_cpu_field64':
      >> net/ipv4/af_inet.c:1486:26: error: 'offt' undeclared (first use in this function)
            v = *(((u64 *)bhptr) + offt);
                                   ^
         net/ipv4/af_inet.c:1486:26: note: each undeclared identifier is reported only once for each function it appears in
         net/ipv4/af_inet.c: In function 'snmp_fold_field64':
      >> net/ipv4/af_inet.c:1499:39: error: 'offct' undeclared (first use in this function)
            res += snmp_get_cpu_field(mib, cpu, offct, syncp_offset);
                                                ^
      >> net/ipv4/af_inet.c:1499:10: error: too many arguments to function 'snmp_get_cpu_field'
            res += snmp_get_cpu_field(mib, cpu, offct, syncp_offset);
                   ^
         net/ipv4/af_inet.c:1455:5: note: declared here
          u64 snmp_get_cpu_field(void __percpu *mib, int cpu, int offt)
              ^
      Reported-by: Nkbuild test robot <fengguang.wu@intel.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      80ec1927
    • K
      netlink: rx mmap: fix POLLIN condition · 0ef70770
      Ken-ichirou MATSUZAWA 提交于
      Poll() returns immediately after setting the kernel current frame
      (ring->head) to SKIP from user space even though there is no new
      frame. And in a case of all frames is VALID, user space program
      unintensionally sets (only) kernel current frame to UNUSED, then
      calls poll(), it will not return immediately even though there are
      VALID frames.
      
      To avoid situations like above, I think we need to scan all frames
      to find VALID frames at poll() like netlink_alloc_skb(),
      netlink_forward_ring() finding an UNUSED frame at skb allocation.
      Signed-off-by: NKen-ichirou MATSUZAWA <chamas@h4.dion.ne.jp>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      0ef70770
    • R
      net: Optimize snmp stat aggregation by walking all the percpu data at once · a3a77372
      Raghavendra K T 提交于
      Docker container creation linearly increased from around 1.6 sec to 7.5 sec
      (at 1000 containers) and perf data showed 50% ovehead in snmp_fold_field.
      
      reason: currently __snmp6_fill_stats64 calls snmp_fold_field that walks
      through per cpu data of an item (iteratively for around 36 items).
      
      idea: This patch tries to aggregate the statistics by going through
      all the items of each cpu sequentially which is reducing cache
      misses.
      
      Docker creation got faster by more than 2x after the patch.
      
      Result:
                             Before           After
      Docker creation time   6.836s           3.25s
      cache miss             2.7%             1.41%
      
      perf before:
          50.73%  docker           [kernel.kallsyms]       [k] snmp_fold_field
           9.07%  swapper          [kernel.kallsyms]       [k] snooze_loop
           3.49%  docker           [kernel.kallsyms]       [k] veth_stats_one
           2.85%  swapper          [kernel.kallsyms]       [k] _raw_spin_lock
      
      perf after:
          10.57%  docker           docker                [.] scanblock
           8.37%  swapper          [kernel.kallsyms]     [k] snooze_loop
           6.91%  docker           [kernel.kallsyms]     [k] snmp_get_cpu_field
           6.67%  docker           [kernel.kallsyms]     [k] veth_stats_one
      
      changes/ideas suggested:
      Using buffer in stack (Eric), Usage of memset (David), Using memcpy in
      place of unaligned_put (Joe).
      Signed-off-by: NRaghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
      Acked-by: NEric Dumazet <edumazet@google.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      a3a77372
    • R
  4. 30 8月, 2015 10 次提交
  5. 29 8月, 2015 13 次提交