1. 24 3月, 2011 5 次提交
    • B
      usb: musb: blackfin: fix typo in new dev_pm_ops struct · 8f7e7b87
      Bob Liu 提交于
      Cc: stable@kernel.org
      Signed-off-by: NBob Liu <lliubbo@gmail.com>
      Signed-off-by: NMike Frysinger <vapier@gentoo.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      8f7e7b87
    • M
      usb: musb: blackfin: fix typo in platform driver name · 417ddf86
      Mike Frysinger 提交于
      The modularization of the Blackfin driver set the name to "musb-blackfin"
      in all the boards, but "musb-bfin" in the driver itself.  Since the driver
      file name uses "blackfin", change the driver to "musb-blackfin".  This is
      also easier as it's only one file to change.
      
      Cc: stable@kernel.org
      Signed-off-by: NMike Frysinger <vapier@gentoo.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      417ddf86
    • H
      usb: musb: Fix for merge issue · 5f1e8ce7
      Hema HK 提交于
      There was conflict while merging 2 patches. Enabling vbus code
      is wrongly moved to error check if loop.
      
      This is a fix to resolve the merge issue.
      Signed-off-by: NHema HK <hemahk@ti.com>
      Cc: Felipe Balbi <balbi@ti.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      5f1e8ce7
    • A
      ehci-hcd: Bug fix: don't set a QH's Halt bit · b5a3b3d9
      Alan Stern 提交于
      This patch (as1453) fixes a long-standing bug in the ehci-hcd driver.
      
      There is no need to set the Halt bit in the overlay region for an
      unlinked or blocked QH.  Contrary to what the comment says, setting
      the Halt bit does not cause the QH to be patched later; that decision
      (made in qh_refresh()) depends only on whether the QH is currently
      pointing to a valid qTD.  Likewise, setting the Halt bit does not
      prevent completions from activating the QH while it is "stopped"; they
      are prevented by the fact that qh_completions() temporarily changes
      qh->qh_state to QH_STATE_COMPLETING.
      
      On the other hand, there are circumstances in which the QH will be
      reactivated _without_ being patched; this happens after an URB beyond
      the head of the queue is unlinked.  Setting the Halt bit will then
      cause the hardware to see the QH with both the Active and Halt bits
      set, an invalid combination that will prevent the queue from
      advancing and may even crash some controllers.
      
      Apparently the only reason this hasn't been reported before is that
      unlinking URBs from the middle of a running queue is quite uncommon.
      However Test 17, recently added to the usbtest driver, does exactly
      this, and it confirms the presence of the bug.
      
      In short, there is no reason to set the Halt bit for an unlinked or
      blocked QH, and there is a very good reason not to set it.  Therefore
      the code that sets it is removed.
      Signed-off-by: NAlan Stern <stern@rowland.harvard.edu>
      Tested-by: NAndiry Xu <andiry.xu@amd.com>
      CC: David Brownell <david-b@pacbell.net>
      CC: <stable@kernel.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      b5a3b3d9
    • M
      USB: Do not pass negative length to snoop_urb() · 9d02b426
      Michal Sojka 提交于
      When `echo Y > /sys/module/usbcore/parameters/usbfs_snoop` and
      usb_control_msg() returns error, a lot of kernel memory is dumped to dmesg
      until unhandled kernel paging request occurs.
      Signed-off-by: NMichal Sojka <sojkam1@fel.cvut.cz>
      Cc: stable@kernel.org
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      9d02b426
  2. 23 3月, 2011 35 次提交