1. 29 8月, 2011 1 次提交
    • J
      [SCSI] lpfc 8.3.26: Fix SYSFS interface issues · f7a919b4
      James Smart 提交于
      Fix SYSFS interface issues.
      
      - In the lpfc_sli4_pdev_status_reg_wait() routine, after initial 100ms delay
        following write to PHYSDEV_CONTROL register for the firmware reaction, check
        the RN bit and ERR bit of the SLIPORT_STATUS register. If none of them
        became 1, the previous PHYSDEV_CONTROL register should be considered failed
        due to lack of privilege and error for no permission should be returned
        immediately without getting into the wait for RDY bits on the SLIPORT_STATUS
        register.
      - Remove the driver check on dev->is_physfn before proceed to perform the
        PHYSDEV_CONTROL register write, and let the PCI function's privilege
        setting and driver handling of PHYSDEV_CONTROL register write failure to
        handle the reset-ability through the SLI port.
      - Added key to ctlreg_write to prevent unauthorized or unexpected write to
        the control register.
      - Change return to EACCES for sysfs access that are failed because hba_reset
        is disabled.
      Signed-off-by: NAlex Iannicelli <alex.iannicelli@emulex.com>
      Signed-off-by: NJames Smart <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      f7a919b4
  2. 27 7月, 2011 5 次提交
    • J
      [SCSI] lpfc 8.3.25: Add FCF priority failover functionality · 7d791df7
      James Smart 提交于
      This patch implements a new FCF failover policy for the lpfc driver. It
      allows the driver to choose which FCF to failover to based on the FCF
      priority. This patch also introduces a new sysfs parameter
      (fcf_failover_policy) to allow the user to choose which FCF failover policy
      to use.
      Signed-off-by: NAlex Iannicelli <alex.iannicelli@emulex.com>
      Signed-off-by: NJames Smart <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      7d791df7
    • J
      [SCSI] lpfc 8.3.25: Enhancements to Debug infrastructure · b76f2dc9
      James Smart 提交于
      Enhancements to Debug infrastructure
      
      - debugfs additions for new hardware.
      - Correct stack overflow in lpfc_debugfs_dumpHBASlim_data()
      - Correct warning on uninitialized reg_val in lpfc_idiag_drbacc_write()
      - Separated the iDiag command for capturing mailbox commands for generic
        issue mailbox command entry point and for BSG multi-buffer handling.
      - Added capturing dumping capabiliy of mailbox command and external buffer
        for the completion of the mailbox command so that the outcome can be
        examined.
      - Changed all the iDiag command structure data array indexing introduced so
        far with properly defined macros.
      - Added SLI4 device PCI BAR memory mapped register read/browse, write-by-
        value, set-bit, and clear-bit methods for both interface type 0 and
        interface type 2.
      - Corrected warnings on mbxstatus being uninitialized in error paths in
        lpfc_bsg.c
      Signed-off-by: NAlex Iannicelli <alex.iannicelli@emulex.com>
      Signed-off-by: NJames Smart <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      b76f2dc9
    • J
      [SCSI] lpfc 8.3.25: PCI and SR-IOV Fixes · 0a96e975
      James Smart 提交于
      PCI and SR-IOV Fixes
      
      - Call pci_save_state after the pci_restore_state completes.
      - After calling pci_enable_pcie_error_reporting() and checking the return
        value for logging messages from rc, reset rc to 0 to it will not later be
        interpreted for error.
      - Read PCI config space SR-IOV capability to get the number of VFs supported.
      - Check for the PF's supported number of VFs before invoking PCI enable sriov
        API call and log error message that user requested number of VFs is beyond
        the PF capability if such request is passed in.
      - Added check for Physical function with Virtual Functions attached. If so,
        first disable all the VFs before proceeding to device reset.
      Signed-off-by: NAlex Iannicelli <alex.iannicelli@emulex.com>
      Signed-off-by: NJames Smart <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      0a96e975
    • J
      [SCSI] lpfc 8.3.25: Miscellaneous Bug fixes and code cleanup · 88a2cfbb
      James Smart 提交于
      Miscellaneous Bug fixes and code cleanup
      
      - Fix 16G link speed reporting by adding check for 16G check.
      - Change the check and enforcement of MAILBOX_EXT_SIZE (2048B)
        to the check and enforcement of BSG_MBOX_SIZE - sizeof(MAILBOX_t) (3840B).
      - Instead of waiting for a fixed amount of time after performing firmware
        reset, the driver shall wait for the Lancer SLIPORT_STATUS register for the
        readiness of the firmware for bring up.
      - Add logging to indicate when dynamic parameters are changed.
      - Add revision and date to the firmware image format.
      - Use revision instead of rev_name to check firmware image version.
      - Update temporary offset after memcopy is complete for firmware update.
      - Consolidated the use of the macros to get rid of duplicated register
        offset definitions.
      - Removed the unused second parameter in routine lpfc_bsg_diag_mode_enter()
      - Enable debugfs when debugfs is enabled.
      - Update function comments for lpfc_sli4_alloc_xri and lpfc_sli4_init_rpi_hdrs.
      Signed-off-by: NAlex Iannicelli <alex.iannicelli@emulex.com>
      Signed-off-by: NJames Smart <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      88a2cfbb
    • J
      [SCSI] lpfc 8.3.25: T10 DIF Fixes · 7c56b9fd
      James Smart 提交于
      T10 DIF Fixes
      
      - Fix the case where the SCSI Host supplies the CRC and driver to controller
        protection is on.
      - Only support T10 DIF type 1. LBA always goes in ref tag and app tag is not
        checked.
      - Change the format of the sense data passed up to the SCSI layer to match the
        Descriptor Format Sense Data found in SPC-4 sections 4.5.2.1 and 4.5.2.2.
      - Fix Slip PDE implementation.
      - Remove BUG() in else casein lpfc_sc_to_bg_opcodes.
      Signed-off-by: NAlex Iannicelli <alex.iannicelli@emulex.com>
      Signed-off-by: NJames Smart <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      7c56b9fd
  3. 27 5月, 2011 3 次提交
  4. 10 5月, 2011 1 次提交
  5. 31 3月, 2011 1 次提交
  6. 24 3月, 2011 2 次提交
  7. 19 2月, 2011 3 次提交
  8. 22 12月, 2010 3 次提交
  9. 02 11月, 2010 1 次提交
  10. 26 10月, 2010 1 次提交
  11. 08 10月, 2010 2 次提交
  12. 06 9月, 2010 1 次提交
  13. 11 8月, 2010 1 次提交
  14. 07 8月, 2010 1 次提交
  15. 06 8月, 2010 1 次提交
  16. 28 7月, 2010 4 次提交
  17. 22 5月, 2010 1 次提交
  18. 12 4月, 2010 1 次提交
  19. 11 4月, 2010 1 次提交
  20. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  21. 03 3月, 2010 1 次提交
  22. 18 2月, 2010 1 次提交
  23. 19 1月, 2010 1 次提交
    • G
      [SCSI] lpfc: restore MSI-X/MSI support · 8605c46c
      George Kadianakis 提交于
      A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx interrupts.
      This patch restores lpfc's ability to support MSI-X/MSI interrupts that the
      "Addition of SLI4 Interface - Base Support" patch [2] broke.
      It reestablishes MSI-X as the default interrupt method and in case MSI-X is not
      supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.
      
      [1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
      [2]: commit da0436e9
      
      [James Smart:
      Background:
      Nothing Broke. This was intended.
      
      We had originally enabled MSI-X by default, but in qualification within the
      last 12 months, we encountered a major catch-22:
      
      There were at least 4 platforms, from 2 major OEMs, that :
      - Say they support MSI-X - platform routines work and act as if they do.
      - We enable it, generate a test interrupt to check they really do deliver it,
      and it works.
      - But shortly after attachment, the system hangs or loses interrupts,
      resulting in a bad system behavior.
      
      Given the distro's picking up the 2.6.32 kernel, we had to stick with a
      default of MSI-X off, with user-enabled MSI-X as these platforms couldn't get
      fixed.
      
      However, we're also now encountering platforms that require MSI-X and never
      INTx, so we must change. It's desired also for also for performance reasons.
      
      So - now (2.6.33) is the right time to re-enable MSI-X by default.
      ]
      [jejb: fix up comment on default values]
      Signed-off-by: NGeorge Kadianakis <desnacked@gmail.com>
      Acked-by: NJames Smart  <james.smart@emulex.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      8605c46c
  24. 05 12月, 2009 2 次提交