1. 22 10月, 2013 1 次提交
    • M
      s390/time: correct use of store clock fast · 8c071b0f
      Martin Schwidefsky 提交于
      The result of the store-clock-fast (STCKF) instruction is a bit fuzzy.
      It can happen that the value stored on one CPU is smaller than the value
      stored on another CPU, although the order of the stores is the other
      way around. This can cause deltas of get_tod_clock() values to become
      negative when they should not be.
      
      We need to be more careful with store-clock-fast, this patch partially
      reverts git commit e4b7b4238e666682555461fa52eecd74652f36bb "time:
      always use stckf instead of stck if available". The get_tod_clock()
      function now uses the store-clock-extended (STCKE) instruction.
      get_tod_clock_fast() can be used if the fuzziness of store-clock-fast
      is acceptable e.g. for wait loops local to a CPU.
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      8c071b0f
  2. 17 6月, 2013 1 次提交
  3. 08 3月, 2013 3 次提交
  4. 14 2月, 2013 1 次提交
  5. 11 2月, 2013 1 次提交
  6. 16 1月, 2013 1 次提交
    • H
      s390/time: fix sched_clock() overflow · ed4f2094
      Heiko Carstens 提交于
      Converting a 64 Bit TOD format value to nanoseconds means that the value
      must be divided by 4.096. In order to achieve that we multiply with 125
      and divide by 512.
      When used within sched_clock() this triggers an overflow after appr.
      417 days. Resulting in a sched_clock() return value that is much smaller
      than previously and therefore may cause all sort of weird things in
      subsystems that rely on a monotonic sched_clock() behaviour.
      
      To fix this implement a tod_to_ns() helper function which converts TOD
      values without overflow and call this function from both places that
      open coded the conversion: sched_clock() and kvm_s390_handle_wait().
      
      Cc: stable@kernel.org
      Reviewed-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      Signed-off-by: NHeiko Carstens <heiko.carstens@de.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      ed4f2094
  7. 08 1月, 2013 3 次提交
  8. 11 10月, 2012 1 次提交
  9. 28 9月, 2012 1 次提交
  10. 26 7月, 2012 1 次提交
  11. 20 7月, 2012 1 次提交
    • H
      s390/comments: unify copyright messages and remove file names · a53c8fab
      Heiko Carstens 提交于
      Remove the file name from the comment at top of many files. In most
      cases the file name was wrong anyway, so it's rather pointless.
      
      Also unify the IBM copyright statement. We did have a lot of sightly
      different statements and wanted to change them one after another
      whenever a file gets touched. However that never happened. Instead
      people start to take the old/"wrong" statements to use as a template
      for new files.
      So unify all of them in one go.
      Signed-off-by: NHeiko Carstens <heiko.carstens@de.ibm.com>
      a53c8fab
  12. 11 3月, 2012 1 次提交
  13. 05 3月, 2012 1 次提交
  14. 17 11月, 2011 1 次提交
    • C
      KVM: s390: Fix RUNNING flag misinterpretation · 9e6dabef
      Cornelia Huck 提交于
      CPUSTAT_RUNNING was implemented signifying that a vcpu is not stopped.
      This is not, however, what the architecture says: RUNNING should be
      set when the host is acting on the behalf of the guest operating
      system.
      
      CPUSTAT_RUNNING has been changed to be set in kvm_arch_vcpu_load()
      and to be unset in kvm_arch_vcpu_put().
      
      For signifying stopped state of a vcpu, a host-controlled bit has
      been used and is set/unset basically on the reverse as the old
      CPUSTAT_RUNNING bit (including pushing it down into stop handling
      proper in handle_stop()).
      
      Cc: stable@kernel.org
      Signed-off-by: NCornelia Huck <cornelia.huck@de.ibm.com>
      Signed-off-by: NCarsten Otte <cotte@de.ibm.com>
      Signed-off-by: NAvi Kivity <avi@redhat.com>
      9e6dabef
  15. 30 10月, 2011 1 次提交
  16. 24 7月, 2011 1 次提交
  17. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  18. 27 2月, 2010 2 次提交
  19. 21 9月, 2009 1 次提交
  20. 10 9月, 2009 1 次提交
  21. 05 8月, 2009 1 次提交
    • C
      KVM: s390: fix wait_queue handling · d3bc2f91
      Christian Borntraeger 提交于
      There are two waitqueues in kvm for wait handling:
      vcpu->wq for virt/kvm/kvm_main.c and
      vpcu->arch.local_int.wq for the s390 specific wait code.
      
      the wait handling in kvm_s390_handle_wait was broken by using different
      wait_queues for add_wait queue and remove_wait_queue.
      
      There are two options to fix the problem:
      o  move all the s390 specific code to vcpu->wq and remove
         vcpu->arch.local_int.wq
      o  move all the s390 specific code to vcpu->arch.local_int.wq
      
      This patch chooses the 2nd variant for two reasons:
      o  s390 does not use kvm_vcpu_block but implements its own enabled wait
         handling.
         Having a separate wait_queue make it clear, that our wait mechanism is
         different
      o  the patch is much smaller
      Report-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NChristian Borntraeger <borntraeger@de.ibm.com>
      Signed-off-by: NMarcelo Tosatti <mtosatti@redhat.com>
      Signed-off-by: NAvi Kivity <avi@redhat.com>
      d3bc2f91
  22. 10 6月, 2009 3 次提交
  23. 24 3月, 2009 1 次提交
  24. 09 1月, 2009 1 次提交
  25. 27 7月, 2008 1 次提交
    • C
      KVM: s390: Fix program check on interrupt delivery handling · 3cd61299
      Christian Borntraeger 提交于
      The current interrupt handling on s390 misbehaves on an error case. On s390
      each cpu has the prefix area (lowcore) for interrupt delivery. This memory
      must always be available. If we fail to access the prefix area for a guest
      on interrupt delivery the configuration is completely unusable. There is no
      point in sending another program interrupt to an inaccessible lowcore.
      Furthermore, we should not bug the host kernel, because this can be triggered
      by userspace. I think the guest kernel itself can not trigger the problem, as
      SET PREFIX and SIGNAL PROCESSOR SET PREFIX both check that the memory is
      available and sane. As this is a userspace bug (e.g. setting the wrong guest
      offset, unmapping guest memory) we should kill the userspace process instead
      of BUGing the host kernel.
      In the long term we probably should notify the userspace process about this
      problem.
      Signed-off-by: NChristian Borntraeger <borntraeger@de.ibm.com>
      Signed-off-by: NAvi Kivity <avi@qumranet.com>
      3cd61299
  26. 20 7月, 2008 1 次提交
  27. 07 6月, 2008 1 次提交
    • C
      KVM: s390: Fix race condition in kvm_s390_handle_wait · e52b2af5
      Carsten Otte 提交于
      The call to add_timer was issued before local_int.lock was taken and before
      timer_due was set to 0. If the timer expires before the lock is being taken,
      the timer function will set timer_due to 1 and exit before the vcpu falls
      asleep. Depending on other external events, the vcpu might sleep forever.
      This fix pulls setting timer_due to the beginning of the function before
      add_timer, which ensures correct behavior.
      Signed-off-by: NCarsten Otte <cotte@de.ibm.com>
      Signed-off-by: NAvi Kivity <avi@qumranet.com>
      e52b2af5
  28. 27 4月, 2008 2 次提交
    • M
      KVM: hlt emulation should take in-kernel APIC/PIT timers into account · 3d80840d
      Marcelo Tosatti 提交于
      Timers that fire between guest hlt and vcpu_block's add_wait_queue() are
      ignored, possibly resulting in hangs.
      
      Also make sure that atomic_inc and waitqueue_active tests happen in the
      specified order, otherwise the following race is open:
      
      CPU0                                        CPU1
                                                  if (waitqueue_active(wq))
      add_wait_queue()
      if (!atomic_read(pit_timer->pending))
          schedule()
                                                  atomic_inc(pit_timer->pending)
      Signed-off-by: NMarcelo Tosatti <mtosatti@redhat.com>
      Signed-off-by: NAvi Kivity <avi@qumranet.com>
      3d80840d
    • C
      KVM: s390: interrupt subsystem, cpu timer, waitpsw · ba5c1e9b
      Carsten Otte 提交于
      This patch contains the s390 interrupt subsystem (similar to in kernel apic)
      including timer interrupts (similar to in-kernel-pit) and enabled wait
      (similar to in kernel hlt).
      
      In order to achieve that, this patch also introduces intercept handling
      for instruction intercepts, and it implements load control instructions.
      
      This patch introduces an ioctl KVM_S390_INTERRUPT which is valid for both
      the vm file descriptors and the vcpu file descriptors. In case this ioctl is
      issued against a vm file descriptor, the interrupt is considered floating.
      Floating interrupts may be delivered to any virtual cpu in the configuration.
      
      The following interrupts are supported:
      SIGP STOP       - interprocessor signal that stops a remote cpu
      SIGP SET PREFIX - interprocessor signal that sets the prefix register of a
                        (stopped) remote cpu
      INT EMERGENCY   - interprocessor interrupt, usually used to signal need_reshed
                        and for smp_call_function() in the guest.
      PROGRAM INT     - exception during program execution such as page fault, illegal
                        instruction and friends
      RESTART         - interprocessor signal that starts a stopped cpu
      INT VIRTIO      - floating interrupt for virtio signalisation
      INT SERVICE     - floating interrupt for signalisations from the system
                        service processor
      
      struct kvm_s390_interrupt, which is submitted as ioctl parameter when injecting
      an interrupt, also carrys parameter data for interrupts along with the interrupt
      type. Interrupts on s390 usually have a state that represents the current
      operation, or identifies which device has caused the interruption on s390.
      
      kvm_s390_handle_wait() does handle waitpsw in two flavors: in case of a
      disabled wait (that is, disabled for interrupts), we exit to userspace. In case
      of an enabled wait we set up a timer that equals the cpu clock comparator value
      and sleep on a wait queue.
      
      [christian: change virtio interrupt to 0x2603]
      Acked-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      Signed-off-by: NHeiko Carstens <heiko.carstens@de.ibm.com>
      Signed-off-by: NCarsten Otte <cotte@de.ibm.com>
      Signed-off-by: NChristian Borntraeger <borntraeger@de.ibm.com>
      Signed-off-by: NAvi Kivity <avi@qumranet.com>
      ba5c1e9b