1. 15 5月, 2014 2 次提交
    • D
      drm/i915: Only do gtt cleanup in vma_unbind for the global vma · 8b1bc9b4
      Daniel Vetter 提交于
      Otherwise we end up tearing down fences when e.g. the client quits
      way too early. Might or might not fix a fence pin_count BUG Ville has
      reported.
      
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      8b1bc9b4
    • D
      drm/i915: Don't drop pinned fences · aff10b30
      Daniel Vetter 提交于
      Userspace can currently provoke this when e.g. trying to use a pinned
      scanout as a cursor or overlay target. Later on that might lead to
      some fun fence pin count mayhem.
      
      Spurred by Ville's report that something goes wrong here and
      originally I've thought that this might slip through the pwrite gtt
      fastpath. But that one checks of obj tiling, so should be ok.
      
      But one thing that _does_ blow up is the vma unbinding with more than
      one address space. The next patch will fix this.
      
      v2: Use a WARN_ON - Chris pointed out that we already catch all cases
      so userspace can't provoke this like I've originally feared.
      
      While reviewing relevant code I've noticed a pile of DRM_ERROR in the
      overlay&cursor code which are all triggerable by userspace. Tune them
      down while at it.
      
      v3: Split out the DRM_ERROR->DRM_DEBUG_KMS change into a separate patch,
      as requested by Chris.
      
      Cc: Chris Wilson <chris@chris-wilson.co.uk>
      Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
      Tested-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      aff10b30
  2. 14 5月, 2014 8 次提交
  3. 13 5月, 2014 26 次提交
  4. 08 5月, 2014 2 次提交
  5. 07 5月, 2014 2 次提交
    • B
      drm/i915: Make aliasing a 2nd class VM · 6e7186af
      Ben Widawsky 提交于
      There is a good debate to be had about how best to fit the aliasing
      PPGTT into the code. However, as it stands right now, getting aliasing
      PPGTT bindings is a hack, and done through implicit arguments. To make
      this absolutely clear, WARN and return an error if a driver writer tries
      to do something they shouldn't.
      
      I have no issue with an eventual revert of this patch. It makes sense
      for what we have today.
      Signed-off-by: NBen Widawsky <ben@bwidawsk.net>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      6e7186af
    • B
      drm/i915: Use topdown allocation for PPGTT PDEs on gen6/7 · 3e8b5ae9
      Ben Widawsky 提交于
      It was always the intention to do the topdown allocation for context
      objects (Chris' idea originally). Unfortunately, I never managed to land
      the patch, but someone else did, so now we can use it.
      
      As a reminder, hardware contexts never need to be in the precious GTT
      aperture space - which is what is what happens with the normal bottom up
      allocation we do today. Doing a top down allocation increases the odds
      that the HW contexts can get out of the way, especially with per FD
      contexts as is done in full PPGTT
      Signed-off-by: NBen Widawsky <ben@bwidawsk.net>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      3e8b5ae9