Skip to content

R
raspberrypi-kernel

openeuler / raspberrypi-kernel

通知 13
Star 1
Fork 0
R
raspberrypi-kernel
切换分支/标签
  1. 09 1月, 2013 1 次提交
  3. 08 10月, 2012 1 次提交
    • P
      drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c: fix error return code · 2dfc9671
      由 Peter Senna Tschudin 提交于 
      The function qlcnic_probe() return 0 for success and negative value
for most of its internal tests failures. There is one exception
that is error case going to err_out_free_netdev:. For this error case,
the function abort its success execution path, but returns non negative
value, making it difficult for a caller function to notice the error.

This patch fixes the error case that do not return negative value.

This was found by Coccinelle, but the code change was made by hand.
This patch is not robot generated.

A simplified version of the semantic match that finds this problem is
as follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>
Signed-off-by: NPeter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2dfc9671
  5. 08 9月, 2012 1 次提交
  7. 16 6月, 2012 1 次提交
  9. 08 6月, 2012 2 次提交
  11. 11 5月, 2012 1 次提交
    • J
      drivers/net: Convert compare_ether_addr to ether_addr_equal · 2e42e474
      由 Joe Perches 提交于 
      Use the new bool function ether_addr_equal to add
some clarity and reduce the likelihood for misuse
of compare_ether_addr for sorting.

Done via cocci script:

$ cat compare_ether_addr.cocci
@@
expression a,b;
@@
-	!compare_ether_addr(a, b)
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	compare_ether_addr(a, b)
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) == 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!ether_addr_equal(a, b) != 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) == 0
+	!ether_addr_equal(a, b)

@@
expression a,b;
@@
-	ether_addr_equal(a, b) != 0
+	ether_addr_equal(a, b)

@@
expression a,b;
@@
-	!!ether_addr_equal(a, b)
+	ether_addr_equal(a, b)
Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      2e42e474
  13. 27 4月, 2012 1 次提交
  15. 24 3月, 2012 1 次提交
  17. 24 2月, 2012 1 次提交
  19. 05 2月, 2012 2 次提交
  21. 01 2月, 2012 1 次提交
  23. 09 12月, 2011 1 次提交
  25. 17 11月, 2011 1 次提交
  27. 30 10月, 2011 2 次提交
  29. 19 10月, 2011 1 次提交
  31. 07 10月, 2011 1 次提交
  33. 24 9月, 2011 1 次提交
  35. 16 9月, 2011 1 次提交
  37. 30 8月, 2011 2 次提交
  39. 18 8月, 2011 1 次提交
  41. 11 8月, 2011 1 次提交
  43. 01 8月, 2011 3 次提交
  45. 22 7月, 2011 1 次提交
  47. 18 7月, 2011 1 次提交
    • D
      net: vlan, qlcnic: make vlan_find_dev private · 69ecca86
      由 David Lamparter 提交于 
      there is only one user of vlan_find_dev outside of the actual vlan code:
qlcnic uses it to iterate over some VLANs it knows.

let's just make vlan_find_dev private to the VLAN code and have the
iteration in qlcnic be a bit more direct. (a few rcu dereferences less
too)
Signed-off-by: NDavid Lamparter <equinox@diac24.net>
Cc: Patrick McHardy <kaber@trash.net>
Cc: Amit Kumar Salecha <amit.salecha@qlogic.com>
Cc: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Cc: linux-driver@qlogic.com
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      69ecca86
  49. 14 7月, 2011 3 次提交
  51. 24 6月, 2011 6 次提交
  53. 22 6月, 2011 1 次提交